sky-uk / cezanne Goto Github PK

You need some kind of reference folder to make this whole thing work. It would be useful if the gem created a folder for your reference shots automatically. That way, new consumers don't need to worry about structuring folders to get going. This could follow the opionated folder structure on the README.md.

Is it possible to run and generate the new screenshots locally without updating a Dropbox folder?

It would be useful to run tests locally but not update the new screenshots in Dropbox, in case someone/something else is running a build.

Is it enough to change the uid? Will that cause a new folder on Dropbox to be created with a set of new screenshots?

From time to time I see the following:

An error occurred in an after(:context) hook.
DropboxError: Cannot create folder 'new_screenshots' because a file or folder already exists at path '/masthead/289/new_screenshots'
occurred at /home/ubuntu/vendor/bundle/ruby/1.9.1/gems/dropbox-sdk-1.6.4/lib/dropbox_sdk.rb:110:in `parse_response'

Presumably a race condition creating the folder when you run this tool in parallel on tools like CircleCI.

The problem: if you run tests on ie8 and ie9 the generated files use the same name.

Current the file name is made up of page_BROWSER_NAME, would it be possible to add the browser version to the file name?

We have noticed this repository was marked as public. There are certain standards required before a repository in the sky-uk org can be made public, including the presence of valid LICENSE.md, README.md, and CONTRIBUTING.md files.

• Repos without license information are immediately made private.
• Repos failing the other criteria will be made private after 30 days.

Please resolve these problems ASAP and close this GitHub issue when you have done so.

If you have any questions, please ask them on the #github Slack channel.

At the moment, if you run a series of browser tests, when the first one fails, execution of the test suite is aborted. Say you are creating a set of new screenshots for a test you've just added. You must either re-run the tests once for each browser and approve, or manually copy screenshots in via dropbox.

It would be more useful if the whole suite was run and all errors reported at the end. So in the example above, you could go through the approval app and approve all the new screenshots in one go.

I've noticed that some gems output instructions when you bundle. It would be useful if we output a message if imagemagick is not installed on the system during the bundle. Suggesting to, e.g., brew install image...

When no visible changes can be seen screenshots are failing

https://github.com/BSkyB/cezanne/blob/master/lib/cezanne/rspec.rb#L25