skrulcik / policy-agnostic-jagger Goto Github PK

• Dependencies should be associated with the predicate, rather than the field (in case we use the same label to protect multiple fields in the future)
• Ideally default values could be static variables, rather than inner classes. The best way to do this is probably add yet another annotation to tie to labels, then just verify that the static variable is of the correct type.

Only one qualifier can be applied at a time in Dagger, which is an issue if we are constantly using the @Raw qualifier. We would like to be able to qualify things like @Doctor User user and @Patient User user but cannot with the @Raw specification.

Creating a workaround, whether it be a module-based system or generated @Raw_Doctor annotations, is necessary before Jagger can be effectively used in applications.

• Add messages for any validation checks (including those in the PolicyRule builder)
• Store a the processing environment as an instance variable in the validation class, and directly report results to the processing environment as an error (still return false)

Square created an AutoValue extension to redact properties from toString. If we could evaluate toString in a Jagger context, that would be great, but otherwise, redaction is a good option.

Field restriction is fine in most cases, but it there are cases when rather than anonymizing fields, the record should just be invisible. A motivating example I'm working with right now is a medical record search. If permissions for the medical record don't exist, it should not show up in search.

Such a record wouldn't show up in search as-is because all of the fields would be re-written as "REDACTED" (or some other constant). It is tedious for the programmer and wasteful at runtime if the only way to redact an entire object is to individually redact every field.

Annotation processing rounds are naturally repeated. This natural repetition, along with the persistence of the ProcessingStep instances between rounds means that any fields holding processing information from one round will be carried over to the next. This triggers some warnings I have in place for the policy rule collection step that are supposed to warn against re-used labels.

I should either clear instance variables between rounds, or purposefully track what repetitions I expect in future rounds.