skarpdev / hapi-graphql-2 Goto Github PK

I have also implemented the following test function multiple times in various projects - maybe we should extract it and put it into a hapi-test-utils package.

const hasRoute = (server, path, method) => {
  let foundRoute = false;

  server.table().forEach((route) => {
    if (route.path === path && route.method.toLowerCase() === method.toLowerCase()) {
      foundRoute = true;
    }
  });

  return foundRoute;
};

If the passed options are malformed the plugin will fail with strange errors during runtime, which is not very helpful.

But first we need #3

If a schema being loaded into this plugin has errors, and a client requests the schema (like graphql playground) the server / plugin dies a horrible death which masks the fact that the schema had trouble and simply emits to the console:

Debug: internal, implementation, error 
core.js:122
    TypeError: Cannot destructure property `statusCode` of 'undefined' or 'null'.
    at /workspace/api/node_modules/hapi-graphql-2/src/index.js:277:40
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:188:7)

However the underlying error was really:

"The type of XXXInput.Prop must be Input Type but got: AnotherTypeThatMakesGraphQLPuke.

Hence the error handler should be a bit more intelligent to avoid such crashes.