sjivan / gwt-ext Goto Github PK

com.gwtext.client.widgets.form.Form class does not have start() method.
This method could be interesting to reopen a container that has already
been created before with column, container or fieldset methods.


  public void start(Layout layout) {
    containerExt(layout.getJsObj(), getJsObj());
  }

  native static void containerExt(JavaScriptObject container,
JavaScriptObject form)/*-{
  form.start(container);
}-*/;}


What version of the product are you using?
gwt-ext 0.9

This is the same as an earlier issue with getTab(String).
My fix looks like:

$ svn diff TabPanel.java 
Index: TabPanel.java
===================================================================
--- TabPanel.java       (revision 407)
+++ TabPanel.java       (working copy)
@@ -188,11 +188,13 @@
     }-*/;

     public TabPanelItem getActiveTab() {
-        return new TabPanelItem(getActiveTab(jsObj));
+        JavaScriptObject tab = getActiveTab(jsObj);
+        return tab == null ? null : new TabPanelItem(tab);
     }

     private native JavaScriptObject getActiveTab(JavaScriptObject tp) /*-{
-        return tp.getActiveTab();
+        var tab = tp.getActiveTab();
+        return tab ? tab : null;
     }-*/;

Would be a great space saver if you could add a setTooltip(String title,
String text) to ButtonConfig (and other places) like so:

public void setTooltip(String title, String text) {
    JavaScriptObjectHelper.setAttribute(jsObj, "tooltip", new
QuickTipsConfig() {
        {
            setTitle("Open All");
            setText("Opens all visits in tabs");
        }
    }.getJsObj()));
}

Here is the method :
public void setInvalidText(boolean invalidText) {
  JavaScriptObjectHelper.setAttribute(jsObj, "invalidText", invalidText);
}

The signature should be
com.gwtext.client.widgets.form.FieldConfig#setInvalidText(String)

What version of the product are you using?
0.9

What steps will reproduce the problem?
1. create A Combobox with a store
2. try to set a value select with setValue(String value)
3.

What is the expected output? What do you see instead?
Combobox with selected value, instead nothing happens

What version of the product are you using? On what operating system?
gwt-ext 0.9,gwt 1.4 RC1 Win XP sp2, FF2.0.0.4

Please provide any additional information below.

Correct implementation should be :

    public native void setValue(String value) /*-{
        var cb = [email protected]::jsObj;
        cb.setValue(value);
    }-*/;
then it works like charm.

Ext manual:

maxValue : Date/String      DateField
The maximum allowed date. Can be either a Javascript date object or a
string date in a valid format (defaults to null).

minValue : Date/String      DateField
The minimum allowed date. Can be either a Javascript date object or a
string date in a valid format (defaults to null).

Ext accepts a Date:

/**
 * Parse a value into a formatted date using the specified format pattern.
 * @param {Mixed} value The value to format
 * @param {String} format (optional) Any valid date format string (defaults
to 'm/d/Y')
 * @return {String} The formatted date string
 */
date : function(v, format){
    if(!v){
        return "";
    }
    if(!(v instanceof Date)){
        v = new Date(Date.parse(v));
    }
    return v.dateFormat(format || "m/d/Y");
},

In line of other widgets (ToolbarButton, ToolbarMenuButton), ContentPanel
should have a constructor that takes it's id, title and config in one
constructor.

new ContentPanel("cpid", "Title", contentPanelConfig);

IE (inc hosted mode) only - When you add Toolbar buttons to a Grid that is
nested inside a VerticalPanel, the button spacing is too large. As you
mouseover the buttons the spacing reduces until it is the correct amount.

Example code to reproduce problem:

package au.com.toll.gwtextdemo.client;

import com.google.gwt.core.client.EntryPoint;
import com.google.gwt.user.client.ui.Composite;
import com.google.gwt.user.client.ui.RootPanel;
import com.google.gwt.user.client.ui.VerticalPanel;
import com.gwtext.client.core.ExtElement;
import com.gwtext.client.data.ArrayReader;
import com.gwtext.client.data.Field;
import com.gwtext.client.data.MemoryProxy;
import com.gwtext.client.data.RecordDef;
import com.gwtext.client.data.Store;
import com.gwtext.client.data.StringField;
import com.gwtext.client.widgets.ButtonConfig;
import com.gwtext.client.widgets.QuickTips;
import com.gwtext.client.widgets.Toolbar;
import com.gwtext.client.widgets.ToolbarButton;
import com.gwtext.client.widgets.grid.ColumnConfig;
import com.gwtext.client.widgets.grid.ColumnModel;
import com.gwtext.client.widgets.grid.EditorGrid;
import com.gwtext.client.widgets.grid.EditorGridConfig;
import com.gwtext.client.widgets.grid.GridView;
import com.gwtext.client.widgets.grid.RowSelectionModel;

public class Demo implements EntryPoint {

    /**
       * This is the entry point method.
       */
      public void onModuleLoad() {  

        rootPanel.add(new TestPanel());

      }

      public class TestPanel extends Composite {

            private boolean init = false;
            private VerticalPanel vp;

            public TestPanel() {
                vp = new VerticalPanel();
                initWidget(vp);
            }

            protected void onLoad() {
                if (!init) {
                    init = true;
                    vp.add(createTestGrid());
                }
            }

    }

      private EditorGrid createTestGrid() {
          EditorGrid grid = new EditorGrid("grid", "400px", "200px",
createStore(), createColumnModel(), new RowSelectionModel(true), new
EditorGridConfig() {
                {
                    setClicksToEdit(1);
                }
            });
          grid.render();
          createToolbar(grid);
          return grid;
      }


      private void createToolbar(EditorGrid grid) {
            GridView view = grid.getView();
            ExtElement headerPanel = view.getHeaderPanel(true);
            Toolbar toolbar = new Toolbar(headerPanel);

            // Add buttons
            toolbar.addButton(new ToolbarButton("Button 1", new ButtonConfig()));                       
            toolbar.addButton(new ToolbarButton("Button 2", new ButtonConfig()));           
            toolbar.addButton(new ToolbarButton("Button 3", new ButtonConfig()));
        }

        private static Store createStore() {
            Object[][] records = new Object[][] {
                    { "A value", "Another Value" }
            };

            //  create a grid from an array
            MemoryProxy proxy = new MemoryProxy(records);
            RecordDef recordDef = new RecordDef(
                    new Field[]{
                            new StringField("col1"),
                            new StringField("col2")
                    }
            );
            ArrayReader reader = new ArrayReader(recordDef);
            Store store = new Store(proxy, reader);
            store.load();

            return store;
        }

        private static ColumnModel createColumnModel() {

            // set up column model
            ColumnModel columnModel = new ColumnModel(new ColumnConfig[]{

                    new ColumnConfig() {
                        {
                            setHeader("Column 1");
                            setWidth(75);
                            setSortable(true);
                            setDataIndex("col1");
                        }
                    },new ColumnConfig() {
                        {
                            setHeader("Column 2");
                            setWidth(75);
                            setSortable(true);
                            setDataIndex("col2");
                        }
                    }
            });
            return columnModel;
        }
}

I started integrating gwt-ext into my project. Currently most of the source
files are missing javadocs so I'll try to contribute a bit while Sanjiv can
concentrate on adding new features in.

I'll do the following to the source files:

 * Making lines are below 80 chars in length.
 * Sorting fields, constructors, inner classes, methods.
 * Adding javadoc to methods, fields etc etc.

Please keep this issue open as I'll be submitting patches for reviews.

Users of Ext typically need to set the blank image url but in GWT-Ext this
can be done internally making it one less thing for the users to deal with.

Form.addButton(Button) results in two similar looking buttons being
displayed instead of just one. 

http://groups.google.com/group/gwt-ext/browse_thread/thread/24cfd8d67b10ade5/6f0
3681cf9f6e543?lnk=gst&q=add+Button&rnum=1#6f03681cf9f6e543

Double t, not double l.

Little useful utility class:

import com.gwtext.client.data.Record;
import com.gwtext.client.data.StoreTraversalCallback;

/**
 * Chains multiple {@link StoreTraversalCallback}s.
 *
 */
public class StoreTraversalCallbackChain implements StoreTraversalCallback {
    private StoreTraversalCallback[] chain;

    public StoreTraversalCallbackChain(StoreTraversalCallback callback1,
StoreTraversalCallback callback2) {
        chain = new StoreTraversalCallback[]{callback1, callback2};
    }

    public StoreTraversalCallbackChain(StoreTraversalCallback callback1,
StoreTraversalCallback callback2,
                                       StoreTraversalCallback callback3) {
        chain = new StoreTraversalCallback[]{callback1, callback2, callback3};
    }

    public StoreTraversalCallbackChain(StoreTraversalCallback callback1,
StoreTraversalCallback callback2,
                                       StoreTraversalCallback callback3,
StoreTraversalCallback callback4) {
        chain = new StoreTraversalCallback[]{callback1, callback2,
callback3, callback4};
    }

    public boolean execute(Record record) {
        for (int i = 0; i < chain.length; i++) {
            if (chain[i] != null && !chain[i].execute(record)) return false;
        }
        return true;
    }
}

TextFieldConfig has a setBlanktext setter:

public void setBlanktext(String blanktext) {
    JavaScriptObjectHelper.setAttribute(jsObj, "blanktext", blanktext);
}

The blanktext here should be blankText (note the capital letter T).

What steps will reproduce the problem?
1. create a TreePanel.
2. add a TreePanelListenerAdapter, overriding the method onExpand.
3. run the application, expand the node... 

What is the expected output? What do you see instead?
The onExpand is never called... whereas it should be.

What version of the product are you using? On what operating system?
gwtext-0.9, on windows XP

Please provide any additional information below.
What you did is really great!
Thanks.

I tried to directly attach a ComboBox widget to a panel but got a
NullPointerException in BaseExtWidget.java:78

With plain ext the following is possible:

// simple array store
var store = new Ext.data.SimpleStore({
    fields: ['abbr', 'state'],
    data : exampleData
});
var combo = new Ext.form.ComboBox({
    store: store,
    displayField:'state',
    typeAhead: true,
    mode: 'local',
    triggerAction: 'all',
    emptyText:'Select a state...',
    selectOnFocus:true
});
combo.applyTo('local-states');

Imho this should be supported with gwt-ext as well. Workaround for now is
placing a form around each ComboBox - but that leads to a label element
before the combobox - which is not what everybody needs...

cheers

Kai

Since NestedLayoutPanel extends ContentPanel, one should be able to set the
ID for the NestedLayoutPanel, but this is not possible.

Could you please add a ID property to the constructor, or create a new
constuctor taking an ID (like ContentPanel)?

These are already specified (and implemented the same) in TextFieldConfig.

In Ext you can do this:

var df = new Ext.form.DateField({format: 'Y-m-d',minValue: '2000-01-01',
                                value: new Date()});

Meaning that DateFieldConfig should have a setValue(Date date).

The GwtExt.css, GwtExt.html files are copied by GWT (upon compilation) to
the root since they are in the public package in the jar. But they are not
needed to run GWT-Ext.

What steps will reproduce the problem?

JsonStore store = new JsonStore("json", "list.visits", new Field[]{
        new StringField("summary"),
        new DateField("start"),
        new DateField("end")}
);

What is the expected output? What do you see instead?

invokeNativeHandle(@com.gwtext.client.data.JsonStore::create(Lcom/google/gwt/cor
e/client/JavaScriptObject;)):
JavaScript undefined, expected com.google.gwt.core.client.JavaScriptObject
    at com.google.gwt.dev.shell.JsValueGlue.get(JsValueGlue.java:101)
    at
com.google.gwt.dev.shell.ModuleSpace.invokeNativeHandle(ModuleSpace.java:226)
    at
com.google.gwt.dev.shell.JavaScriptHost.invokeNativeHandle(JavaScriptHost.java:8
9)
    at com.gwtext.client.data.JsonStore.create(JsonStore.java:45)
    at com.gwtext.client.data.JsonStore.<init>(JsonStore.java:42)
    at ec.ep.sdw.visep.web.client.ui.VisitGrid.<init>(VisitGrid.java:32)
    at ec.ep.sdw.visep.web.client.ui.VisitListView.<init>(VisitListView.java:81)
    at ec.ep.sdw.visep.web.client.BookingAgent.onModuleLoad(BookingAgent.java:550)
    at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.jav
a:25)

Not in the source, svn or todo list. BasicDialog's are tasty on the BBQ.

What steps will reproduce the problem?
1. Browse the show case
2. Dialogs -> Message Box and Progress
3. Click "show me" for the multi-line prompt example

What is the expected output? What do you see instead?
The prompt should be "Please enter your address" instead of "Please enter
yuor address"

Now hides the MessageBox, doesn't return a boolean either (signature is wrong).

What steps will reproduce the problem?
1. you are obliged to pass a provider to restoreState

public void restoreState(Provider provider) {
    JavaScriptObject jsProviderObj = provider == null ? null :
provider.getJsObj();
    restoreState(jsObj, jsProviderObj);
}

What is the expected output? What do you see instead?

Ext.js defines the provider as optional. Add thus the method restoreState()
without the need to pass a provider.

provider : Ext.state.Provider  (optional) An alternate state provider

What steps will reproduce the problem?
1. call setTitle("string") (on ColorPalette in our case)
2. this calls DOM.setElementAttribute(getElement(), "title", title);
3. but getElement return the ExtElement

For users combining GWT widgets and GWT-Ext widgets; better use
clear.cache.gif as blank image URL, like so:

Ext.setBlankImageUrl(GWT.getModuleBaseURL() + "clear.cache.gif");

The clear.cache.gif is in the root always. Another advantage is that users
not using Ext widgets do not need to include the Ext s.gif image. 

com.gwtext.client.widgets.form.ComboBoxConfig class has the setter :

public void setTransform(String id) {
    JavaScriptObjectHelper.setAttribute(jsObj, "id", id);
}

This method shouldn't set "id" property, but "transform"

What version of the product are you using?
gwtext 0.9

It's autoHide, not autohide, see line 69 in LayoutRegionConfig.

gwtc:
    [mkdir] Created dir:
D:\projects\gwt\gwt-ext\gwtext\build\out\samples\Showcase\www
     [java] Output will be written into
D:\projects\gwt\gwt-ext\gwtext\build\out\samples\Showcase\www\com.gwtext.sample.
showcase.Showcase
     [java]    Analyzing permutation #1
     [java]       [ERROR] Errors in
jar:file:/D:/projects/gwt/gwt-ext/gwtext/build/lib/gwtext.jar!/com/gwtext/client
/widgets/grid/CellSelectionModel.java
     [java]          [ERROR] Line 50:  Unresolvable native reference to
method 'onSelectionChange' in type
'com.gwtext.client.widgets.grid.event.CellSelectionModelListener' (did y
ou mean
'onSelectionChange(Lcom/gwtext/client/widgets/grid/CellSelectionModel;Lcom/gwtex
t/client/data/Record;[[I)'?)
     [java]       [ERROR] Cannot proceed due to previous errors
     [java] [ERROR] Build failed

Change the order of width and height parameters in Grid, EditorGrid and
BorderLayout. The convention is normally width followed by height. 

http://groups.google.com/group/gwt-ext/browse_thread/thread/a1e5f1c48ea23aa6

The Ext documentation states that the Toolbar widget can take either a
String, a HTML element or an Ext Element in its constructor.

Currently gwtext only supports a String. It needs to support the other two
parameter types.

In Store class

return store.insert(inedx, recordJ)

should read:

return store.insert(index, recordJ)

in code:

public native void insert(int index, Record record) /*-{
        var store = [email protected]::jsObj;
        var recordJ = [email protected]::jsObj;
        return store.insert(inedx, recordJ); // <------ typo
}-*/;

In order to correctly testing using Selenium, we need to assign an Id to
most of the UI elements. Therefore it is essential that we can assign an Id
to all toolbar elements.

What steps will reproduce the problem?
1. create a new DateField
2. call setValue(new Date())
3. check if the date has been set in the UI

What is the expected output? What do you see instead?

Expected filled-in date. Got error message: "input.match is not a
function". Note however that this could be an Ext (1.1 RC1) problem.

Ext supports this:

layout.getRegion('center').getTabs().getTab(1).textEl.update('<img
src="../Resources/images/icons/add.png" alt="" />')

What steps will reproduce the problem?
1. create a ToolbarTextItem with some text
2. try to change the text using item.getEl().update("other text", false);

What is the expected output? What do you see instead?

Toolbar text changes. 'update is not a function'. Using latest svn.

What steps will reproduce the problem?
1. unable to call store.setParams(UrlParam[] params)

What is the expected output? What do you see instead?

Ext allows for 

store.baseParams = {
// your filtering criteria
};

store.load(...);

See http://extjs.com/forum/showthread.php?t=2701.

From the Ext page:

"All current bugs reported to date for 1.1 have been addressed and
additional documentation updates have been made. One notable change is the
upgrade of DomQuery in 1.1 as well. It's now even faster than before and
handles more selectors. 1.1 is getting very close to final, so please let
us know if you find any remaining bugs!"

http://groups.google.com/group/gwt-ext/browse_thread/thread/4d656f77e2652806

Unsure if it's a bug or upgrade problem, but the update function (now)
takes 3 params:

public function update( String html, [Boolean loadScripts], Function callback )

while GWT-Ext takes only 2: 

public native void update(String html, boolean loadScripts) /*-{
    var el = [email protected]::jsObj;
    el.update(html, loadScripts);
}-*/;

What steps will reproduce the problem?
1. use a numeric Field [new IntegerField("xyz")]
2. use a numeric Editor in ColumnConfig
setEditor(new GridEditor(new NumberField(new NumberFieldConfig() { ... }
3. create an EditorGrid and attach a EditGridListener
EditorGrid grid = new EditorGrid("grid", "100%", "100%", store, colModel);
grid.addEditorGridListener(new EditorGridListener() { ... }
4. double-click on a cell to edit it

What is the expected output? What do you see instead?
expected: an editable field
instead exception in console:
com.google.gwt.dev.shell.HostedModeException: Calling method
'doBeforeEdit': JS value of type number, expected string
    at com.google.gwt.dev.shell.JsValueGlue.get(JsValueGlue.java:207)
    at
com.google.gwt.dev.shell.ie.SwtOleGlue.convertVariantsToObjects(SwtOleGlue.java:
57)
    at
com.google.gwt.dev.shell.ie.IDispatchImpl.callMethod(IDispatchImpl.java:119)
    at com.google.gwt.dev.shell.ie.IDispatchProxy.invoke(IDispatchProxy.java:150)
    at com.google.gwt.dev.shell.ie.IDispatchImpl.Invoke(IDispatchImpl.java:293)
    at com.google.gwt.dev.shell.ie.IDispatchImpl.method6(IDispatchImpl.java:196)
    at org.eclipse.swt.internal.ole.win32.COMObject.callback6(COMObject.java:117)
    at org.eclipse.swt.internal.win32.OS.DispatchMessageW(Native Method)
    at org.eclipse.swt.internal.win32.OS.DispatchMessage(OS.java:1925)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2966)
    at com.google.gwt.dev.GWTShell.pumpEventLoop(GWTShell.java:689)
    at com.google.gwt.dev.GWTShell.run(GWTShell.java:550)
    at com.google.gwt.dev.GWTShell.main(GWTShell.java:321)

and the field is not editable.

What version of the product are you using? On what operating system?
GWT: latest (1.4rc1)
gwt-ext: latest (0.9)
eclipse: latest (3.3)

Please provide any additional information below.
works fine as long as no listener is added, like in the Grid sample 2

In ColumnConfig (line 71) it is assumed that the value (s) is non-null all
the time (var str = s.toString();). This leads to a Javascript error 's has
no properties' when s is null.

Add a public boolean getAsBoolean(String field) to the Record class, in
line with the other utility methods (getAsFloat etc).

public void setMinWidth(boolean minWidth) {
    JavaScriptObjectHelper.setAttribute(jsObj, "minWidth", minWidth);
}

Must be int.

Ext JS docs:

enableListenerCollection

True to automatically purge event listeners after uncaching an element
(defaults to false). Note: this only happens if enableGarbageCollector is
true. This property is defined by Ext.

The implementation of the beforequery event proxy in addComboBoxListener
takes the wrong parameters in the function delegate. It currently has the
signature:

function(fld, o)

where fld is the combobox and o is the event object. The Ext Docs say that
this event has just one parameter being the event object which has a field
called 'combo' pointing to the combobox generating the event. Ie the
signature should be:

function(o) where o is the event object.

At least this is my interpretation of the Ext code and docs which are a bit
confusing. Applying this change locally seemed to work.

$ svn diff RowSelectionModel.java 
Index: RowSelectionModel.java
===================================================================
--- RowSelectionModel.java      (revision 419)
+++ RowSelectionModel.java      (working copy)
@@ -63,11 +63,13 @@
     }-*/;

     public Record getSelected() {
-        return new Record(getSelected(jsObj));
+        JavaScriptObject sel = getSelected(jsObj);
+        return sel == null ? null : new Record(sel);
     }

     private native JavaScriptObject getSelected(JavaScriptObject sm) /*-{
-        return sm.getSelected();
+        var sel = sm.getSelected();
+        return sel ? sel : null;
     }-*/;

The Ext documentation says that the SimpleStore's 'id' config parameter is
an index into the passed in array and is of type Number. However
SimpleStore's constructor and config object treat it as a String.

Signatures should be changed to take an integer.