Inverting the if statment, could improve code readability and maintainability.

Replace

		if (Target.bBuildEditor)
		{
			PublicDependencyModuleNames.AddRange(new[]
			{
				"AnimGraph"
			});

			PrivateDependencyModuleNames.AddRange(new[]
			{
				"BlueprintGraph"
			});
		}
	}

With

		if (!Target.bBuildEditor) return;
		PublicDependencyModuleNames.AddRange(new[]
		{
			"AnimGraph"
		});

		PrivateDependencyModuleNames.AddRange(new[]
		{
			"BlueprintGraph"
		});
	}
}

hey Sixze,
thank you for the great refactor of ALS 👍

I noticed a small issue while testing.
the camera can sometimes go through the wall.

hello i have found another bug. this appear when rotation follow or aiming
Leg Split (Video Preview)

ALS Refactored

Ragdoll Issues

• #61
• Jumping, using ragdoll in less than a second after the jump and getting back to the normal state in mid air launches you futher and can lead to mantle on higher places than usually reachable ones. (This one is more of an enhancement, but it can perhaps fix a small advantage if used in an official game.)

Collision Issues

• If you go near an object doing a linear movement towards the character, the following object will teleport this one in a glitchy and unusual way by attempting to push.
  Be sure to play with thoses bugs for a little while in order to find some details that might help fixing everything.

Wishing you an amazing day from Canada,
-Simon 👍

Hi

I just tried to add this to my project which is ue5-main branch.
I cannot compile and not sure what local fix could be.

Attached the error sample.

Let me know if I am doing something wrong.

Thanks
als-error.txt

issue:

reproduction:
set in the console "t.MaxFPS 20"

On Linux and Android sometimes you got stuck and you can't move anymore.
If you try to move the camera flies inside you, and you stay in the same position.
It happens randomly, but I noticed that it happens often if the Ai runs into you.

I can find HipsDirectionLockCurve and other curves defined in SKEL_Als, but all these curves evaluate to 0.
I am relatively new to Unreal, am I missing something?

Thanks!

After the latest fixes in the "main" branch it is not possible to pack the project, I checked on 4.26, 4.27

UATHelper: Packaging (Windows (64-bit)): ERROR: Unable to instantiate module 'UnrealEd': Unable to instantiate UnrealEd module for non-editor targets.
UATHelper: Packaging (Windows (64-bit)): (referenced via Target -> ALS.Build.cs -> AnimGraph.Build.cs -> BlueprintGraph.Build.cs -> KismetCompiler.Build.cs)
PackagingResults: Error: Unable to instantiate module 'UnrealEd': Unable to instantiate UnrealEd module for non-editor targets.
UATHelper: Packaging (Windows (64-bit)): Took 0,9541547s to run UnrealBuildTool.exe, ExitCode=6

AlsAnimNode_GameplayTagsBlend.cpp(22): [C3861] "RemovePose": Identifier not found.
AlsAnimNode_GameplayTagsBlend.cpp(29): [C3861] "AddPose": Identifier not found.

these functions are only in WITH_EDITOR builds available.

In the main branch version rolling stopped working after a fall from height, in version 4.7 it was still OK, adding a landing event on a character and calling the "try start rolling" function has no effect.

The game works fine in editor, but when I try to package it it gives me this error:

Discussed in #20

reproduction:

• play as a client
• set first-person view
• don't aim
• look down
• turn

ALS-Refactored_utility.zip

Sharing a simple utility tool that adds ALS VB and Sockets to the new Skeleton mesh.

PS: Thank you for your amazing work!!!

If I could just recommend is to also work on separating mantle and camera. Something like ALS Community has it. This would make an even much more modular ALS system.

Hey there.

I was updating ALS and I saw there was new nodes called "Blend Curves". I copied them to my own AnimBP and had no problem. But as soon as I package the game or try to play it in "Standalone" mode it crashed and said there is a violation.

If I remove those two nodes there is no problem.

Did I broke something while updating the plugin? If any information needed I can provide that.

Thanks!

I made a quick diff and noticed that Sixze version seems a little more polished, but AlexG version is mantained as well. Is there any special difference between the two? Thanks

i got some errors fixing in bp that is easly to so for the legs stretching ...
update me and ill send you an example :)

The CastChecked for the AnimationInstance (AlsCharacter.cpp line 87) gives a hard crash during PostInitializeComponents so the anim instance can never be set up for a new inherited BP. I converted to regular cast and works to let me into the new BP to set it up. Maybe log an error letting the user know what is missing rather than the checks on init?

Strong jerk when landing, for comparison I have included a video of how it looks in the ALSV4 BP version.

ALSV4 BP
https://streamable.com/qws7dm

ALS Refactored (main 20.03.2022)
https://streamable.com/v1hyxr

Can you make a soft landing like the BP version has ?

ALS Refactored (main)

Błąd C2664 "FVector UAlsMath::ClampMagnitude01(const FVector &)": nie można dokonać konwersji argumentu 1 z "UE::Math::TVector" do "const FVector &" ALS_GAS_Refactored E:\UE5\ALS_GAS_Refactored\Plugins\ALS-Refactored-main\Source\ALS\Private\AlsAnimationInstance.cpp 266
Błąd C2664 "FVector UAlsMath::ClampMagnitude01(const FVector &)": nie można dokonać konwersji argumentu 1 z "UE::Math::TVector" do "const FVector &" ALS_GAS_Refactored E:\UE5\ALS_GAS_Refactored\Plugins\ALS-Refactored-main\Source\ALS\Private\AlsAnimationInstance.cpp 272
Błąd MSB3073 Polecenie „C:\UE_5.0\Engine\Build\BatchFiles\Build.bat ALS_GAS_RefactoredEditor Win64 Development -Project="E:\UE5\ALS_GAS_Refactored\ALS_GAS_Refactored.uproject" -WaitMutex -FromMsBuild” zostało zakończone przez kod 6. ALS_GAS_Refactored C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsoft.MakeFile.Targets 44

this issue appears only on a client connected to a dedicated server, not in standalone mode.

Discussed in #34

https://drive.google.com/file/d/1Xk_nWE79a-kSQeeq2AfOxkLaV2nFx0jD/view

This is a bug that also exist in blueprint version. To reproduce the problem;

1- Put some climbable object into level
2- Scale it like (X=1.000000,Y=-1.250000,Z=1.000000)
3- Try to mantle and you will see the result.

Reicha7 in ALS Discord group describes the issue like

In regards to the #🔧known-issues of " Mantling onto non-uniformed scaled objects causes positioning issues. This is due to the difficulties of vector math when changing the relative space of a location (for mantling onto moving objects)." I offer up this as a fix. The Invert Transform that was there before was not doing what you'd expect which is why the relative transform would be scuffed for any assets that had been scaled and rotated. This gets the actual relative transform and can handle all manner of scaling, rotating, and live movement.
https://cdn.discordapp.com/attachments/674116327283228682/861990451182305300/unknown.png

Also another comment

ORIGINAL FIX BY Moontal, just put everything together to pin it
Hey guys, here's a fix for the incorrectly transformed mantle target when trying to mantle non-uniform scaled primitives. The "Compose Transforms" node does NOT logically apply transformations correctly for non-uniform scaled transforms as you would expect, and so you need to break out and apply WorldToLocal/LocalToWorld transformations independently for location/rotation.
The first change needs to be made to the "ML_ComponentWorldToLocal" macro from ALS_MacroLibrary:
https://cdn.discordapp.com/attachments/671140338521341952/744250226776473640/unknown.png
The second change needs to be made to the "ML_ComponentLocalToWorld" macro from ALS_MacroLibrary:
https://cdn.discordapp.com/attachments/671140338521341952/744250360725766204/unknown.png
Now mantling should work as it was originally intended regardless of whether your meshes are non-uniformly scaled or not, both moving and non-moving objects.

Discussed in #97

Fix:

If you hold an item then try to mantle an object, the item being held gets hidden during the mantle animation.
Upon finishing the mantle animation the item normally gets un-hidden.

Sometimes the item does not get un-hidden. After some quick testing, I believe the issue is related to packet loss.

This project is very different than ALS. So, what goes where is extremely difficult to understand without much guidelines. Like adding Overlay States and what will go where. How GetParentUnsafe and other functions interact with each other. How values are being moved around between linked layers? Would be nice various of it be documented.

When packaging the project on shipping the control rig for the feet isn't working after mantle, the feet become stretched.

Can you please tell us how to add overlay event blueprints?

I want to do two things:

1. Add children to the camera
2. Change the camera into a cine camera.

How can one get a hold of the camera component instance or edit the default settings?
It seems to be created by some magic I do not yet understand.
I've tried adding children to the Player's CameraManager, in BeginPlay but the children only appear when I enable the debug ; camera. Seems the only camera settings that are exposed for customisation is FOV. edit: Ahh I've found the rest of the camera settings, but still don't see how to attach children.
Any pointers? I've searched blueprints and C++ for Camera, Camera Manager, Camera Component, etc, but didn't find anything that looked like it actually instantiated a camera.

https://drive.google.com/file/d/1FYp3olqu34ixe6MexR6jWxPRnhF6I6O8/view

https://drive.google.com/file/d/1ZIPREPrDc9jf3odu68QqhN-O_5Q8XI_7/view

Hi,

Since tick bones is changed in code it'll interfere with using Master-Pose (which needs "Always tick and refresh bones" to work"). Maybe add some secondary bool for that?

Where to find an analogue of the original function bool AALSPlayerCameraManager::CustomCameraBehavior(float DeltaTime, FVector& Location, FRotator& Rotation, float& FOV)

from ALSPlayerCameraManager.cpp

When attempting to build the latest version of ALS-Refactored (currently d1b9062) the build fails.

Error message is as follows:

I have also attached the build log:
Build Log

Can confirm that I am having errors building 190a4be and d1b9062 but older versions are compiling without error.

This issue might be related to #42.

The character's legs go into the object, could this be eliminated?
If so, and it would mean a significant drop in performance, you could always add a "bool" checkbox on the player blueprint for those interested.

UE 4.27.2, ALS-main today's

https://streamable.com/3cowev

Discussed in #93

void FAlsAnimNode_CurvesBlend::GatherDebugData(FNodeDebugData& DebugData)
{
	DECLARE_SCOPE_HIERARCHICAL_COUNTER_ANIMNODE(GatherDebugData)
	Super::GatherDebugData(DebugData);// add at least one entry in the chain to prevent crash in BranchFlow when NodeChain is empty
	SourcePose.GatherDebugData(DebugData.BranchFlow(1.0f));
	CurvesPose.GatherDebugData(DebugData.BranchFlow(BlendAmount));
}

Would you(the author) be interested in adding a "serverside mode" toggle? By that I mean a mode in which ALS functions only for the purpose of providing third person animations for other clients, but not the owner. Out of the box it's not suitable for this because it's adding rotation to the character, which affects the first person view.

Android fix:
AlsAnimNotify_FootstepEffects.cpp

const auto SurfaceType{Hit.PhysMaterial.IsValid() ? Hit.PhysMaterial->SurfaceType : TEnumAsByte<EPhysicalSurface>(SurfaceType_Default)};

Linux fix:
only additional brackets have to be set

They appear on the ground as you'd expect but they can be seen on the player's feet too.

when you fall after a roll, the ragdoll mode is activated, then when you press jump, force is applied.

play as a client,
https://user-images.githubusercontent.com/5215249/128867950-3a36c133-17d0-4db3-86c2-90a8edeeb8b6.mp4

To prevent this popup from appearing in 4.27 and 5.0

Would it be possible to make CanMantle() function so it can disable TryStartMantlingInAir() on Tick as well? Currently it only effects Grounded Mantling and there is no way to override it from the Input.

if (CanMantle())
{
TryStartMantlingInAir();
}