Comments (5)
@fanatid I didn't mean you were wrong. Just that you're trying to fix it in the wrong place. Your way, you'll have to try to convince every single module using crypto
instead of just opening an issue on browserify and getting it resolved there for everyone.
from hasha.
I don't see how this is my responsibility? It should be up to Browserify to replace the code correctly. That's the whole point of Browserify, being able to use node modules in the browser without having to care. Seems like the correct solution would be to improve the Browserify detection/replacement logic.
from hasha.
just for you information:
$ cat c.js
module.exports = require('crypto')
$ ./node_modules/.bin/browserify c.js |wc -c
542030
$ vim c.js
...
$ cat c.js
module.exports = require('create-hash')
$ ./node_modules/.bin/browserify c.js |wc -c
162758
from hasha.
@sindresorhus I agree that browserify should do this, but it's looks super hard
from hasha.
You won't really know that until it's explored though, so I would still strongly encourage you to open an issue on Browserify to start a discussion about it.
As for an immediate solution. Dead-code elimination comes to mind. Both Webpack 2 and Rollup supports that.
from hasha.
Related Issues (20)
- Any chance for unhasha? HOT 3
- Hash multiple files? HOT 5
- Add support for doing the hashing in a worker thread HOT 13
- Typescript import broken for `fromFile`? HOT 3
- Add Salt? HOT 2
- New version (5.1.0) hasha.fromFile makes Electron application crash (unallowed memory allocation for worker threads) HOT 1
- New version (5.1.0) throws webpack errors HOT 2
- [warning] Module not found: Error: Can't resolve 'worker_threads' HOT 1
- Image hash length HOT 2
- `fromFile` broken on Node 14 HOT 8
- hasha.fromFile throws error with message "The V8 platform used by this instance of Node does not support creating Workers" when updated to version 5.2.0 HOT 2
- Browser support HOT 2
- Why does `hasha.fromFile` returns `Promise<string | null>` instead of `Promise<string>`?
- What would be a recommended concurrency for hashing multiple files asynchronously? HOT 4
- Fatal error with Promise.all() HOT 3
- Support for AbortSignal
- convert to esm HOT 1
- It takes a long time when hasha from a large file, provider a bloom filter to speed up the hasha? HOT 6
- add support to calculate hash of first or last nkb of the file HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hasha.