Comments (13)
I like it. It's usually not super expensive, but a 1gb file shasum takes ~4s on my macbook 2015 2.8 GHz Intel Core i7
I would actually prefer a C++ binding (that I'd guess would be faster, since in OS X for example, running openssl sha1 :file
takes 4x less time than the crypto approach in node.
from hasha.
I would actually prefer a C++ binding (that I'd guess would be faster, since in OS X for example, running openssl sha1 :file takes 4x less time than the crypto approach in node.
Not interested in doing native bindings. That comes it its own set of horribleness.
from hasha.
Related to sindresorhus/crypto-hash#7
// @stroncium
from hasha.
Can easily be done for file hashes(and will work perfectly).
For strings/buffers, I don't see a way to go further than is done in sindresorhus/crypto-hash#7 so I'd just use it.
As far as my understanding goes, we will have to always clone(not transfer) bytes for arbitrary streams, and as chunks are expected to be pretty small, the chance clone+send task overhead will be be bigger than just hashing in place is quite high. Needs some benchmarks, but I'm pretty sure it's not viable.
Speaking of performance comparison with openssl, it sounds strange to me, as node is using openssl underneath. If such issue actually exists it could use some serious debugging on libuv/nodejs/app level.
from hasha.
@IssueHunt has funded $80.00 to this issue.
- Submit pull request via IssueHunt to receive this reward.
- Want to contribute? Chip in to this issue via IssueHunt.
- Checkout the IssueHunt Issue Explorer to see more funded issues.
- Need help from developers? Add your repository on IssueHunt to raise funds.
from hasha.
On it.
@sindresorhus Should I add crypto-hash
as a dependency or duplicate code?
from hasha.
Does crypto-hash
expose enough functionality? Would be good to share code if possible, yes.
from hasha.
@sindresorhus Need to check it, but should be enough.
from hasha.
@sindresorhus Never mind. I didn't notice there was no async version of string
/buffer
hashing in hasha
. Without it there is almost no code intersection with crypto-hash
.
from hasha.
I didn't notice there was no async version of string/buffer hashing in hasha.
Sorry if the issue was not clear enough on this, but the intention is to add it now that it's possible.
from hasha.
@sindresorhus Well, then there are some questions:
- Should it be a breaking change(to promise returning function) or additional method?
crypto-hash
doesn't supportmd5
, should we add it just for nodejs? (And while at it, should we add a method you pass algorithm string to for consistency?)- If not, should we use
crypto-hash
at all? Most code will need to be duplicated here to implementmd5
anyhow.
from hasha.
Should it be a breaking change(to promise returning function) or additional method?
Additional method.
crypto-hash doesn't support md5, should we add it just for nodejs? (And while at it, should we add a method you pass algorithm string to for consistency?)
Nah
If not, should we use crypto-hash at all? Most code will need to be duplicated here to implement md5 anyhow.
Probably not worth using crypto-hash
at all then.
from hasha.
@sindresorhus has rewarded $72.00 to @stroncium. See it on IssueHunt
- 💰 Total deposit: $80.00
- 🎉 Repository reward(0%): $0.00
- 🔧 Service fee(10%): $8.00
from hasha.
Related Issues (20)
- add support to calculate hash of first or last nkb of the file HOT 3
- create-hash instead crypto.createHash HOT 5
- Any chance for unhasha? HOT 3
- Hash multiple files? HOT 5
- Typescript import broken for `fromFile`? HOT 3
- Add Salt? HOT 2
- New version (5.1.0) hasha.fromFile makes Electron application crash (unallowed memory allocation for worker threads) HOT 1
- New version (5.1.0) throws webpack errors HOT 2
- [warning] Module not found: Error: Can't resolve 'worker_threads' HOT 1
- Image hash length HOT 2
- `fromFile` broken on Node 14 HOT 8
- hasha.fromFile throws error with message "The V8 platform used by this instance of Node does not support creating Workers" when updated to version 5.2.0 HOT 2
- Browser support HOT 2
- Why does `hasha.fromFile` returns `Promise<string | null>` instead of `Promise<string>`?
- What would be a recommended concurrency for hashing multiple files asynchronously? HOT 4
- Fatal error with Promise.all() HOT 3
- Support for AbortSignal
- convert to esm HOT 1
- It takes a long time when hasha from a large file, provider a bloom filter to speed up the hasha? HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hasha.