Code Monkey home page Code Monkey logo

Comments (6)

sindresorhus avatar sindresorhus commented on May 9, 2024 1

We should enforce only strings.

from emittery.

dinoboff avatar dinoboff commented on May 9, 2024 1

To avoid name collision if you expect an emitter class to be extended and for event you don't especially need to expose.

For those cases, you can add namespace to the event name, or not expose the emitter, but if it doesn't complicate emitteryinternals, supporting Symbol like EventEmitter would be useful.

from emittery.

novemberborn avatar novemberborn commented on May 9, 2024

This will need to be resolved for #1.

from emittery.

dinoboff avatar dinoboff commented on May 9, 2024

Why not support Symbol?

For #1, it just needs to support event key as an array. Even if the list of event key is provided as a string (e.g.: on('start:*') or on('start:foo start:bar')), it's just a matter of filtering symbol event keys.

from emittery.

sindresorhus avatar sindresorhus commented on May 9, 2024

Why do you want support for Symbols? How would you use it?

from emittery.

sindresorhus avatar sindresorhus commented on May 9, 2024

@dinoboff That's a good use-case. I hadn't thought of that.

from emittery.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.