Comments (4)
Yup. Or we can have a special function that emits the meta events on a given emitter instance. Something like this.
async function emitMetaEvent(emitter, event, data) {
metaEventsAllowed = true
await emitter.emit(event, data)
metaEventsAllowed = false
}
The only benefit of this function over the callback approach is, we will not end up creating too many anonymous functions.
if (!isMetaEvent(eventName)) {
emitMetaEvent(this, listenerAdded, {eventName, listener})
}
from emittery.
// @lukehorvat
from emittery.
Ouch. Sorry for the oversight.
I have one idea. We could have a private withMetaEventsAllowed
function which would allow Emittery to run some internal code in a "privileged" way (like running sudo
or whatever). All of the internal calls to emit
could be wrapped in this function.
let metaEventsAllowed = false;
function withMetaEventsAllowed(callback) {
metaEventsAllowed = true;
callback();
metaEventsAllowed = false;
}
So, for example, this code:
Lines 261 to 263 in f61b87d
Would become this:
if (!isMetaEvent(eventName)) {
withMetaEventsAllowed(() => {
this.emit(listenerAdded, {eventName, listener});
});
}
This would eliminate the need for emit
to have a third param and subclasses could do whatever they want. Of course, the downside is that it introduces some global state (but since it wouldn't be exposed to userland maybe it's not so bad?).
Just a rough idea I had; could probably be improved. But if it sounds fine to you then I'll go ahead and make a PR.
from emittery.
Or we can have a special function that emits the meta events on a given emitter instance. Something like this.
👍 Sounds good
from emittery.
Related Issues (20)
- Possible memory-leak in bindMethods
- ReferenceError: exports is not defined in ES module scope HOT 1
- `globalThis.process` references DOM elements with a `#process` ID and crashes app
- [Question] Is it safe to override `emit`? HOT 1
- `yarn test` fails
- Pure ems bundle prevents emittery usage in libraries/frameworks HOT 2
- Wrong listener count for Symbol event names
- Question: Does this works across tabs? HOT 1
- Support AbortController
- v0.9.0 throws a reference error on browser bundles HOT 2
- Uncaught TypeError: Cannot read property 'has' of undefined HOT 4
- Typescript error while trying to listen to multiple events HOT 1
- Arbitrary listener return type (Typescript) HOT 1
- `emit('eventName')` returns as `emit(undefined)` HOT 2
- Fix type compatibility with `p-event`
- No way to prepend listeners or run listeners in reversed order in emit
- `export = Emittery` might not be correct? HOT 1
- Enabling debug can cause circular reference error HOT 3
- No way to unsubscribe from `once` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from emittery.