simplifynet / simplify.web Goto Github PK

Example

app.UseSimplifyWeb(x =>
    x.WithEnvironment<CustomEnvironmentType>();
);

Add an extension method which can do:

BootstrapperFactory.CreateBootstrapper().Register();

This is useful for UseSimplifyWebWithoutRegistrations situations.

Using mono-service to start a web service, under Debian, led me to modify the new Modules.Environment invocation,

as long, in this case, AppDomain.CurrentDomain.BaseDirectory points a system directory (/usr/lib/mono/4.5), and this property is non-modifable.

So this value cannot be used as the site path.
I prefered to use the current directory instead.

To Reproduce
Steps to reproduce the behavior:

1. Build a project of your own, embeded in a Windows service, displaying some template result
2. Use mono-service to lauch the service : mono-service -d:. -l:your.lock your.exe
3. browse your page : the template is not found, it is searched from /usr/lib/mono/4.5

Expected behavior
The templates are found, because the site path is the current working dirrectory

Desktop:

• OS: Debian Bullseye

Tracking issue for:

• https://github.com/SimplifyNet/Simplify.Web/security/code-scanning/2

https://docs.microsoft.com/en-us/aspnet/core/migration/22-to-30?view=aspnetcore-3.0&tabs=visual-studio

Tracking issue for:

• https://github.com/SimplifyNet/Simplify.Web/security/code-scanning/1

It adds more possibilities for custom controllers handling.

Read permissions is enough for static files.
File shared also should be respected for concurrent requests.

using var stream = File.Open(relativeFilePath, FileMode.Open, FileAccess.Read, FileShare.Read);

Related: dotnet/aspnetcore#7644

System.ArgumentNullException : Value cannot be null. (Parameter 'language') at Simplify.Web.Modules.Data.FileReader.GetFilePath(String fileName, String language)

Steps to reproduce the behavior:
Change target framework of a project using Simplify.Web to .NET 6 and launch it in sdk:6.0-alpine docker container

Expected behavior
No Exceptions

Desktop (please complete the following information):

• OS: sdk:6.0-alpine docker container

Additional context
More details:
https://github.com/the-benchmarker/web-frameworks/runs/4144664560?check_suite_focus=true
the-benchmarker/web-frameworks#4815

This code redirects to previously loaded static file path instead of previous controller executed:

return new Redirect(RedirectionType.PreviousPage);

Goal:
Validation attribute should have ErrorMessage property to add custom message.

Example:

[Required(ErrorMessage = "Destination is required")]
[Regex(@"[A-Z]{3}", ErrorMessage = "Destination is invalid")]
public string Destination { get; set; }

with check of Context.Context.User != null && Context.Context.User.Identity.IsAuthenticated

For example:

Now

ControllerSecurity Security { get; }

Should be

ControllerSecurity? Security { get; }

Cannot parse query string parameters from request with camelCase, lowercase, etc... to C# object.

Please add verification to query string parsing regardless parameter case.

public static class ListToModelParser
{

	 // some code

	private static string GetBindPropertyName(PropertyInfo propertyInfo)
	{
		var attributes = propertyInfo.GetCustomAttributes(typeof(BindPropertyAttribute), false);

		// verify parameter case
		return attributes.Length == 0 ? null : ((BindPropertyAttribute)attributes[0]).FieldName;
	}
}

Please, add feature with adding custom attribute for viewmodel with custom validation logic.

CustomValidationAttribute should have:

• bool IsValid method with Value parameter (type object)
• property string ErrorMessage to response custom error

public class FlightDateValidationAttribute : ValidationAttribute
    {
        public new string ErrorMessage = "Flight date is invalid";
        // or
        public override string Message(){
                  return "Flight date is invalid"; 
        }
        // up to you
        public override bool IsValid(object value)
        {
            var date = value as string;
            return DateTime.TryParse(date, out var flightDate) && flightDate.Date >= DateTime.UtcNow.Date;
        }
    }

In ViewModel:

[FlightDateValidation]
public DateTime FlightDate { get; set; }

or

[FlightDateValidation(ErrorMessage = "Flight date is invalid")] // if message is custom
public DateTime FlightDate { get; set; }

Required, regex attributes don't invoke in child properties. Ex: If you have User viewmodel with Contacts properties of Contact class, it doesn't work inside Contact properties.

Solution is to make recursion invoke inside viewmodel properties which has this attributes

public class User
{
        [Required]
        public Contact Contact {get;set;}
}

public class Contact
{
        [Required]
        [Regex(@"^[0-9]{9}$")]
        public string Number {get;set;}
}

PreviousPageUrl cookie changes to resource file instead of page in case of file was not found. Which causes bad redirection with RedirectionType.PreviousPage.

Currently we need to use "!" symbols in any page controllers:

public override ControllerResponse Invoke()
{
        ...
	return null!;
}

Properties validation don't invoke in base class properties.

public class MyChildObj: MyObj
{ 
}

public class MyObj
{
        [Required]
        public string Number {get; set;}
}

Cookie “PreviousPageUrl” will be soon rejected because it has the “SameSite” attribute set to “None” or an invalid value, without the “secure” attribute. To know more about the “SameSite“ attribute,
read https://developer.mozilla.org/docs/Web/HTTP/Headers/Set-Cookie/SameSite