simphony / simphony-framework Goto Github PK

(simphony)enthought@simphony-base:~/simphony-framework$ make kratos
rm -Rf src/kratos
mkdir -p src/kratos
wget https://web.cimne.upc.edu/users/croig/data/kratos-simphony.tgz -O src/kratos/kratos.tgz
--2015-08-06 10:51:22--  https://web.cimne.upc.edu/users/croig/data/kratos-simphony.tgz
Resolving web.cimne.upc.edu (web.cimne.upc.edu)... 147.83.143.54
Connecting to web.cimne.upc.edu (web.cimne.upc.edu)|147.83.143.54|:443... connected.
HTTP request sent, awaiting response... 403 Forbidden
2015-08-06 10:51:22 ERROR 403: Forbidden.
make: *** [kratos] Error 8

This bug is critical since it does not allow the continues integration to run or anyother integration work to take place without disabling kratos from the framework

Most of the software that requires the framework needs to compile it during testing. This is very costly, despite all caching strategies we implemented, the framework is simply too big. We need to build the framework and package it so that it can be installed by simple downloading

I have observed that throughout the Simphony project dependencies are defined implicitly. The use of >= sign instead of == and not putting the full output of pip freeze in requirements.txt file would be problematic in future.

I suggest to define direct and indirect dependencies in requirements.txt explicitly. This will let pip to install the exact versions that we are sure the application works fine with them. Moreover, in case of reusable components we can use a dependency range inside setup.py files. This will allow the component to support minor dependency upgrades while major updates would need exclusive attention of developers and an update in our side.

Since this project is like a toplevel project, I register this issue here.

add missing "make":

sudo make base
sudo apt-openfoam
sudo apt-simphony
sudo apt-lammps
sudo apt-mayavi

We shuold use a simple txt file to control which packages are going to be installed by the automation scripts.

Currently it is a little fragile to install the framework since we depend on old version of pip and virtualenv that are available with Ubuntu 12.04 (even 14.04 does not have the latest)

It is a good idea to have a Dockerfile to install SimPhoNy on a number of operating systems.

not sure if openfoam version222 is required for some reason but it leads to install fail
Makefile line 104
apt-get install -y --force-yes openfoam222
can be replaced by
apt-get install -y --force-yes openfoam30
for instance - I don't know if it will cause problems later but at least install works.

using sudo make apt-simphony hints that one is installing simphony, though we are only installing some dependencies. Should could be renamed to something like:

sudo make apt-simphony-deps

to avoid confusion.

same is true for sudo make-lammps and make-mayavi

While the main development effort is taking place in Ubuntu. Some of the simphony plugins can be used on Windows (e.g simphony-common and simphony-mayavi). So it is would be nice to have a batch file that will simplify installing a part of the simphony-framework that is windows friendly

Currently, we say The SymPhoNy framework is developed and tested on Ubuntu 12.04 LTS

Maybe we need to be more specific on what the supported and tested platform is. As there is at least one known issue when using the framework on 32-bit Ubuntu (see simphony/simphony-jyulb#26)

The following components of the simphony framework are not tested

• simphony-mayavi
• simphony-common
• aviz

The JYU-LB repo has been updated, however the new version is not compatible with the simphony-jyu-lib package installed by the simphony framework. We should not follow the master repo of JYU-LB but work of stable tags to make sure that we always install the right versions

we currently append the apt source with
https://github.com/simphony/simphony-framework/blob/master/install_apt_requirements.sh#L4

This is not very elegant and can cause duplicate additions it the script is run multiple times.

If some of the engines are not installed, the test does not report a failure

The use of 'precise' in line 92 of the makefile predictably gave trouble on a non-precise ubuntu14.04 system, replacing it with 'trusty' took care of it.
So to do this automatically one can find the version info in /etc/lsb-release, the following extracts the 'trusty' or 'precise' part
grep -e "DISTRIB_CODENAME" /etc/lsb-release | sed s/DISTRIB_CODENAME=//

I attempted to put this into the Makefile but the rules seem different than shell scripts - so if there is a Makefile enthusiast perhaps you can take the output of the above command and put it into a variable.
the attempt I made was
UBUNTU_VERSION=grep -e "DISTRIB_CODENAME" /etc/lsb-release | sed s/DISTRIB_CODENAME=//
but this simply puts the string into the variable and not the output of the string run as command.

From https://travis-ci.org/simphony/simphony-framework/builds/69049405:

haas simkratos -v

----------------------------------------------------------------------

Ran 0 tests in 0.000s

Since some collaborators are using RedHat, it would be nice if we have also a makefile that would handle installing on a CentOS machine

Installing 4.5.1 using pip on an empty enviroment without traists, traitsui and other depedencies will fail with the following error

pip install enable-4.5.1.tar.gz --user
Processing ./enable-4.5.1.tar.gz
    Complete output from command python setup.py egg_info:
    I was called
    Traceback (most recent call last):
      File "<string>", line 20, in <module>
      File "/tmp/pip-l_EevW-build/setup.py", line 194, in <module>
        write_version_py(filename='enable/_version.py')
      File "/tmp/pip-l_EevW-build/setup.py", line 100, in write_version_py
        raise ImportError("Unable to import git_revision. Try removing "
    ImportError: Unable to import git_revision. Try removing kiva/_version.py and the build directory before building.

    ----------------------------------------
    Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-l_EevW-build

we probably need to distribute our own activate and deactivate scripts

The fix_pip target commands can be executed without using sudo but --user. We should investigate this.

Installing lammps is too slow due to cloning a very large repo. We should find ways to speed it up

it would be very helpful to change the default simphony virtualenv directory (currently $HOME/simphony) to reflec the version and the fact it is a virtual env:

simphony-"release tag"-python-env

will also allow installing multiple frameworks at the same time.

The Readme does not mention that these can be set from the command line, so updating the Readme should be fine.