Code Monkey home page Code Monkey logo

rickandmorty's Introduction

rickandmorty's People

Contributors

renovate[bot] avatar simonlebras avatar

Watchers

 avatar  avatar  avatar

rickandmorty's Issues

inject default dispatcher

https://api.github.com/simonlebras/rickandmorty/blob/491f5b0f10512e103c2654f9d1760798245d04ff/core/strictmode/src/main/kotlin/app/rickandmorty/strictmode/StrictModeInitializer.kt#L13


package app.rickandmorty.strictmode

import android.content.Context
import android.os.Build
import android.os.StrictMode
import android.os.StrictMode.ThreadPolicy
import android.os.StrictMode.VmPolicy
import android.os.strictmode.UntaggedSocketViolation
import androidx.startup.Initializer
import java.util.concurrent.Executors

internal class StrictModeInitializer : Initializer<Unit> {
    // TODO inject default dispatcher
    private val penaltyListenerExecutor by lazy(LazyThreadSafetyMode.NONE) {
        Executors.newSingleThreadExecutor()
    }

    override fun create(context: Context) {
        val threadPolicy = ThreadPolicy.Builder()
            .detectAll()
            .apply {
                if (Build.VERSION.SDK_INT < 28) {
                    penaltyLog()
                } else {
                    penaltyListener(penaltyListenerExecutor) {
                        // TODO log violations
                    }
                }
            }
            .build()
        StrictMode.setThreadPolicy(threadPolicy)

        val vmPolicy = VmPolicy.Builder()
            .detectAll()
            .apply {
                if (Build.VERSION.SDK_INT < 28) {
                    penaltyLog()
                } else {
                    penaltyListener(penaltyListenerExecutor) { violation ->
                        when (violation) {
                            is UntaggedSocketViolation -> {
                                // Firebase and OkHttp don't tag sockets
                                return@penaltyListener
                            }
                        }

                        // TODO log violations
                    }
                }
            }
            .build()
        StrictMode.setVmPolicy(vmPolicy)
    }

    override fun dependencies(): List<Class<out Initializer<*>>> = emptyList()
}

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Repository problems

These problems occurred while renovating this repository. View logs.

  • WARN: Package lookup failures

Warning

Renovate failed to look up the following dependencies: Failed to look up maven package com.google.android.gms.oss-licenses-plugin:com.google.android.gms.oss-licenses-plugin.gradle.plugin.

Files affected: gradle/libs.versions.toml


Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Ignored or Blocked

These are blocked by an existing closed PR and will not be recreated unless you click a checkbox below.

Detected dependencies

github-actions
.github/workflows/auto-update.yml
  • tibdex/auto-update v2
.github/workflows/build.yml
  • actions/checkout v4
  • actionsdesk/lfs-warning v3.3
  • actions/setup-java v4
  • gradle/actions v4
  • actions/upload-artifact v4
  • actions/upload-artifact v4
  • actions/upload-artifact v4
  • actions/checkout v4
  • actions/setup-java v4
  • gradle/actions v4
  • actions/cache v4
  • actions/upload-artifact v4
  • actions/upload-artifact v4
.github/workflows/clear-caches.yml
  • easimon/wipe-cache v2
.github/workflows/todo.yml
  • actions/checkout v4
  • alstr/todo-to-issue-action v4
gradle
gradle.properties
settings.gradle.kts
  • com.gradle.develocity 3.18.1
  • com.gradle.common-custom-user-data-gradle-plugin 2.0.2
build.gradle.kts
app/build.gradle.kts
baseline-profile/build.gradle.kts
build-logic/settings.gradle.kts
build-logic/build.gradle.kts
core/base/build.gradle.kts
core/coil/build.gradle.kts
core/coroutines/build.gradle.kts
core/design-system/build.gradle.kts
core/hilt-test/build.gradle.kts
core/l10n/build.gradle.kts
core/logging/build.gradle.kts
core/metrics/build.gradle.kts
core/okhttp/build.gradle.kts
core/resource-state/build.gradle.kts
core/startup/build.gradle.kts
core/strict-mode/build.gradle.kts
core/ui/build.gradle.kts
data/character/build.gradle.kts
data/database/build.gradle.kts
data/episode/build.gradle.kts
data/graphql-client/build.gradle.kts
data/graphql-schema/build.gradle.kts
data/locale/build.gradle.kts
data/locale-proto/build.gradle.kts
data/location/build.gradle.kts
data/model/build.gradle.kts
data/paging/build.gradle.kts
data/theme/build.gradle.kts
data/theme-proto/build.gradle.kts
features/characters/build.gradle.kts
features/episodes/build.gradle.kts
features/locations/build.gradle.kts
features/settings/build.gradle.kts
gradle/libs.versions.toml
  • com.dropbox.affectedmoduledetector:affectedmoduledetector 0.3.1
  • com.android.compose.screenshot:com.android.compose.screenshot.gradle.plugin 0.0.1-alpha06
  • com.android.tools:desugar_jdk_libs 2.1.2
  • com.android.tools.build:gradle 8.7.0-beta01
  • com.android.security.lint:lint 1.0.1
  • com.android.tools:common 31.7.0-beta01
  • androidx.activity:activity 1.10.0-alpha02
  • androidx.activity:activity-compose 1.10.0-alpha02
  • androidx.appcompat:appcompat 1.7.0
  • androidx.benchmark:benchmark-macro-junit4 1.3.0
  • androidx.compose:compose-bom 2024.09.00-alpha
  • androidx.compose.runtime:runtime-tracing 1.0.0-beta01
  • androidx.core:core-ktx 1.15.0-alpha02
  • androidx.core:core-splashscreen 1.2.0-alpha02
  • androidx.datastore:datastore 1.1.1
  • androidx.hilt:hilt-navigation-compose 1.2.0
  • androidx.lifecycle:lifecycle-runtime-compose 2.9.0-alpha02
  • androidx.lifecycle:lifecycle-runtime-testing 2.9.0-alpha02
  • androidx.lifecycle:lifecycle-viewmodel-compose 2.9.0-alpha02
  • androidx.lint:lint-gradle 1.0.0-alpha02
  • androidx.metrics:metrics-performance 1.0.0-beta01
  • androidx.navigation:navigation-compose 2.8.0
  • androidx.navigation:navigation-testing 2.8.0
  • androidx.paging:paging-common 3.3.2
  • androidx.paging:paging-compose 3.3.2
  • androidx.paging:paging-runtime 3.3.2
  • androidx.profileinstaller:profileinstaller 1.4.0-rc01
  • androidx.room:room-compiler 2.7.0-alpha07
  • androidx.room:room-paging 2.7.0-alpha07
  • androidx.room:room-gradle-plugin 2.7.0-alpha07
  • androidx.room:room-runtime 2.7.0-alpha07
  • androidx.room:room-testing 2.7.0-alpha07
  • androidx.test:core 1.6.1
  • androidx.test.espresso:espresso-core 3.6.1
  • androidx.test.ext:junit-ktx 1.2.1
  • androidx.test:rules 1.6.1
  • androidx.test:runner 1.6.2
  • androidx.test.ext:truth 1.6.0
  • androidx.test.uiautomator:uiautomator 2.3.0
  • androidx.tracing:tracing-ktx 1.3.0-alpha02
  • androidx.window:window 1.4.0-alpha02
  • com.apollographql.adapters:apollo-adapters-kotlinx-datetime 0.0.4
  • com.apollographql.apollo:apollo-api 4.0.0
  • com.apollographql.apollo:apollo-gradle-plugin-external 4.0.0
  • com.apollographql.apollo:apollo-runtime 4.0.0
  • se.ansman.dagger.auto:compiler 1.3.0
  • se.ansman.dagger.auto:core 1.3.0
  • se.ansman.dagger.auto:androidx-room 1.3.0
  • io.coil-kt.coil3:coil 3.0.0-alpha10
  • io.coil-kt.coil3:coil-compose 3.0.0-alpha10
  • io.coil-kt.coil3:coil-compose-core 3.0.0-alpha10
  • io.coil-kt.coil3:coil-core 3.0.0-alpha10
  • io.coil-kt.coil3:coil-network-okhttp 3.0.0-alpha10
  • com.autonomousapps:dependency-analysis-gradle-plugin 2.0.1
  • com.google.firebase:firebase-bom 33.2.0
  • com.osacky.doctor:doctor-plugin 0.10.0
  • com.google.dagger:hilt-android 2.52
  • com.google.dagger:hilt-android-compiler 2.52
  • com.google.dagger:hilt-android-testing 2.52
  • com.google.dagger:hilt-core 2.52
  • junit:junit 4.13.2
  • org.jetbrains.kotlin:compose-compiler-gradle-plugin 2.0.20
  • org.jetbrains.kotlin:kotlin-gradle-plugin 2.0.20
  • org.jetbrains.kotlinx:atomicfu 0.25.0
  • org.jetbrains.kotlinx:kotlinx-collections-immutable 0.3.8
  • org.jetbrains.kotlinx:kotlinx-coroutines-android 1.9.0-RC.2
  • org.jetbrains.kotlinx:kotlinx-coroutines-core 1.9.0-RC.2
  • org.jetbrains.kotlinx:kotlinx-coroutines-test 1.9.0-RC.2
  • org.jetbrains.kotlinx:kotlinx-datetime 0.6.1
  • org.jetbrains.kotlinx:kotlinx-serialization-core 1.7.2
  • org.jetbrains.kotlinx:kotlinx-serialization-json 1.7.2
  • com.squareup.leakcanary:leakcanary-android-startup 2.14
  • com.squareup.leakcanary:plumber-android-startup 2.14
  • com.squareup.okhttp3:okhttp 5.0.0-alpha.14
  • com.squareup.okhttp3:logging-interceptor 5.0.0-alpha.14
  • com.google.android.gms:play-services-oss-licenses 17.1.0
  • com.slack.lint.compose:compose-lint-checks 1.3.1
  • com.diffplug.spotless:spotless-plugin-gradle 7.0.0.BETA2
  • org.mobilenativefoundation.store:store5 5.0.0
  • com.google.testparameterinjector:test-parameter-injector 1.17
  • com.jakewharton.timber:timber 5.0.1
  • com.google.truth:truth 1.4.4
  • app.cash.turbine:turbine 1.1.0
  • com.squareup.wire:wire-gradle-plugin 5.0.0
  • com.squareup.wire:wire-runtime 5.0.0
  • com.dropbox.affectedmoduledetector 0.3.1
  • com.android.application 8.7.0-beta01
  • com.android.compose.screenshot 0.0.1-alpha06
  • com.android.library 8.7.0-beta01
  • com.android.lint 8.7.0-beta01
  • com.android.test 8.7.0-beta01
  • androidx.baselineprofile 1.3.0
  • androidx.room 2.7.0-alpha07
  • com.apollographql.apollo 4.0.0
  • org.gradle.android.cache-fix 3.0.1
  • com.autonomousapps.dependency-analysis 2.0.1
  • com.starter.easylauncher 6.4.0
  • com.google.firebase.crashlytics 3.0.2
  • com.google.firebase.firebase-perf 1.4.2
  • com.google.gms.google-services 4.4.2
  • com.osacky.doctor 0.10.0
  • com.google.dagger.hilt.android 2.52
  • org.jetbrains.kotlin.android 2.0.20
  • org.jetbrains.kotlin.plugin.compose 2.0.20
  • org.jetbrains.kotlin.jvm 2.0.20
  • org.jetbrains.kotlin.plugin.serialization 2.0.20
  • com.google.devtools.ksp 2.0.20-1.0.25
  • com.jraska.module.graph.assertion 2.7.1
  • com.google.android.gms.oss-licenses-plugin 0.10.6
  • com.squareup.sort-dependencies 0.8
  • com.diffplug.spotless 7.0.0.BETA2
  • com.squareup.wire 5.0.0
gradle-wrapper
gradle/wrapper/gradle-wrapper.properties
  • gradle 8.10.1

  • Check this box to trigger a request for Renovate to run again on this repository

log jank

https://api.github.com/simonlebras/rickandmorty/blob/57b2e19bafdbc459ec6cb76fbc637b9abd5437f7/core/jankstats/src/main/kotlin/app/rickandmorty/jankstats/JankStatsModule.kt#L17


package app.rickandmorty.jankstats

import android.app.Activity
import androidx.metrics.performance.JankStats
import dagger.Module
import dagger.Provides
import dagger.hilt.InstallIn
import dagger.hilt.android.components.ActivityComponent

@Module
@InstallIn(ActivityComponent::class)
internal object JankStatsModule {
    @Provides
    fun providesJankStats(activity: Activity): JankStats {
        val frameListener = JankStats.OnFrameListener { frameData ->
            if (frameData.isJank) {
                // TODO log jank
            }
        }
        return JankStats.createAndTrack(activity.window, frameListener)
    }
}

log violations

https://api.github.com/simonlebras/rickandmorty/blob/491f5b0f10512e103c2654f9d1760798245d04ff/core/strictmode/src/main/kotlin/app/rickandmorty/strictmode/StrictModeInitializer.kt#L26


package app.rickandmorty.strictmode

import android.content.Context
import android.os.Build
import android.os.StrictMode
import android.os.StrictMode.ThreadPolicy
import android.os.StrictMode.VmPolicy
import android.os.strictmode.UntaggedSocketViolation
import androidx.startup.Initializer
import java.util.concurrent.Executors

internal class StrictModeInitializer : Initializer<Unit> {
    // TODO inject default dispatcher
    private val penaltyListenerExecutor by lazy(LazyThreadSafetyMode.NONE) {
        Executors.newSingleThreadExecutor()
    }

    override fun create(context: Context) {
        val threadPolicy = ThreadPolicy.Builder()
            .detectAll()
            .apply {
                if (Build.VERSION.SDK_INT < 28) {
                    penaltyLog()
                } else {
                    penaltyListener(penaltyListenerExecutor) {
                        // TODO log violations
                    }
                }
            }
            .build()
        StrictMode.setThreadPolicy(threadPolicy)

        val vmPolicy = VmPolicy.Builder()
            .detectAll()
            .apply {
                if (Build.VERSION.SDK_INT < 28) {
                    penaltyLog()
                } else {
                    penaltyListener(penaltyListenerExecutor) { violation ->
                        when (violation) {
                            is UntaggedSocketViolation -> {
                                // Firebase and OkHttp don't tag sockets
                                return@penaltyListener
                            }
                        }

                        // TODO log violations
                    }
                }
            }
            .build()
        StrictMode.setVmPolicy(vmPolicy)
    }

    override fun dependencies(): List<Class<out Initializer<*>>> = emptyList()
}

implement loading/error states


package app.rickandmorty.feature.characters.list

import androidx.activity.compose.ReportDrawnWhen
import androidx.compose.foundation.layout.consumeWindowInsets
import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.material3.CenterAlignedTopAppBar
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.Icon
import androidx.compose.material3.IconButton
import androidx.compose.material3.ListItem
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp
import androidx.hilt.navigation.compose.hiltViewModel
import androidx.paging.compose.LazyPagingItems
import androidx.paging.compose.collectAsLazyPagingItems
import androidx.paging.compose.itemKey
import app.rickandmorty.core.designsystem.icon.RamIcons
import app.rickandmorty.core.ui.resources.R as UiR
import app.rickandmorty.data.model.Character
import app.rickandmorty.feature.characters.R
import coil3.compose.AsyncImage

@Composable
internal fun CharacterListScreen(
    onNavigateToSettings: () -> Unit,
    viewModel: CharacterListViewModel = hiltViewModel(),
) {
    val characters = viewModel.characters.collectAsLazyPagingItems()

    ReportDrawnWhen {
        characters.itemCount > 0 ||
            characters.loadState.refresh.endOfPaginationReached
    }

    CharacterListScreen(
        characters = characters,
        onNavigateToSettings = onNavigateToSettings,
    )
}

// TODO implement loading/error states
@Composable
private fun CharacterListScreen(
    characters: LazyPagingItems<Character>,
    onNavigateToSettings: () -> Unit,
) {
    Scaffold(
        topBar = {
            CharacterListScreenAppBar(

log violations

https://api.github.com/simonlebras/rickandmorty/blob/491f5b0f10512e103c2654f9d1760798245d04ff/core/strictmode/src/main/kotlin/app/rickandmorty/strictmode/StrictModeInitializer.kt#L26


package app.rickandmorty.strictmode

import android.content.Context
import android.os.Build
import android.os.StrictMode
import android.os.StrictMode.ThreadPolicy
import android.os.StrictMode.VmPolicy
import android.os.strictmode.UntaggedSocketViolation
import androidx.startup.Initializer
import java.util.concurrent.Executors

internal class StrictModeInitializer : Initializer<Unit> {
    // TODO inject default dispatcher
    private val penaltyListenerExecutor by lazy(LazyThreadSafetyMode.NONE) {
        Executors.newSingleThreadExecutor()
    }

    override fun create(context: Context) {
        val threadPolicy = ThreadPolicy.Builder()
            .detectAll()
            .apply {
                if (Build.VERSION.SDK_INT < 28) {
                    penaltyLog()
                } else {
                    penaltyListener(penaltyListenerExecutor) {
                        // TODO log violations
                    }
                }
            }
            .build()
        StrictMode.setThreadPolicy(threadPolicy)

        val vmPolicy = VmPolicy.Builder()
            .detectAll()
            .apply {
                if (Build.VERSION.SDK_INT < 28) {
                    penaltyLog()
                } else {
                    penaltyListener(penaltyListenerExecutor) { violation ->
                        when (violation) {
                            is UntaggedSocketViolation -> {
                                // Firebase and OkHttp don't tag sockets
                                return@penaltyListener
                            }
                        }

                        // TODO log violations
                    }
                }
            }
            .build()
        StrictMode.setVmPolicy(vmPolicy)
    }

    override fun dependencies(): List<Class<out Initializer<*>>> = emptyList()
}

localize errors


    )
}

// Todo localize errors
@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun CharacterListScreen(
    characters: LazyPagingItems<Character>,
    onNavigateToSettings: () -> Unit,
) {
    val snackbarHostState = remember { SnackbarHostState() }

    val loadState = characters.loadState

    loadState.refresh.errorOrNull?.let { error ->
        LaunchedEffect(snackbarHostState, error) {
            snackbarHostState.showSnackbar("Error")
        }
    }
    loadState.append.errorOrNull?.let { error ->
        LaunchedEffect(snackbarHostState, error) {
            snackbarHostState.showSnackbar("Error")
        }
    }

    val scrollBehavior = TopAppBarDefaults.enterAlwaysScrollBehavior()

    HazeScaffold(
        topBar = {
            CharacterListScreenAppBar(
                onNavigateToSettings = onNavigateToSettings,
                scrollBehavior = scrollBehavior,
            )
        },
        snackbarHost = { SnackbarHost(hostState = snackbarHostState) },
        blurTopBar = true,
    ) { contentPadding ->
        PullToRefresh(
            isRefreshing = loadState.refresh.isLoading,
            onRefresh = characters::refresh,
            indicatorPadding = contentPadding,
        ) {
            when {
                loadState.refresh.isLoading && characters.isEmpty -> {
                    Loader(
                        modifier = Modifier
                            .fillMaxWidth()
                            .wrapContentSize()
                            .padding(contentPadding),
                    )
                }

                loadState.refresh.isError && characters.isEmpty -> {
                    Error(
                        text = "Error",
                        onRetry = characters::retry,
                        modifier = Modifier
                            .fillMaxSize()
                            .padding(contentPadding),
                    )
                }

                loadState.refresh.isNotLoading && characters.isEmpty -> {
                    // Todo empty state
                }

                else -> {
                    val listState = rememberLazyListState()

                    TrackScrollJank(
                        scrollableState = listState,
                        stateName = "characterList:screen",
                    )

                    LazyColumn(
                        modifier = Modifier
                            .nestedScroll(scrollBehavior.nestedScrollConnection)
                            .fillMaxSize()
                            .consumeWindowInsets(contentPadding),
                        state = listState,
                        contentPadding = contentPadding,
                    ) {
                        items(
                            count = characters.itemCount,
                            key = characters.itemKey { it.id },
                            contentType = characters.itemContentType { "character" },
                        ) { index ->
                            val item = characters[index]!!
                            CharacterItem(item)
                        }

                        appendLoadState(items = characters)
                    }
                }
            }
        }
    }
}

@Composable
private fun CharacterItem(character: Character) {
    ListItem(
        headlineContent = {
            Text(text = character.name)
        },
        leadingContent = {
            AsyncImage(
                model = character.imageUrl,
                contentDescription = null,
                modifier = Modifier.size(48.dp),
            )
        },
    )
}

@OptIn(ExperimentalMaterial3Api::class)
@Composable
private fun CharacterListScreenAppBar(
    onNavigateToSettings: () -> Unit,
    scrollBehavior: TopAppBarScrollBehavior,
) {
    CenterAlignedTopAppBar(
        title = {

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.