simison / bootstrap3-less Goto Github PK

Since upgrading to v0.1.9 I'm getting the following error:

Less compiler error: #gradient > .vertical-three-colors is undefined

Here's a gist of the .lessimport that makes the error pop up.
https://gist.github.com/tanis2000/9246483

And that's the file that includes it at startup:
https://gist.github.com/tanis2000/9246497

Downgrading to 0.1.8 makes it work again.

Please support meteor 0.9

This is still using v3.0.3, could you please update to 3.1.1?

I can see somebody updated already here, so you could simply merge it: https://github.com/Nemo64/bootstrap3-less

Consider writing some simple update.sh or grunt task?

Just saw how Ratched package is dealing with this: https://github.com/axwaxw/ratchet/blob/master/ratchet-override.css

mrt version: 0.7.4
meteor version: 0.8.1.3
node version: v0.10.28

Error log as below, any idea?

ERROR: 128 Command failed: fatal: Not a git repository (or any of the parent directories): .git


STDOUT:  

STDERR: fatal: Not a git repository (or any of the parent directories): .git



/usr/local/lib/node_modules/meteorite/lib/sources/git.js:181
            self.checkoutType + ": " + (self.commit || self.head);
                                     ^
There was a problem checking out tag: v0.1.9

Would it be possible to split this package into two packages, with one package containing only the js files and the other only the less files?
The use case is that of someone only needs the less files and not the js (e.g. using angularjs and angular ui bootstrap) than it would be less size to send to the client.

Hi, I have following error:

While building the application:
client/views/venues/venues_new/venues_new.less:7:2: Less compiler error: .make-row is undefined

It happens when I do:

.new-venue {
    background: yellow;
    .make-row();
}

Please advise what can be wrong.

Thank you,
Alexei

Ok, this is more an idea so i want to discuss it.

Currently it is possible to load only less files that one needs in a project, which is awesome. But there are still all javascript files loaded. Most of my tiny projects do not need any of them.

My Idea is it to (ab)use meteors source handler to modify a bootstrap.json. This file would look like this:

{
  "variables": "client/variables.less" // modified variables file (optional)

  "scaffolding": true, // include scaffording.less
  "type": true, // include type.less
  // ...
  "modals": true // include modals.less as well as modals.js
  // ...
}

Not only would it reduce the clutter of the current bootstrap.less (it's cleaner) but it would allow to include js only when nessesary though compileStep.addJavaScript.
I would create the less file then dynamically and add it with compileStep.addAsset.

This could also be sort of backwards compatible because the bootstrap.less of project that already use this package would still work. I currently don't know if it would be possible to include the javascript if no bootstrap.json is found.

Any thoughts?

You put @import "/packages/bootstrap3-less/bootstrap.importless"; and it should be @import "/packages/bootstrap3-less/bootstrap.lessimport";

Thanks for the package, I had the pure css version but was starting to want the less files.

Meta update. :-)

It should take care of changing paths inside mixins.import.less and /less/mixins/ subfolder.

Sorry if this is obvious, but how do I get the glyphicons to work. I have the symlink in public/fonts/. then use <a class="delete" href="#"> <span class="glyphicon glyphicon-trash"></span> </a> but the icon just shows up as an empty rectangle. https://www.dropbox.com/s/sk1ztdsehnw0e05/Screenshot%202013-10-08%2010.15.55.png

http://blog.getbootstrap.com/2014/06/26/bootstrap-3-2-0-released/

When I start my app I get the following:

While building the application:
client/styles/style.less:3:1: Less compiler error: '/packages/bootstrap3-less/bootstrap.import.less' wasn't found

=> Your application has errors. Waiting for file change.

My style.less has the following:
// Everything should be a .import.less file and you should import them all into this file
// Which is then compiled to style.css
@import "/packages/bootstrap3-less/bootstrap.import.less";
// Override bootstrap variables
@import "variables.import.less";
// Custom Mixins
@import "mixins.import.less";
// Base styles
@import "../views/base.import.less";
// Template Specific Styles

Any help would be appreciated.

Ah, sorry, wrong repo :) Of course the issue is with bootstrap-less-3. I see that your package is fixed so going to switch now!
Thanks for that package!

I added this package and got the error message:

=> Errors prevented startup:

While building the application:
packages/bootstrap3-less/lib/less/carousel.lessimport:64:3: Less compiler error: Named argument for .horizontal @start-color not found

I commented out the carousel import and everything seems to work fine if I do that.

I dug into this a bit and the only thing that I can seem to come up with is that maybe a recent update to Boostrap which changes delimiters from commas to semicolons is not supported by the outdated less package that meteor includes (1.3.3 vs the latest which is 1.5.0)

Anyone else seeing this or have a workaround

It seems like this package is still using Bootstrap 3.0.0. Can we get a version bump to 3.0.3?

That's not a problem of this package. I have a package which depends on this one. In one of my less files I @import the variables.import.less file which in the past worked fine with mrt. But now, while publishing the package with meteor, it seems to build the package and then fails because of the missing @import file.

The solution was to make that path available during build time inside of your package directory. You can create a symlink to the packages directory of any random meteor app where the bootstrap3-less package is added. If you don't have such app you could simply create a packages directory and download bootstrap3-less into it.

You might want to make sure to add the packages symlink/folder to your .gitignore file!

@simison Maybe you want to add this info to the readme.

Now it's just one chunk of JS, could you keep them separate in the package? Like this: https://github.com/Nemo64/bootstrap3-less/tree/master/lib/js

I see you are suggesting to use nemo64:bootstrap less instead.

In that case, would you consider remove it from atmosphere please? It might save some time and confusion for others trying to get this working like I was.

Thanks for supporting this in the past though!

I've documented this problem on Stack Overflow:

http://stackoverflow.com/questions/22394086/meteor-bootbox-seems-to-have-erased-all-of-my-bootstrap-files

Do you guys have any idea how that happened?