simibac / confettiswiftui Goto Github PK

Is there a possibility to have a layover that just lets rain down a continuous stream of confetti across the with of a view? (As opposed to letting the confetti originate from an object on screen like a button or so.)

In Package.swift this line forces you to choose either "Embed and Sign" or not to code sign when including ConfettiSwiftUI into an app (in Xcode):

type: .dynamic

This line isn't really needed.

I discovered this when attempting to build one of my apps with Xcode Cloud. Here's the error you get during the archive process:

ITMS-90334: Invalid Code Signature Identifier. The identifier "ConfettiSwiftUI-55554944d4fbc3d9c42f38d3b8bfbbc8cd81fa38" in your code signature for "ConfettiSwiftUI" must match its Bundle Identifier "ConfettiSwiftUI"

Repeat configuration is a bit misleading.
Seems like 0 repetitions should not produce any confetti?
Did I miss something?

Expected Behaviour

code:

.confettiCannon(counter: $counter, repetitions: 3, repetitionInterval: 0.7)

produces 3 repeats

Actual Behaviour

code:

.confettiCannon(counter: $counter, repetitions: 3, repetitionInterval: 0.7)

produces 4 repeats

every time repeats count greater by '1' than expected

Steps to Reproduce the Issue

use any repetitions value in Repeat Configuration and compare with result.

even in README

.confettiCannon(counter: $counter, repetitions: 3, repetitionInterval: 0.7)

produces 4 repeats

* LOW | MEDIUM | HIGH

Story

As a ROLE, I want to ...GOAL, in order to ...BENEFIT

Acceptance Criteria

• ...

Implementation Tasks

• ...

Description

Is there a way to use SF Symbols in ConfettiSwiftUI? I tried embedding in Text but that did not work. Thanks.

Tasks

• ...

Context

...mention related issues and/or user stories...

Expected Behaviour

Expect the device behavior to match the watchOS simulator behavior.

Actual Behaviour

While the animation plays correctly in the watchOS Simulator, once it's running on the device it seems to just freeze the main thread.

Steps to Reproduce the Issue

• Tie a basic confetti view to a button press and run it on a physical Apple Watch

Will be great to change counter: Binding<Int> to trigger: Binding<Any> where Any can by generic parameter or really Any.
I'm sure that it's reasonable because:

1. We're need to know that wrappedValue just changed, not the value exactly
2. The type Binding<Int> enforces user to have binding of this type only, specially for this case
3. There are no breaking changes.

Expected Behaviour

App launch including package.

Actual Behaviour

App crashed on launch with the console output attached.

Steps to Reproduce the Issue

• Install Swift Package via Xcode package manager
• Build to iphone

Expected Behaviour

There should appear the number of confetti I decide

Actual Behavior

it takes too long to render the number I have chosen. and either they do not render, or they are delayed, and then disappear suddenly during animation.

Steps to Reproduce the Issue

• Create a confetti cannon with a higher num:
  I would like up to 1000. but I was having issues even with 100-200 or more.

Description

Hey Simon, cool project! In the README file you mention "Installation" and "Usage," yet legally no one can use this project in an app on the App Store because you hold the copyright. Could you put a LICENSE file in the repository to permit usage? I recommend the MIT open source license as it is the most popular in the Swift community and widely compatible. Thanks!

Tasks

• Make LICENSE file based on the MIT template

if you scroll out the cannon view, the next time you scroll it in, the cannon breaks

Expected Behaviour

Animation stops when app goes to background or completes successfully while in background

Actual Behaviour

"Fatal error: Index out of range," on line 134, "animate[value-1].toggle()"
value in this statement is 0 leading to "index out of range"

Steps to Reproduce the Issue

• Do something that triggers confetti animation
• Press Home button before animation is complete
• Reproduce

I am using the confetti in RsyncUI for new users. If a new user chooses a function before the confetti is completed the app crashes. If I just remove the confetti from the FirstTime view RsyncUI works as expected. It seems like there is a bug within the confetti which causes to take down the macOS app when closing the confetti before it is completed.

I try to add an emoji which is recieved by an APN:

    @State private var receivedEmoji: String = "🎉"
    @State private var cannonEmoji: String = "🥥"
[...]
        VStack {
[...]
        .onChange(of: receivedEmoji) { newValue in
            animationCounter += 1
            cannonEmoji = newValue
            print("Emoji \(cannonEmoji)") <--- here it prints the recieved emoji and not the initialized one.
        }
       // .animation(.easeInOut(duration: 0.5), value: sortedActions)
        ConfettiCannon(counter: $animationCounter ,confettis: [.text(cannonEmoji)], confettiSize: 20)

.text(cannonEmoji)allways fires the coconut (🥥) - which looks also great. :D

How can I solve this?

Hi!

Using ConfettigSwiftUI on iOS and love it there. But while porting the app on visionOS, I noticed that the confettis started to flicker

Tried changing the background, in case this has something to do with the Material, and also tried setting the .offset(z:), but nothing helped yet.

Any idea what could cause this?

This is my code for the confettis:

.confettiCannon( counter: $confettiCounter, num: 200, confettis: [ .shape(.circle) ], colors: confettiColors, openingAngle: Angle(degrees: 0), closingAngle: Angle(degrees: 360), radius: 200 )

Thanks!

Expected Behaviour

I Put Sources/ConfettiSwiftUI folder in my Xcode project. enable Copy items if needed and Create groups.

Actual Behaviour

Then Build Fail

Steps to Reproduce the Issue

The git diff

Xcode 14.3.1

Finally I have discard all changes, and build success.

ConfettiCannon(counter: $counter, num: 200, repetitions: 3, repetitionInterval: 3)

This is shown on console:

ignoring singular matrix: ProjectionTransform(m11: 1.0, m12: 0.0, m13: 0.0, m21: -0.5, m22: -0.5, m23: -0.1, m31: 2.5, m32: 7.5, m33: 1.5)
ignoring singular matrix: ProjectionTransform(m11: 1.0, m12: 0.0, m13: 0.0, m21: 0.5, m22: 0.5, m23: 0.1, m31: -2.5, m32: 2.5, m33: 0.5)

Right now the library does not allow for the change of ConfettiConfig while it is presented. It will only change it if the view is rerendered. But rerendering is also not desired in some cases because it causes the current animation to stop.

Please provide a way of changing ConfettiConfig without tearing down the view. Thanks!

Expected Behaviour

Describe the expected behaviour.
The popped out confetti should slowly rain down

Actual Behaviour

Describe the actual behaviour.
The popped out confetti fastly rains down

Steps to Reproduce the Issue

I am using this in combination with https://github.com/joogps/SlideOverCard. The library is the problem, because I tried it already on my Home Screen and there it worked fine. I would like to ask if you could tell me a solution :)