Hello. Please push me in the right direction. I'm not asking for a full-working code,

Help wanted: Span never received from actix-web thread about rustracing_jaeger HOT 3 CLOSED

sile commented on May 30, 2024

Help wanted: Span never received from actix-web thread

from rustracing_jaeger.

Comments (3)

sile commented on May 30, 2024

Thank you for reaching out.

Your code snippets seem almost fine, so I'm wondering why that didn't work. The only problem that might be is if the channel is empty, span_rx.try_recv() will immediately return Err(TryRecvError::Empty) and break the above while loop.

BTW, if you could share a working example code to reproduce the issue, I would investigate it in more detail.

from rustracing_jaeger.

e-oz commented on May 30, 2024

Thank you very much, you were right - loop was called before the request :)
I fixed it with RAII magic.

I'll post here parts of my code just in case if it will be useful.
Thank you again!

pub struct TraceSender<'a> {
    pub channel_receiver: &'a Receiver<FinishedSpan>,
    pub reporter: Option<&'a JaegerCompactReporter>,
}

impl<'a> Drop for TraceSender<'a> {
    fn drop(&mut self) {
        if let Some(reporter) = self.reporter {
            while let Ok(span) = self.channel_receiver.try_recv() {
                let _ = reporter.report(&[span]);
            }
        }
    }
}

pub struct TraceFactory {
    pub tracer: Tracer,
    channel_receiver: Receiver<FinishedSpan>,
    reporter: Option<JaegerCompactReporter>,
}

impl TraceFactory {
    pub fn new(tracer: Tracer, channel_receiver: Receiver<FinishedSpan>, reporter_name: &str) -> TraceFactory {
        let reporter = match JaegerCompactReporter::new(reporter_name) {
            Ok(r) => Some(r),
            Err(_) => None
        };
        TraceFactory { tracer, channel_receiver, reporter }
    }

    pub fn get_sender(&self) -> TraceSender {
        TraceSender { channel_receiver: &self.channel_receiver, reporter: self.reporter.as_ref() }
    }
}