Code Monkey home page Code Monkey logo

Comments (7)

sile avatar sile commented on May 30, 2024 2

Hi, sorry for the delayed response and thank you for creating this issue.

Your opinion seems reasonable but using INADDR_ANY is a desired feature by a user (see #10). So I'd like to "change the default to SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 0)" as you suggested, and provides a new option to control whether to use INADDR_ANY.
What do you think of it?

from rustracing_jaeger.

sile avatar sile commented on May 30, 2024 1

Created #26.
Instead of adding an option, I introduced methods to change the reporter's biding address.

from rustracing_jaeger.

anita-tenjarla avatar anita-tenjarla commented on May 30, 2024

I think that's a great idea! So what's the next steps here, would you prefer to open a PR or should I?

from rustracing_jaeger.

sile avatar sile commented on May 30, 2024

Thank you for your reply! If you can wait until this weekend, I'll create the PR. Of course, your contribution is very welcomed if you're interested in doing that.

from rustracing_jaeger.

anita-tenjarla avatar anita-tenjarla commented on May 30, 2024

Oops! Sorry I missed this. If it's alright with you, I'll just wait til this weekend for your PR (or whenever you get a chance).

from rustracing_jaeger.

sile avatar sile commented on May 30, 2024

Okay. No problem! I'll create the PR.

from rustracing_jaeger.

anita-tenjarla avatar anita-tenjarla commented on May 30, 2024

Looks great, thank you! I'll close this issue once PR is merged.

from rustracing_jaeger.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.