Comments (7)
Hi, sorry for the delayed response and thank you for creating this issue.
Your opinion seems reasonable but using INADDR_ANY is a desired feature by a user (see #10). So I'd like to "change the default to SocketAddr::new(IpAddr::V4(Ipv4Addr::new(127, 0, 0, 1)), 0)
" as you suggested, and provides a new option to control whether to use INADDR_ANY.
What do you think of it?
from rustracing_jaeger.
Created #26.
Instead of adding an option, I introduced methods to change the reporter's biding address.
from rustracing_jaeger.
I think that's a great idea! So what's the next steps here, would you prefer to open a PR or should I?
from rustracing_jaeger.
Thank you for your reply! If you can wait until this weekend, I'll create the PR. Of course, your contribution is very welcomed if you're interested in doing that.
from rustracing_jaeger.
Oops! Sorry I missed this. If it's alright with you, I'll just wait til this weekend for your PR (or whenever you get a chance).
from rustracing_jaeger.
Okay. No problem! I'll create the PR.
from rustracing_jaeger.
Looks great, thank you! I'll close this issue once PR is merged.
from rustracing_jaeger.
Related Issues (18)
- Example incorrect HOT 3
- Allow connecting to non-local agents HOT 2
- Enable injectors and extractors bound to tracer HOT 1
- Constructing TraceId from String HOT 2
- Ability to send spans directly to collector over HTTP HOT 1
- What is the expected way of using this library across threads? HOT 3
- Automatically set ip tag HOT 4
- Example panics HOT 1
- Help wanted: Span never received from actix-web thread HOT 3
- Logs & Tags not coming through to Jaeger UI. HOT 1
- Make it possible to retrieve `flags` HOT 1
- Remove the requirement to use `crossbeam` HOT 2
- reporter: support for async futures-based report() HOT 6
- Running into an error when using an alternative SocketAddr. HOT 11
- Allow generating span from known TraceId HOT 4
- Impl OpenTracing default carrier traits for SpanContextState. HOT 1
- Help wanted: Use span and Sub-span HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rustracing_jaeger.