Code Monkey home page Code Monkey logo

significa-start's People

Contributors

danilowoz avatar darosadev avatar dependabot[bot] avatar pdrbrnd avatar pedrobslisboa avatar semantic-release-bot avatar tofran avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

significa-start's Issues

Move CI to Github Actions and config Semantic Release

In order to automate the process of new releases, it needs the Semantic Release to be configurated properly for every new merge in master the tool decide which is proper version and publish it on Npm.

Also, it would be a good idea to move the CI scripts to Github Actions.

Folders structures problem

Problem

For some reason every time I try to execute this CLI, the folders structures are messed up, it occurs with all the stacks :/

Captura de tela de 2020-08-12 10-21-50

Improve way how it handles the SVG files

Currently, there is only one way to import SVGs, which converts to a React Component. We've faced some issues while trying to import as path, like a regular file. So the idea here is to improve how we handle and make sure that all kind of assets is working fine:

For SVGS files: https://www.npmjs.com/package/@svgr/webpack

import starUrl, { ReactComponent as Star } from './star.svg'
const App = () => (
  <div>
    <img src={starUrl} alt="star" />
    <Star />
  </div>
)

For images:
https://www.npmjs.com/package/next-images#usage

Eslint - alphabetical order

All the sort-exports/sort-exports need to be in alphabetical order, maybe remove this option because sometimes we lost a lot time on this.

What about options for 'stacks'?

It would be nice to have options to choose our stack.

Problem

Let's suppose the user write the command like this:

npx @significa/start nextjs hello-world

It may be right for some of them since nextjs spelling is common and they will receive an Error:
β€Ί Error: Expected nextjs to be one of: cra, gatsby, next
So they have to read the documentation to know exactly the stack's name.

Solution

With options, we could increase that experience:

Captura de tela de 2020-07-21 09-17-05
Captura de tela de 2020-07-21 09-07-03

Giving options, we also delivered to users new future stacks without the necessity to be up to date with the documentation. If some stack exists on options you can you, if don't you can't.


What do you guys think about it? πŸ€”

The automated release is failing 🚨

🚨 The automated release from the master branch failed. 🚨

I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.

You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. I’m sure you can resolve this πŸ’ͺ.

Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.

Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master branch. You can also manually restart the failed CI job that runs semantic-release.

If you are not sure how to resolve this, here is some links that can help you:

If those don’t help, or if this issue is reporting something you think isn’t right, you can always ask the humans behind semantic-release.


Invalid npm token.

The npm token configured in the NPM_TOKEN environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/.

If you are using Two-Factor Authentication, make configure the auth-only level is supported. semantic-release cannot publish with the default auth-and-writes level.

Please make sure to set the NPM_TOKEN environment variable in your CI with the exact value of the npm token.


Good luck with your project ✨

Your semantic-release bot πŸ“¦πŸš€

React Native option

Considering the following topics:

  • Dot-env friendly;
  • Typescript;
  • Significa-style;
  • Fastlane to update: App name, app icon, ios/android envs;
  • Fastlane to create certificates from Apple.

Handle import images on Gatsby

Problem

We add a config on NextJs to deal with images, you can see here #41

But there is no loader for several IMG types config on Gatsby

Solution

Add the same config to Gatsby

Use a better approach on types/styles

Problem

import * as S from './styled'
import * as I from './types'

@marcelines and I talked about it, and we think that it could be a better way to deal with, improving legibility.

Imagine if you need to import another type on this file:

import * as S from './styled'
import * as I from './types'
import * as T from '../Card/types' //?????? 

The code below is from a 'type' file, and it has import * as I ...

import * as I from '../../types/orders'

export type OrderTitle = {
  id: string,
  insertedAt: string,
  status: I.OrderStatus
}

export type OrderSummary = {
  total: number,
  totalBeforeVat: number,
  totalVat: number,
  packagingPostageTotal: number
}

Same problem. Imagine if you need to import another type on this file:

import * as I from '../../types/orders'
import * as T from '../../types/categories' // ??????

export type OrderTitle = {
  id: string,
  insertedAt: string,
  status: I.OrderStatus
}

export type OrderSummary = {
  total: number,
  totalBeforeVat: number,
  totalVat: number,
  packagingPostageTotal: number
}

Solution

We can do like this:

import * as Styled from './styled'
import * as CardStyled from '../Card/styled'

import * as Types from './types'
import * as CardTypes from '../Card/types'
import * as OrderTypes from '../../types/orders'
import * as CategoriesTypes from '../../types/categories'

export type OrderTitle = {
  id: string,
  insertedAt: string,
  status: OrderTypes.OrderStatus
}

export type OrderSummary = {
  total: number,
  totalBeforeVat: number,
  totalVat: number,
  packagingPostageTotal: number
}

or:

import { StyledGood } from './styled'
import { StyledCard, StyledButton } from '../Card/styled'

import { GoodType, PropsType } from './types'
import { CardType } from '../Card/types'
import { OrderType } from '../../types/orders'
import { CategoriesType } from '../../types/categories'

export type OrderTitle = {
  id: string,
  insertedAt: string,
  status: CategoriesType
}

export type OrderSummary = {
  total: number,
  totalBeforeVat: number,
  totalVat: number,
  packagingPostageTotal: number
}

.gitignore is not being added

After running the starter, the newly created project is lacking the .gitgnore file. This way, starter users will upload node_modules on their first commit.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.