sierpinski / blitz Goto Github PK

Pull Request Count is alway 0 and non of the PRs are showing even that there are bunch of them assigned to me and I own a couple PR. Same thing is happening on different project in azure.

My workmates have the same issue. Web browser we are using is Chrome
I noticed that following steps are fixing the issue but only for a short period of time:
Developer Tools > Application > Storage (on the left) > Clear Local Storage & Session Storage

Once you click on "handle request" it opens a new tab and it breaks authentication. The page loads but all content is "blank".

The moment I click on "something" I get:

401: 401: error
TFS.WebApi.Exception: 401: error
at k (http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/corejs?v=ITI0eYHCCehqqjk6JTyPaR5R793ETLoY2_Lqz191Pyo1:64:375)
at http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/corejs?v=ITI0eYHCCehqqjk6JTyPaR5R793ETLoY2_Lqz191Pyo1:64:2955
at d (http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/corejs?v=ITI0eYHCCehqqjk6JTyPaR5R793ETLoY2_Lqz191Pyo1:64:635)
at http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/corejs?v=ITI0eYHCCehqqjk6JTyPaR5R793ETLoY2_Lqz191Pyo1:64:2888
at l (http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/q.js:27:8122)
at http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/q.js:27:8348
at t.when (http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/q.js:27:3780)
at t.u.promiseDispatch (http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/q.js:27:2824)
at http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/q.js:27:1649
at MessagePort.t (http://tfs.local:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/q.js:27:5773)
Session Id: f2ae9b26-30b6-40d4-8d90-4c48a29b7563

Would be cool If i get this to work since the build-in view is WAYY too limited.

Even if there's still code available to print failed merge status in red (https://github.com/sierpinski/Blitz/blob/master/BlitzExt/blitzallpulls.html#L93) it no longer seems to work (Failed is always written in green)

So installing the extension is great through the gallery. Can we add a dashboard widget that shows at least the number of open? That would be great.

I'm not sure what's involved in a dashboard widget but would be willing to help learn if you don't know too..

When a user visits the extension and there are many pull requests, they may wish to filter and see only those pull requests assigned to them.

Original request here: https://twitter.com/KinigitByDay/status/730466645701877761

Great extension would you be interested in listing this on the gallery so we can use it easily?

https://www.visualstudio.com/integrate/extensions/publish/guidelines

I would be willing to help make it happen if you need?

We use your extension with VSTS, and it seems like the latest update to this extension has a problem where the scrolling div overflows past the bottom of the screen when there are many active pull requests out. The issue seems to be with the CSS for pullRequestTableContainer, specifically the height.

In my tests, it seems like setting the height to the following fixed the issue:

height: calc(100% - 80px)

(80px is the combined height of the two VSTS toolbars)

I forked the branch and could make a pull request if wanted. I'm not sure if this change will negatively impact the use of this extension with TFS, as I am unable to test that. Cheers!

It would be nice if the PR view could auto-refresh itself (like eg. dashboards could). Use case is if PR view is eg. used on a team screen.

We need a dark theme that fits better when dark mode is enabled in devops:

An additional column showing the repository for which the PR is open would be helpful.

I know the intention of #19 was to remove the ugly button, but now I can't open PRs in a new tab anymore.

The view for the LoadPullRequestData method seems to be missing

If I understand correctly, the ultimate goal of this project is to do what "Pull Requests" tab is already doing, only better (by ignoring current repository scope). As a user I expect to see the same controls for Pull Requests.

What bothers me right now is the fact that content of the new tab looks totally different from what all users are used to see in "Pull Requests" tab. It makes new users confused and not willing to interact with the extension.

The 'Active Pull Requests' page keeps loading undefinitely.
If I have a look at the network exchanges using the Chrome developer tools, I see a 404 for Bundling.js

The TFS on premises instance is a 2015U2

We just installed this extension on our on-premise TFS 2015 Update 3 server but we don't see any active pull requests even though we're sure there are some. Opening the Chrome developer tools displays the following errors:

appinsightsblitz.js:2 Uncaught DOMException: Failed to read the 'cookie' property from 'Document': The document is sandboxed and lacks the 'allow-same-origin' flag.(…)window.appInsights.config.instrumentationKey @ appinsightsblitz.js:2(anonymous function) @ appinsightsblitz.js:3
2jquery-2.2.3.min.js:4 OPTIONS https://tfs.rhea.infosupport.net/TFS/NS/NS%20Railpocket/_apis/git/PullRequests send @ jquery-2.2.3.min.js:4ajax @ jquery-2.2.3.min.js:4(anonymous function) @ corejs?v=ITI0eYHCCehqqjk6JTyPaR5R793ETLoY2_Lqz191Pyo1:64n._wrapCallback @ VSS.SDK.min.js:4(anonymous function) @ VSS.SDK.min.js:4(anonymous function) @ VSS.SDK.min.js:4
blitzallpulls.html:1 XMLHttpRequest cannot load https://tfs.rhea.infosupport.net/TFS/NS/NS%20Railpocket/_apis/git/PullRequests. Response to preflight request doesn't pass access control check: No 'Access-Control-Allow-Origin' header is present on the requested resource. Origin 'null' is therefore not allowed access. The response had HTTP status code 440.
q.js:27 Error: An undefined error occurred while attempting to connect to the server. Status code 0: error.(…)

Any ideas?

Installed the extension in a VSTS project.

Menu items are correct when "Active Pull Request" is inactive:

But invalid menu items appear when it is active:

When users for a project in the project collection I have the extension installed on try to access Active Pull Requests they get the following:
 Ajax request failed with status: Unauthorized.
 TFS.Core.Ajax.AjaxException: Ajax request failed with status: Unauthorized.
 at st (http://tfs.cbre.com:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/TfsPresentationCoreJs?v=7tQ5nGOZDx0K-CFDzzUf8IXp0yuRpEAHLZhc5qVTYQE1:22:5213)
 at http://tfs.cbre.com:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/TfsPresentationCoreJs?v=7tQ5nGOZDx0K-CFDzzUf8IXp0yuRpEAHLZhc5qVTYQE1:22:1652
 at nt (http://tfs.cbre.com:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/TfsPresentationCoreJs?v=7tQ5nGOZDx0K-CFDzzUf8IXp0yuRpEAHLZhc5qVTYQE1:22:893)
 at Object.error (http://tfs.cbre.com:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/TfsPresentationCoreJs?v=7tQ5nGOZDx0K-CFDzzUf8IXp0yuRpEAHLZhc5qVTYQE1:22:1263)
 at j (http://tfs.cbre.com:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/basejs:2:26860)
 at Object.fireWith as rejectWith
 at x (http://tfs.cbre.com:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/basejs:4:11145)
at XMLHttpRequest. (http://tfs.cbre.com:8080/tfs/_static/tfs/Dev14.M102/_scripts/TFS/min/basejs:4:14767)
Session Id: 33353f8d-fcb0-4019-9ac1-8994c61cc7a2

Please let us know what we can do to have users allowed to use the extension. I am able to use it but I am a Project Collection Administrator if that makes any difference.

It would be useful if more state information about the PR can be shown:

• Reviewer approval state
• State of work item link policy
• State of build policy

Firefox is having an issue where it is automatically scrolling back up when the user scrolls down.

So the "Handle Request" button thing is a little clunky.

1. Its on the far right of the grid. Not the natural expected left for action.
2. Why the button? Its really just a link to the PR, right? Nothing more?
   I think it would be far better for space utilization to drop that column altogether and allow access by either click on the row in general, or turning the request number into a hyperlink to the request.
3. the button is not even visible if you increase your resolution. It goes offscreen. Doing #2, would eliminate that concern.

User points out that merge conflicts are labeled as "FAILED" instead of "Conflicts" or other more accurate term. Replace the term failed with a more accurate term, such as conflicts.

#10 was a great addition, but when a team or group you're in has been assigned to the pull request rather than your user directly, it does not show up as a pull request waiting for your review according to this extension, even though it does on the "Pull Requests" tab of a repository. This extension is fairly useless for me at the moment because of the lack of this feature.

If the on-prem instance has both HTTP and HTTPS enabled, the latest extension (1.0.43) will no longer loads when installed under HTTPS. It used to work inconsistently with some browser clients, but still used both the encrypted and unencrypted URLs when displaying data. It fails to load when installed under https URL. If installed under HTTP, it will only work under HTTP.

Hi, thank you for this great extension. I use it daily to get an overview of all the code I have to review that day. However, it is a bit frustrating that there is no way to see if the PR is a draft or not. Could this be implemented somehow? Maybe the drafts could be greyed out/italic or something?

Since the update to v1.0.10 this morning the list of active pull requests no longer works in my TFS2018 system under Firefox 61.0.2, Edge 42.17134.1.0, Chrome 68.0.3440.106 or IE 11.228.17134.0.

The user is presented with a blank list:

The browser console gives the following error messages:

Hi we are using this app now and i see that the state of 'merge status' is wrong or it comes from a place which is not correct.

What I expect is that is show the status of merging the PR to target branch (in my case Development) but the PR is still active and there is no merge to this target.

what can we do to get the correct state of the 'merge status'.

Anyone in the team can drop "<script>alert('!')</script>" into the PR description and successfully sabotage access to the extension tab. More importantly if it is installed on corpo-instance (on premise), you have no guarantee that someone will not try to hack other developers.

It would be nice if we could filter by repository.
Ideally, you'd be presented with a multi-select containing all repositories you have access to.
If the user selects one or more options from the multi-select, the results would be filtered.

A possibility to save the state of the selected values in the multi-select would also be ideal, so that you don't have to reselect those repositories each time you visit the page.

We are using a gitflow similar workflow, with development and master branches.
Im assuming as we have development set as the default branch that its causing problems, because it is not showing any development branches.

I'm using TFS on prem and have noticed that the hyperlinks to pull requests are broken if the team collection contains spaces

It would be great to have an option to display the number of closed/active comments in the dashboard. Something like this:

I don't see any additional PR widgets available after install (on-prem).

Would it be possible to add the status of the PR build next to the merge status?