sidewalklabs / oldto Goto Github PK

e.g. to look at https://oldto.sidewalklabs.com/#DC-PICTURES-R-6576 on Cardboard or another VR headset.

Click a dot on mobile to open a popup. Click somewhere on the popup. You'll open the grid view. But underneath the grid view you'll either have tapped the map (which closes the popup) or another dot (which will open a new popup).

The desired behavior is that the popup stays open.

This doesn't happen on desktop.

If you save the OldTO page to your home screen on an iPhone, it uses a screenshot as an icon. Alison mocked up some real icons for us to use:

OT-031618-AppIcon.sketch.zip

• Hide the social share buttons
• Hide the "Help us fix it" link
• Hide the keyboard after you search for an address
• You can't drag the knobs on the time slider
• Open random images and reset UI after idle for 15 minutes?

cc @craignm

Now that we have images from the TPL in addition to CTA (#24), it'd be nice to have a way to filter by source.

When you click out of the gallery view, the location pop-up should still be up (so if you get direct-linked to a photo and exit, you can see where it was on the map)

This issue was automatically created by Allstar.

Security Policy Violation
Security policy not enabled.
A SECURITY.md file can give users information about what constitutes a vulnerability and how to report one securely so that information about a bug is not publicly visible. Examples of secure reporting methods include using an issue tracker with private issue support, or encrypted email with a published key.

To fix this, add a SECURITY.md file that explains how to handle vulnerabilities found in your repository. Go to https://github.com/sidewalklabs/oldto/security/policy to enable.

For more information, see https://docs.github.com/en/code-security/getting-started/adding-a-security-policy-to-your-repository.

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

We have permission to do this from the Toronto Public Library. This adds ~8,000 new images to the map, bringing us from ~35,000 → ~43,000.

There are a few remaining issues before we can launch these:

• Slightly shifted dots between TPL & CTA images that aren't merged, e.g. Yonge St & Adelaide St. E/W. This might just be an issue around cache reuse.
• Some bad POI names get surfaced, e.g. "post office" and "variety store".
• Toronto Star image titles are much longer than our previous ones, so we may want to clip them in previews.
• Switch to git-lfs for images.geojson (which is now >100MB).

The scrollbar is always visible, even if it's not needed. Reported by both @pandananta and @davidbstein.

Probably missing a preventDefault or stopPropagation call on the event.

Any objection? Makes sense to me to have one container for building app and running it (:ballot_box_with_check:), and another for processing data :)

Happy to hear criticism of that though!

This is by far the most complained about location.

Some debugging on how this happened…

• There were two "Church of the Holy Trinity" POIs during OldTO development
• The incorrect one had a higher OSM ID than the correct one, so it won out.
• This seems to be the last time the parent mined data was generated.

An easy solution would be to add a correct location to toronto-pois.osm.csv.

CircleCI now has an official Docker image that combines Python, Node and Yarn. We don't need to use our own any more:

https://oldtoronto.sidewalklabs.com/#430146

In the File, this is listed as 1972-1989.

Corrections currently get submitted into a Google sheet.

We'd like to have our API server:

• Load this data from the spreadsheet every ~10 minutes
• Populate a database with it
• Merge the data from images.geojson and the new database for our two API calls

This way user corrections will be live until we incorporate them into images.geojson, which will be a much better experience for users.

Any thoughts on using this tool?
https://docs.pipenv.org/

To explain, I'm having some issues getting the python processing libraries working in an alpine linux docker container. I feel like being a little looser on the specific version constraints in a Pipfile might help people navigate issues like this across systems.

Specifically, there seem to be some off conditions where pandas version X has trouble in docker, and where certain packages must be installed in a specific order -- the alpha order in the requirements.txt doesn't seem to work. Anyhow, I'll sort the specifics elsewhere, but wondering if there's any opposition to using pipenv to generate real dep resolution lockfiles.

Thanks for any consideration

This could be a fun way to explore the collection. See
https://www.thestar.com/opinion/star-columnists/2018/03/23/travel-through-time-across-toronto-with-help-from-googles-sidewalk-labs.html

There is already code that can do this here.

If you go to:
http://localhost:8080/#606649

You see:

[Wed Mar 21 2018 12:21:29 GMT-0400 (EDT)] "GET /api/layer/oldtoronto/606649" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36"
[Wed Mar 21 2018 12:21:30 GMT-0400 (EDT)] "GET /api/layer/oldtoronto/606649" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.162 Safari/537.36"

This issue was automatically created by Allstar.

Security Policy Violation
No protection found for branch master

This issue will auto resolve when the policy is in compliance.

Issue created by Allstar. See https://github.com/ossf/allstar/ for more information. For questions specific to the repository, please contact the owner or maintainer.

Easiest fix would be to disable pinch-to-zoom entirely. It's probably some awkward interaction with the grid.