siddharth-maddali / phaser Goto Github PK

I think there might be a bug in one of the post processing functions: specifically, in the line

y, x, z = np.meshgrid(
        np.arange( supC.shape[0] ),
        np.arange( supC.shape[1] ),
        np.arange( supC.shape[2] )
)

in the function centerObject in the PostProcessing.py module. Later lines were giving me a shape mismatch between x,y,z and supC; it looks like the default inputs for np.meshgrid ('xy' indexing) give a matrix with a shape whose first dimension corresponds to the second vector input and whose second dimension corresponds to the first vector input. So it seems like the line should be 

y, x, z = np.meshgrid(
        np.arange( supC.shape[1] ),
        np.arange( supC.shape[0] ),
        np.arange( supC.shape[2] )
)

or, alternatively, one could set indexing='ij' as a parameter in the meshgrid function.

(And the shape mismatch errors do go away after I make this change.)

It looks like the HIO function doesn't update the modulus before updating the error; leading to a static error output during HIO iterations. Should have something like

def HIO(...):
...
self._UpdateHIOStep()
self._UpdateMod()
self._UpdateError()