sidane / xenforo-threadmarks Goto Github PK

Disable javascript and hover over the threadmarks pagination button.

Woops!

Some members on http://www.redcafe.net/ have requested threadmarks for conversations, as quite a few of them have long running ones spanning dozens of pages.

Off the top of my head, this would require making the threadmarks table polymorphic. I haven't give much thought to other implementation details yet.

Tracking this feature request here for future consideration.

For guests with hid the menu, and users without javascript; the Threadmarks menu is clickable.

For users with javascript, it isn't and they need to mouse down to get to the "view all" link, if it exists.

As a general practice, menus in XF which use overlays also implement the link as clickable to the fallback page.

Not entirely sure of this feature myself, but putting it here for feedback.

On the thread list page, show the threadmarks drop down menu with threads that have threadmarks.

Something like:

Will enable quick navigation to specific posts without having to go into the thread.

$linkData is not being passed into the page_nav_threadmarks template.

Alerts are great, everyone love them.

Fairly straightforward to implement, but I would like to kick the alert generation into a deferred task which then pumps out alerts.

When quick-replying, add a field to enter a threadmark is the user is permitted to add threadmarks.

On posting replies via More Options, it should also be possible to create a threadmark.

This controller gets all threadmarks, and then does processing. This should be split into two.

• Model_Threadmark::getRecentThreadmarks($thread) method to be used to permit caching
• Extending Model_Thread to fetch per post threadmark data inlined into the posts.

To reproduce: On a touch device, tap on the 'Threadmarks' menu to display the list of most recent threadmarks. The drop down menu opens but so does the 'All threadmarks' overlay.

Solution: Prevent overlay from opening when tapping the 'Threadmarks' button. Ideally only on touch devices, but if necessary remove entirely for consistent behaviour across all devices.

Verified on iOS but not any other mobile OS.

If you move a post with a threadmark between threads, the state in the threadmark table isn't updated.

Once #44 and #47 are committed, and I've merged changes from them; I will issue a PR for https://github.com/Xon/xenforo-threadmarks/tree/sortable_threadmarks

The ability to show New Threadmarks, (much like the New Media, New Resources or New Posts) would be a great content discoverability tool.

To improve upgrading compatibility, converting CSS to use Style Properties for a bunch of the colors would be ideal.

The use case I'm looking at, is that a user may wish to tag a number of posts as 'chapters', the other as 'supplementary' and then tag a bunch of posts as fanart.

This implies user/moderator generated threadmark categories, and the requirement to manage them.

The recommended solution is template medication system, using the following as the replacement:

$0
<xen:include template="myTemplate" />

This will allow the templates to be edited from AdminCP, and helps the "load public templates as files" performance feature to work better.

Some of the css has the invalid tag:

font-style: italics;

I'm actually fine with it not being in italics.

Hi,

So far I've rolled this threadmark addon to http://forums.sufficientvelocity.com and it has had a great reception.

I'm considering extending adding a Next and Previous button on each post with a threadmark.

From here; http://forums.sufficientvelocity.com/posts/2726004/ one of my users has mentioned the closeness of the threadmark button and the 'go to first unread' button makes it easy to confuse on a mobile device or when operated by memory.

Do you have any thoughts about where a next/previous button could live? And how to move the threadmark button itself so it is more mobile friendly?

The actual code-backend of the next/previous button is underway, and I'm just tidying it up a bunch before it will be ready for a PR.

To help track down abuse of threadmarks, is it worth tracking who created (and updated) each threadmark?

An admin control panel log of new threadmarks, with their creator, might be a useful addition as well for detecting abuse.

What do you think @Xon?

See #17.

When moving a threadmarked post to a different thread, it would be preferable to not defer the updating of a threadmark's `thread_id.

It takes a few seconds (or longer if larger forums are running deferred tasks via cron) for the threadmark to appear in the target thread. This is likely to lead to confusion among moderators/admins, they may think the threadmark has been lost during the move.

Investigate alternatives to deferring.

To reproduce:

1. Threadmark a post
2. Edit it and save

Two posts will be rendered instead of a single, updated post.

Xon/XenForo-WordCountSearch#2
Add support for showing the wordcounts on a threadmark index, and a total for all threadmarked content. This issue will require changes to the above add-on and threadmarks.

In portrait mode, on my galaxy nexus, the "got unread" goes away if there are thread marks.

In landscape mode, the threadmark button isn't aligned with the unread button properly

If you have 1 page, the dropdown doesn't show up.

To reproduce:

1. Threadmark a post
2. Edit it and save

Updated post is re-rendered but the threadmarker is not. This only affects the user editing the post.

Refreshing the page shows the threadmaker again.