siccity / dialogue Goto Github PK

Currently there is no any method that's called for initializing your gui stuff, since it doesn't inherit from ScriptableObject nor, Behaviour.

Would be nice to have some virtual method/prop to override window's title content in NodeGraphEditor. Btw, some reference to actual NodeEditorWindow class would also be handy.

When writing an extensive dialogue the lack of shortcuts are draining.

Simple stuff like adding another chat response requires you to move the mouse down to click a small button, then move your mouse back to select the field, before you can actually start typing... then repeat on next response. There should be a keyboard shortcut to add a response and select the text field automatically.

I did a quick dive into this and as usual we trust unity to have our back and is thoroughly disappointed. It turns out to be a quick way to make your neat CustomNodeEditors into ugly monsters. Custom action enum, custom action node reference, loads of if this do this weird thing, etc. Polluting the nice clean flow of the editors.

I believe what is needed is command mechanism that is hooked into the NodeEditorGUILayout so that all the ugly boilerplate code that makes it works is hidden away.

If we imagine that we added some context, scattered throughout the editor codebase.

NodeEditor.PushContext(node.GetInstanceID());
NodeEditor.PushContext("ChatEditor");
NodeEditor.PushContext("Answer "+i);

Then we could simply do something like this

IssueCommand(Commands.CreateConnectedChat);
IssueCommand(Commands.CreateAnswer);

The commands should ofcourse wait till a suitable time in the gui flow to add the new stuff, repaint and even focus the newly created items. So CreateConnectedChat would do something like this:

var output = GetOutputPort(command.CallerLocation);
var newChat = command.graph.AddNode<Chat>();
newChat.position = GetNode(command.CallerLocation).position + new Vector2(450, 0f); // ???
output.Connect(newChat.GetInputPort("input"));
IssueCommand(Commands.FocusControl, ConstructContext(newChat.GetInstanceID(), "ChatEditor", "text"));

Of course the NodeEditorGUILayout should be responsible for setting up the control name and applying the focus on the next repaint.

There are some places in code that assumes there is always only one graph opened at time, like
NodeEditorWindow.current
While generally multi editor windows works, there are some exceptions thrown. Afair they relate to assigning/getting window preferences.

You can't tint with bright color. They too dark and you didn't see labels at it.
Colors for backgrounds are inlined and tangled with code, they need to be in settings window at my opinion.

The node formatting shown in the image of the readme does not seem to be included in the repo.

This is how it looks when imported in to a clean project:

Do you plan to go further this project? any roadmap?