[Improvement]: Head and tail args for the log command about shuttle HOT 12 CLOSED

It's merged, we can close it ? #1629

from shuttle.

is anyone is working in the issue
i want to work in this

from shuttle.

@biplab5464 All yours. Thanks for showing interest.

from shuttle.

can you give me little hint where to start

from shuttle.

You can either start by adding the arguments in cargo-shuttle/src/args, and passing them into the functions that eventually call the log endpoints, or you can start by adding query parameters to deployer's two log endpoints, and pass them on to the gRPC call to logger (requires updating the logger's proto file and regenerating the proto code).

from shuttle.

--head --tail --all are all optional value right

from shuttle.

Yes

from shuttle.

currently -h use for help so we have to give some other short name to the head

Command mod_test: Short option names must be unique for each argument, but '-h' is in use by both 'head' and 'help' (call `cmd.disable_help_flag(true)` to remove the auto-generated `--help`)

from shuttle.

Hmm, yeah then we can probably skip the short args for now.

from shuttle.

hey, can you help me, i have added the argument in the function but i am unable to understand how the log is getting fetch and how can get log of specific head and tail
if we can talk over something like discord ?

and can you please review the above code tell me if it need any change

from shuttle.

The argument definitions are looking good. The parsing to make the arguments mutually exclusive can instead be accomplished with the clap macros.

You can ask in the contributors channel in our discord if you want more help.

from shuttle.

i will use clap macros for mutual exclusion
okay, Thanks

from shuttle.