[Bug Report] Crash on ERB containing multiple CDATA blocks about packwerk HOT 7 CLOSED

Thank you for this bug report and tracing it upstream to better_html!

from packwerk.

@remvee

Thanks for the bug report. Since parsing ERB files with CDATA blocks is currently unsupported, I wonder if an initial stopgap for us for now would be to catch this particular error and ignore ERB files with CDATA blocks. Later, as needed, we can decide to investigate other approaches (different parser, changes to better_html, etc.). Does this sound reasonable to you? I figure this would be an improvement since it unblocks you to use packwerk (and anyways packwerk already has a lot of areas where it doesn't capture all references between packages).

from packwerk.

I think a temporary workaround may make sense as it seems that the underlying bug is in html_tokenizer (https://github.com/EiNSTeiN-/html_tokenizer/pull/7) and that repo doesn't look like it's maintained.

from packwerk.

from packwerk.

@remvee I've attempted to fix this here: #214

Let me know what ya think!

I think it makes sense to keep this open to make it clear we don't yet support parsing ERB with CDATA tags.

from packwerk.

from packwerk.

It should be fixed now in the version 2.0 of better_html.

from packwerk.