Comments (1)
Hi @jibeizhao ! Thanks for your question.
A lot has changed since that video and blog post were produced. As of Packwerk 3, privacy enforcement has been moved to https://github.com/rubyatscale/packwerk-extensions. If you have issues with privacy enforcement specifically, that would be the best place to get help.
That being said – the issue here is that dependency and privacy violations are totally independent.
- Packwerk thinks something is a privacy violation if you’re referencing a constant/class/module defined in the private implementation (i.e. not the public folder) of another pack
- Packwerk thinks something is a dependency violation if you’re referencing a constant/class/module defined ANYWHERE but your pack doesn’t list it as an explicit dependency.
In this case, making something public can resolve a privacy violation, but has no effect on dependency violations. Dependency violations will show up if you reference a constant (public OR private) but do not list a dependency on the package that defines that constant.
from packwerk.
Related Issues (20)
- [Bug Report] Stale violations on deleted files HOT 1
- [Bug Report] - Packwerk::NodeHelpers::TypeError HOT 3
- [Bug Report] deprecated_references.yml files erroneously removed if running `packwerk update-deprecations` with the `--package` argument
- [Bug Report] Behaviour of enforce_dependencies: key missing HOT 1
- [Bug Report] Improve strict mode HOT 2
- [Bug Report] Insufficient release notes HOT 2
- [Bug Report] packwerk is disabling Sorbet runtime checks, globally on Spring
- [Bug Report] Disable sorbet when using spring
- [Feature Request] Detect stale todos HOT 1
- [Bug Report] Exception when loading signatures
- [Bug Report] Default require behaviour
- [Feature Request] Allow configuration of `package_todo.yml` violation destinations HOT 4
- [Feature Request] Separate run-time and test-time dependencies HOT 11
- [Bug Report] HOT 2
- [Bug Report] bundler: failed to load command: packwerk HOT 1
- [Bug Report] Getting "There were stale violations found, please run `packwerk update-todo`" even there is no stale violations HOT 3
- [Bug Report] has_many relationship for serializers create false positive violations HOT 1
- [Bug] resolve module namespaces HOT 4
- [Feature Request] Haml support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from packwerk.