shon / converge Goto Github PK

These methods ensure that the file is properly and safely opened and closed.

Developer starts a converge enabled app pointing to a git repo where the configs are stored. Converge will pull the settings file from that repo and loads the app configuration.

cc: @rohitkrai03

I am thinking of sending a PR for this. .convergerc file will contain extra parameters like folder, app_mode and server. From theses params converge will automatically import appropriate settings.py file. Does it make sense?

Set up a continuous integration service like Travis CI which checks if all the tests pass or not.

Some thoughts

• Currently on every import converge fetches git repo, which might may not be desired
• Updating git settings should be explicit
• There can a function with CLI wrapper that updates local settings
  • converge update
    $ <git output>
    $ warnings/ success messages

Questions

• Should we backup previous settings dir?
• If update fails shall we restore previous settings?

There are few unused imports in setup.py[1] & tests.py[2]

1. converge/setup.py

   Line 2 in de7893d

   import sys

2. converge/tests.py

   Line 76 in de7893d

   from converge import settings

An assignment is done on a function call but the inferred function doesn’t return anything.

1. converge/converge/settings.py

   Line 107 in de7893d

   rc_config = parse_osenv(rc_config_default)

We can run black, it would take care of the code formatting part and would keep code clean.