The embedo from shobhitsharma

tutorial please

sir, i'm having problem in using embedo for my project... because i'm a bit confused about how to use it... so it would be really helpful for me if you tell me how and where to define the facebook or any other link to get the results shown on the site... i will be waiting for you to respond... thanks

Instagram height

Hello

there a way to "auto height" instagram embed url ?

Thank !

Support for oembed discovery?

It appears there's no support for oembed discovery?

For example, flickr URLs do not appear to be supported - although flickr provides <link rel="alternative"> tags on their pages with oembed (in JSON and XML formats) discoverable.

Is this "by design"?

Instagram CORB

Hi, I'm trying to implement this library, but ran into problems with Instagram.
Instagram example also does not work on your Codepen, so I was wondering if there is a way to get around this:

Thanks!

Crash with soundclound

adding new providers? (sproutvideo)

How would I go about adding a new provider?

In particular I was interested in adding support for SproutVideo. Here is an example of how embedly does it:

https://embed.ly/code?url=https%3A%2F%2Fcooking-show.vids.io%2Fvideos%2Fa49ddeb31a1be4c42c%2Fclassic-cooking-lessons-hosting-a-dinner-party

Twitter Embed doesn't work

It seems that twitter embed doesn't work. It happens on https://shobhitsharma.github.io/embedo/ to.

embedo dosen't work now, FB/IG seemd change the API

hi I find fb update their API, so could you upgrade base on the new version?
FYI https://developers.facebook.com/docs/instagram/oembed-legacy/

thanks a lot

Youtube allow fullscreen

Is it possible to enable the fullscreen button in youtube embedded video's? Since it does not seem to be possible according to the code, if I read it correctly.

Preview embed disappears on website

Embedo library seems pretty cool, although the preview on the website doesn't seem to work very well... At least not on Chrome browser that I tried on. When I enter the URL of say http://twitter.com/jonmalave the preview renders the width OK, but doesn't render the height correctly, then within seconds disappears. So it's not allowing me to preview what the embed would look like really...

VK Embed Post

Will you add VK posts?

Support setting embed options from oembed APIs

CodePen embedo - React Component isn't ok

This package is fantastic. It's what I was looking for.

Please, correct the usage link "Codepen - Using with React" (https://codepen.io/shobhitsharma/pen/prOGzd). It shows a blue screen.

The other link, https://codepen.io/shobhitsharma/pen/yojJZp, is ok.

Regards.

Possibility to add feed?

Hi,

so far so good. I like the codebase quite a lot and like how easy it actually is, compared to go to each social network and generate the thing and copy their cough shitty code.

Is it possible or planned, that it will also generate whole feeds? For example, when loading in only a pages URL or users URL.

Error in pinterest handler

If the pinistrify function, handlePinterestEmbed makes this check:

embedo/embedo.js

Line 1593 in 46c7821

} else if (pinterest_embed_timer >= 100) {

pinterest_embed_timer is an interval ID, so you'll always get an error, even if the embed is successful, if the ID pool is over 100 (pretty common, especially in SPA).

I'm not sure what this is supposed to be checking, but even if you use a counter here instead, 100 * 250ms (25 seconds) seems too long. Something like 20, or 5s total, would be more reasonable.

Also, I'm reasonably certain that the setInterval call here:

embedo/embedo.js

Line 1578 in 46c7821

var pinterest_embed_timer = setInterval(handlePinterestEmbed, 250);

should be inside the setTimeout after the if block containing the PinUtils.build call:

embedo/embedo.js

Lines 1580 to 1584 in 46c7821

    
           setTimeout(function () { 
        
             if (!childNode.querySelector('[data-pin-href]')) { 
        
               window.PinUtils.build(childNode); 
        
             } 
        
           }, 750);

(after line 1583)

My changes here https://github.com/nborko/embedo/blob/865fcbe1da62467a333d31838541c39861294c48/embedo.js#L1578-L1598 work for me, please let me know if you'd like a PR.

thanks,
Nick

Support for Reddit?

Can you please add support for Reddit?
It uses the following url:
https://embed.redditmedia.com/widgets/embed?url=
I couldn't find any official documentation for it.

TypeError while executing in phantomjs

Stack

TypeError: undefined is not a constructor (evaluating 'n.find(function(i){return t.defaults.SOURCES[i]&&e.match(t.defaults.SOURCES[i].REGEX)?i:null})')

Cause

Running script in a headless browser plugin, either for scraping or mock test, caused this exception. Fixing buildscript while adding polyfills might solve it.

Direct HTML embedding doesn't work from 1.9.0 version

It just works for me

<html>
<body>
  <div data-embedo-url="https://www.youtube.com/watch?v=cwQgjq0mCdE"></div>
</body>

<script type="text/javascript" src="https://unpkg.com/[email protected]/embedo.min.js"></script>

<script>
  new Embedo({
    youtube: true
  });
</script>
</html>

Remove `PinUntils` build call which sometimes running twice

Reduce function calls expose global variable to queue pending requests

Server side rendering support

I started to migrate my embed rendering code to the server side recently and realized (i think) that embedo can only work on the client side.

Is that true? If so, is there a good recommendation of a tool (nodejs preferrable) as simple and easy to use as embedo that works on the server side?

thanks,
Cliff

how to replace the default css?

As title,
when i render it out, there are a default css there, it will run out of div.
<div id="embedo_arc5ry" data-embedo-id="embedo_arc5ry" data-embedo-source="facebook" style="display: flex; text-align: center; justify-content: center; align-items: center; margin: 0px auto; width: 750px; height: 500px;"><div class="fb-page fb_iframe_widget" data-href="https://www.facebook.com/facebook/" data-width="750" data-height="500" fb-xfbml-state="rendered" fb-iframe-plugin-query="app_id=1757323867855573&container_width=308&height=500&href=https%3A%2F%2Fwww.facebook.com%2Ffacebook%2F&locale=en_US&sdk=joey&width=750"><span style="vertical-align: bottom; width: 308px; height: 214px;"><iframe name="f3a93801707721c" width="750px" height="500px" frameborder="0" allowtransparency="true" allowfullscreen="true" scrolling="no" allow="encrypted-media" title="fb:page Facebook Social Plugin" src="https://www.facebook.com/plugins/page.php?app_id=1757323867855573&channel=https%3A%2F%2Fstaticxx.facebook.com%2Fconnect%2Fxd_arbiter.php%3Fversion%3D44%23cb%3Df2dee353410122%26domain%3Dlocalhost%26origin%3Dhttp%253A%252F%252Flocalhost%253A3000%252Ff344933bfc48d6c%26relation%3Dparent.parent&container_width=308&height=500&href=https%3A%2F%2Fwww.facebook.com%2Ffacebook%2F&locale=en_US&sdk=joey&width=750" style="border: none; visibility: visible; width: 308px; height: 214px;" class=""></iframe></span></div></div>
As html it render can see that element id : embedo_arc5ry
has css display: flex; text-align: center; justify-content: center; align-items: center; margin: 0px auto; width: 750px; height: 500px;
how can i change it?

	setTimeout(function () {
	if (!childNode.querySelector('[data-pin-href]')) {
	window.PinUtils.build(childNode);
	}
	}, 750);

shobhitsharma / embedo Goto Github PK

embedo's People

Contributors

Stargazers

Watchers

Forkers

embedo's Issues

Recommend Projects

Recommend Topics

Recommend Org