shkoliar / magento-grid-colors Goto Github PK

Hi there,

I've just installed this extension on a Magento 2 development site running on Magento 2.3.5

When I first installed it, it seemed to work, but since I've done a full deployment to production mode the sales order grid just doesn't appear even though the page says that there are x number of rows. I get the following javascript error: TypeError: undefined is not an object (evaluating 'mode.template'). When I swap back to developer mode, I still get the same problem.

I've tried to debug the code and was wondering if it may be a clash with the Magento_AsynchronousOperations module which seems to extend the grid listing component itself.

Do you know if this extension has been tested on Magento 2.3.5 with the Magento_AsynchronousOperations module enabled ?

Any help would be much appreciated.

Kind regards

Mark

Greetings!

As the title is self explanatory, I will proceed with my findings from the brief investigation I had so far.

I believe that the issue stems from inside shkoliar/magento-grid-colors/view/adminhtml/web/js/grid/controls/colors.js, more specifically this part:

            storageConfig: {
                namespace: 'current',
                provider: 'ns = ${ $.ns }, index = bookmarks'
            }

As when this part is refactored to:

            storageConfig: {
                name: '${ $.name }_storage',
                provider: 'ns = ${ $.ns }, index = bookmarks'
            },

selected filters on Default View do get correctly rendered and applied upon reload, but the issue with this approach seems to be that this:

no longer appears upon color selection, but it does appear after filter selection, so if someone doesn't need any filters applied on their custom grid view, just colors, they won't have the option to save the colors to their custom grid view, as it seems like colors aren't getting saved upon selection (not sure why, but I assumed that this should be the case, to behave in the same way upon filter selection), only when the 'Save View as' is clicked.