PHP highlighting not working about shiki HOT 8 CLOSED

So i've tested in VScode and it works correctly. I found these issues related to it:

microsoft/vscode#14166
microsoft/vscode#16502

So i'm not sure why it doesn't work here. I think maybe because the actual grammar file is not the same as the one used by vscode?

from shiki.

I think the behavior is consistent with VS Code:

from shiki.

@octref It works if you do it in markdown on VSCode though.

from shiki.

I can only allow 1 PHP grammar. If I change it, people who has written <?php in their PHP code would complain to me why it's not syntax highlighted correctly.

from shiki.

Unless I'm missing something, wouldn't it be more versatile to use the markdown version of PHP as the 1 PHP grammar? Appending <?php still works for me, so it should still be supported for people who are using it.

from shiki.

Seems working in 0.2.0:

from shiki.

You're the man, @octref! Big thanks for all of your hard work in OSS!

from shiki.

Awesome job, thanks @octref 👍

from shiki.