Comments (3)
Give that this would be a massive breaking change, it probably shouldn't happen this way unless it ends up in the 1.0 changes in #424 and is very well documented
Perhaps passing null could be accepted as the theme and have this behavior instead
from shiki.
I agree that removing the logic here directly may produce incompatible changes, although the documentation doesn't explicitly mention that the default theme will be loaded, it may be the default behavior when the user relies on not passing theme
.
If, as you say, we remove the loading of the default theme when the user is shown using theme: null
or themes: null
, would this be acceptable as a patch version of v0.14
?
from shiki.
Sure, allowing specifically for null is something I'd be OK with merging (as long as that's documented in the jsdoc)
from shiki.
Related Issues (20)
- How do you add Twoslash highlighting when importing .vue files in a project built with Vitepress? HOT 1
- WASM usage with getHighlighterCore errors with Buffer.isBuffer (this doesn't exist in the browser) HOT 4
- Shiki types are broken on non-DOM projects, again... HOT 4
- Need Urgent Help with NextJS 14 and Monaco-Editor/React HOT 1
- @shikijs/monaco several themes that TypeError
- Content-Security-Policy issue - inline styles HOT 4
- "ts-twoslash" support vitepress "Import Code Snippets"
- shiki transformer this.addClassToHast is not a function in astro HOT 3
- The `transformerRenderWhitespace` option in `@shikijs/rehype` doesn't work
- shiki-renderer-svg support HOT 2
- Color replacement in multiple theme modes HOT 3
- `@shikijs/vitepress-twoslash`: Use twoslash in the case of using imported code snippets. HOT 5
- Row of `language-*` on a single `code` element HOT 1
- Vue 当没有写 `template` 时无法正常高亮 HOT 1
- @shikijs/markdown-it: code block is wrong when entering a non-existent language HOT 2
- Twoslash node query blocks (^?) no longer display on separate lines since 0.x
- `remove-notation-escape`: notation escape syntax’s normalize transformer HOT 2
- Rehype: default language
- "TypeError: onigBinding.UTF8ToString is not a function" after some time / parallel requests in Next.js HOT 10
- Inconsistent behavior between `@shikijs/twoslash` and `@shikijs/vitepress-twoslash`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shiki.