Code Monkey home page Code Monkey logo

Comments (3)

orta avatar orta commented on August 24, 2024

Give that this would be a massive breaking change, it probably shouldn't happen this way unless it ends up in the 1.0 changes in #424 and is very well documented

Perhaps passing null could be accepted as the theme and have this behavior instead

from shiki.

kricsleo avatar kricsleo commented on August 24, 2024

I agree that removing the logic here directly may produce incompatible changes, although the documentation doesn't explicitly mention that the default theme will be loaded, it may be the default behavior when the user relies on not passing theme.

If, as you say, we remove the loading of the default theme when the user is shown using theme: null or themes: null, would this be acceptable as a patch version of v0.14?

from shiki.

orta avatar orta commented on August 24, 2024

Sure, allowing specifically for null is something I'd be OK with merging (as long as that's documented in the jsdoc)

from shiki.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.