Code Monkey home page Code Monkey logo

gerrit-cli's People

Contributors

shanesmith avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar

gerrit-cli's Issues

Command 'up' fails with gibberish error if branch's upstream is not a remote branch

gerrit ERROR UNKNOWN TypeError: Cannot read property '1' of null
gerrit ERROR   domain: {"domain":null,"_events":{},"members":[]}
gerrit ERROR   domainThrown: true
gerrit ERROR     at Object.git.branch.parsedUpstream (/usr/local/lib/node_modules/gerrit-cli/lib/git.js:271:24)
gerrit ERROR     at /usr/local/lib/node_modules/gerrit-cli/lib/gerrit.js:281:33
gerrit ERROR     at bound (domain.js:254:14)
gerrit ERROR     at runBound (domain.js:267:12)
gerrit ERROR     at tryCatcher (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/util.js:26:23)
gerrit ERROR     at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:503:31)
gerrit ERROR     at Promise._settlePromiseAt (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:577:18)
gerrit ERROR     at Promise._settlePromiseAtPostResolution (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:244:10)
gerrit ERROR     at Async._drainQueue (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/async.js:128:12)
gerrit ERROR     at Async._drainQueues (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/async.js:133:10)
gerrit ERROR     at Immediate.Async.drainQueues [as _onImmediate] (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/async.js:15:14)
gerrit ERROR     at processImmediate [as _immediateCallback] (timers.js:358:17) 

ability to obtain list of pending reviews from all gerrit servers

It would extremely useful if gerrit CLI could list all patches from all servers that were raised by you. As we already have all servers and usernames this should be possible without further configuration.

I currently work with 3 different Gerrit servers and when you have multiple open reviews is very easy to forget about some that needs your attention. If we could be able to check this via the command line it would be a huge productivity booster.

gerrit up --assign doesn't work with multiple commits in topic

Expected: all commits are pushes and assigned to the reviewer

Observed: Command fails with the following error stack. No commits are pushed to gerrit

$ ger up --assign reviewer
More than one patch detected.
? Assign reviewers to all patches being pushed? (Y/n) gerrit WARN Aborting.
gerrit ERROR UNKNOWN Error: undefined
gerrit ERROR domain: {"domain":null,"_events":{},"members":[]}
gerrit ERROR domainThrown: true
gerrit ERROR at Object.ensureErrorObject (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/util.js:261:20)
gerrit ERROR at Promise._rejectCallback (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:465:22)
gerrit ERROR at Function.Promise.reject.Promise.rejected (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:195:9)
gerrit ERROR at /usr/local/lib/node_modules/gerrit-cli/lib/cli.js:724:18
gerrit ERROR at bound (domain.js:254:14)
gerrit ERROR at runBound (domain.js:267:12)
gerrit ERROR at tryCatcher (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/util.js:26:23)
gerrit ERROR at Promise._settlePromiseFromHandler (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:503:31)
gerrit ERROR at Promise._settlePromiseAt (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:577:18)
gerrit ERROR at Promise._settlePromises (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/promise.js:693:14)
gerrit ERROR at Async._drainQueue (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/async.js:123:16)
gerrit ERROR at Async._drainQueues (/usr/local/lib/node_modules/gerrit-cli/node_modules/bluebird/js/main/async.js:133:10)
gerrit ERROR at Immediate.Async.drainQueues as _onImmediate
gerrit ERROR at processImmediate as _immediateCallback
? Assign reviewers to all patches being pushed? Yes

gerrit do not seem to work with Ubuntu 14.04

After installing gerrit on Ubuntu 14.04

It seems like gerrit does not work, it simply return (or terminate) when invoke from the command line with no information

For example:

gerrit config

(It doesn't prompt me for the configuration information)

Did you came out with any solution to add inline comments on a patch?

Given the diff output

commit 5234efaf57b4fac96da75eca554da021 (HEAD, origin/master)
Author: albfan <[email protected]>
Date:   Thu Apr 19 11:43:36 2018 +0000

    My commit

diff --git a/file b/file
index ff249e2..30c8d10 100644
--- a/file
+++ b/file
@@ -4,7 +4,7 @@
        aasdfa
        wertwer
        wetrgsd
-       hello
+       bye
        tryuryt
        rtyurty
        rtyurtuy
diff --git a/foo b/foo
index 1adb588..cd374ea 100644
--- a/foo
+++ b/foo
...
@@ -9,7 +9,7 @@

did you came out with any format to add inline comments?

gerrit squad should post help

When trying command gerrit squad, currently just says "missing arguments". Should probably be an alias for gerrit help squad.

Assigning multiple reviewers sometimes fails

When assigning multiple reviewers to a patch by either listing all the names or using a squad, some of the reviewers will sometimes not be assigned and a warning will be shown notifying they weren't assigned.

Permission denied (publickey)

Hello, looks like I need some help with initial configuration :)

What ssh key is used by default?
And where these configs are stored?

gerrit config -a
name = default
host = [ 'localhost' ]
user = [ 'jenkins' ]
port = [ '29418' ]
gerrit clone playground

Cloning project playground from default config into folder playground...
Cloning into 'playground'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
(node:70212) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.
gerrit ERROR There was an error running a git command
gerrit ERROR   command: 'clone' '--progress' 'ssh://[ 'jenkins' ]@[ 'localhost' ]:29418/playground.git' 'playground'
gerrit ERROR   output:
gerrit ERROR   error: Cloning into 'playground'...
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
gerrit ERROR   code: 128
cat ~/.ssh/config

host *localhost*
hostname 192.168.0.10
User jenkins
Port 29418
TCPKeepAlive yes
IdentityFile ~/.ssh/id_rsa
git clone --progress ssh://jenkins@localhost:29418/playground.git

Cloning into 'playground'...
remote: Counting objects: 65, done
remote: Finding sources: 100% (65/65)
remote: Total 68 (delta 22), reused 68 (delta 22)
Receiving objects: 100% (68/68), 7.44 KiB | 0 bytes/s, done.
Resolving deltas: 100% (22/22), done.
Checking connectivity... done.

gerrit up fails to un-draft

Pushing draft then following with a gerrit up fails with the following output.

? Topic "AddressBook" was previously saved as a *draft*, are you sure you want to un-draft it? Yes
Pushing to origin (refs/for/master/AddressBook)
remote: Resolving deltas: 100% (7/7)           
remote: Processing changes: refs: 1, done            
To ssh://user@server/repo
! [remote rejected] HEAD -> refs/for/master/AddressBook (no changes made)
error: failed to push some refs to 'ssh://user@server/repo'
gerrit ERROR Error while pushing commit.

Workaround was to amend my commit before trying to upload it.

gerrit version 0.1.0

Have ninja mode work with multiple commits in a topic

When using ninja mode with multiple commits in a topic, all the commits get pushed to gerrit but then the command chokes on the review part because there are more than one commit and suggests the using the interactive option.

Would be nice if it just worked silently

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.