Comments (6)
Sorry forget the above fix, the version setting is on the connect message not the unsubscribe message, we should get the connect message to update the Protocol also -
/// Sets the name of the protocol to use.
MqttConnectMessage withProtocolName(String protocolName) {
variableHeader!.protocolName = protocolName;
Protocol.name = protocolName;
return this;
}
/// Sets the protocol version.
MqttConnectMessage withProtocolVersion(int protocolVersion) {
variableHeader!.protocolVersion = protocolVersion;
Protocol.version = protocolVersion;
return this;
}
from mqtt_client.
Yes you are correct, both methods should work, the problem is in the unsubscribe message -
void writeTo(MqttByteBuffer messageStream) {
// If the protocol is V3.1.1 the following header fields
// must be set as below as in this protocol they are reserved.
if (Protocol.version == MqttClientConstants.mqttV311ProtocolVersion) {
We adjust the unsubscribe message header if the protocol is V311, however this checks Protocol, it should check the variable header -
if (variableHeader!.protocolVersion ==
MqttClientConstants.mqttV311ProtocolVersion) {
Also this comment is incorrect -
/// Sets the protocol version. (Defaults to v3, the only protcol
/// version supported)
I'll fix this as well, thanks for reporting this.
from mqtt_client.
Thanks for the feedback Steve.
from mqtt_client.
Do you want a PR raised for the fix?
from mqtt_client.
No thanks, I've already raised one and incorporated the fix, see #452. I'll close this issue when I release the package at the next version with this in it.
from mqtt_client.
Incorporated into version 9.8.1
from mqtt_client.
Related Issues (20)
- How to add proxy to see content in proxy tools like Charles/Proxyman? HOT 1
- retain:true publishing issue (using IoT Core) HOT 3
- Differences in automatic reconnection between IOS and Android HOT 1
- '400 Bad Request' response while connecting with websocket to rabbitmq HOT 3
- How to connect mqtt with socket header options? HOT 3
- mqttjs:client _checkPing :: checking ping... Runs twice in rapid succession some times HOT 1
- How to determine the cause of the disconnect? HOT 1
- Available bytes is less than the message size HOT 4
- error:Bad state: Cannot add new events after calling close HOT 8
- AWS IoT Certificate - Use .bks file certificate HOT 1
- NoConnectionException: Missing Connection Acknowledgement HOT 4
- Ping triggers client.update and brings the same message multiple times HOT 1
- How can I receive a complete offline message? HOT 1
- Unhandled Exception: mqtt-client::NoConnectionException: MqttWs2Connection::TLS connection unexpectedly closed HOT 15
- onDisconnect callback when autoconnect is false or onAutoReconnect callback when autoconnect is set to true not invoking immediately in ios when wifi is turned off HOT 2
- Review outdated packages in version 10.3.0 HOT 1
- Parsing problems for web socket URLs HOT 2
- How can i subscribe multi topic? HOT 2
- CERTIFICATE_VERIFY_FAILED: unable to get local issuer certificate HOT 4
- Dependency Resolution Failure after upgrading to 10.4.0 HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mqtt_client.