sh0rez / luxtronik2-exporter Goto Github PK

It seams to confuse table headers with real data.
Here are some examples of errors it gives and a screanshot of heatpump webpage:

panic: descriptor Desc{fqName: "luxtronik_chybova-pamet", help: "", constLabels: {}, variableLabels: [attr]} is invalid: "luxtronik_chybova-pamet" is not a valid metric name

panic: descriptor Desc{fqName: "luxtronik_doby-chodu", help: "", constLabels: {}, variableLabels: [attr]} is invalid: "luxtronik_doby-chodu" is not a valid metric name

panic: descriptor Desc{fqName: "luxtronik_status-zarizeni", help: "", constLabels: {}, variableLabels: [attr]} is invalid: "luxtronik_status-zarizeni" is not a valid metric name

Add config file (using viper) to set the following:

• luxtronik ip
• filters
• slug language

Allow to specify domain-fields to ignore parse errors. reduces log bloat

Logs are not getting escaped properly:
time="2018-12-15T22:20:59Z" level=warning msg="metric value parse failure" domain=betriebsstunden field=betriebstunden-heiz value="{"value":"277h"}"
The unescaped json breaks fluent-bit logfmt parser

Please add just a little documentation, on how to run the exporter
I use Docker and had to look into your code to find out, on which port it is exposed and in which folder it expects the config.

e.g.

Docker Setup

• Mount volume "/lux" to your local folder, where the "lux.yaml" file is
• Map internal Port 2112 to whatever port you like

Access via :/metrics

$ go run main.go
command-line-arguments
./main.go:93:2: undefined: mutes
./main.go:93:15: undefined: MuteList
./main.go:95:3: undefined: mutes
./main.go:95:14: undefined: Mute
./main.go:159:7: undefined: mutes

And:

$ go version
go version go1.15.15 linux/arm64

I'm happy to help debug the issue.