Thanks for this useful module.

Here is a feature request:
Generate a list of holiday names and being able to check if a particular date is a holiday by it's name.

In the npm package the region 'AUGSBURG' is missing from the index.d.ts types.

So the typescript transpiler will throw an error when trying to use AUGSBURG as region.

Workaround: Cast 'AUGSBURG' to Region:

isSunOrHoliday(myDate, 'AUGSBURG' as Region)

Issue:

Holiday 'Pfingstsonntag' is missing 'Hessen' state

Hint: in Holidays[] array it called 'PFINGSTSONNTAG'

Description:

Checked your implementation and looks like one more state for holiday 'Pfingstsonntag' is missing

https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland

Hey there,

thanks again for adding the regions array. It seems like there has been added a little bug for "WELTFRAUENTAG". This holiday is only for Berlin and Mecklemburg-Vorpommern, but regions are returning "ALL"

{ "name": "WELTFRAUENTAG", "date": "2024-03-07T23:00:00.000Z", "dateString": "2024-03-08", "regions": [ "BW", "BY", "BE", "BB", "HB", "HE", "HH", "MV", "NI", "NW", "RP", "SL", "SN", "ST", "SH", "TH", "BUND", "ALL" ] }

I guess there happened to be a mistake in line 403 and 407 within your feiertage.ts file: feiertageObjects.push(newHoliday('WELTFRAUENTAG', makeDate(year, 3, 8), ['ALL']));

There could be also more holidays affected. F.e. "WELTKINDERTAG".

For "REFORMATIONSTAG" the validRegions List includes NI twice:

const validRegions: Region[] = [ 'NI', 'BB', 'MV', 'SN', 'ST', 'TH', 'HB', 'HH', 'NI', 'SH', ];

Every date matches, but the Buß- und Bettag is wrong...

date:Wed Oct 04 2017 00:00:00 GMT+0200 (CEST) name:"BUBETAG"

tried it with different years but it is always wrong.
(Buß- und Bettag is only in Saxony!)

Issue:

Holiday 'Reformationstag' is missing 'Schleswig-Holstein' state

Hint: in Holidays[] array it called 'REFORMATIONSTAG'

Description:

Checked your implementation and looks like one more state for holiday 'Frauentag' is missing

https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland

bower ENOTFOUND Package feiertagejs not found

npm install is working fine.

Issue:

Holiday 'Frauentag' (eng. women's day) is missing 'Mecklenburg-Vorpommern' state

Hint: in Holidays[] array it called 'WELTFRAUENTAG'

Description:

Checked your implementation and looks like one more state for holiday 'Frauentag' is missing

https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland

From the examples:
var holidays2018 = feiertagejs.getHolidays('2018', 'BUND');
try this for 2017:
var holidays2017 = feiertagejs.getHolidays('2017', 'BUND');
and get missing REFORMATIONSTAG.

Solution:
Write year as number:
var holidays2017 = feiertagejs.getHolidays(2017, 'BUND');
or better change code:
if (year === 2017 || ...
to:
if (year == 2017 || ...

Hey,
first of all thank you, for that incredibly useful library. It is a pleasure to us it.
I would like to ask you to add another holiday to the library. It is Weltfrauentag, on 8th of March and it is a holiday that is only in Berlin. It it will be holiday for the first time this year. Thank you.

Hi,

According to Wikipedia, this holiday should be in 9 states since 2018 (https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland), but after digging through the code, it seems that Schleswig-Holstein (SH) is not counted for this holiday.

Please take a look when you have time.

Thanks!

Hey,

I just want to remark that the property "regions" seems to be missing for the type Holiday.

In my case i noticed it when using const holiday = getHolidaysByDate(date,region) that the property "regions" is missing.

Hamburg also has the Reformationstag. Probably needs to be added here: https://github.com/sfakir/feiertagejs/blob/master/src/feiertage.ts#L313

It would be handy, if getHolidays() and getHolidayByDate() could return an array with regions if someone calls those functions with region ALL.

The type Holiday could be extended like so:

name: HolidayType
date: date
trans: func
dateString: string
equals: func
regions: array

It can be important to know, in with region this date is a holiday without calling isHoliday(date, region) for all regions.

You forgot to add HH to your validRegions-Array

Works isSpecificHoliday with any date?
isSpecificHoliday(new Date('2021-12-25T09:30:00.000+01:00'), 'CHRISTIHIMMELFAHRT', 'ALL')

returns true. I was expecting it returns false.

Hi
the public holiday "Frohnleichnam" Easter Sunday + 60 is missing.
do you mind adding it in?

There already exists getHolidays that returns an array with all holidays of a year. Can you please add a method to get the holiday name of one date?

Hi,

bei der Funktion für Maria Himmelfahrt steht region == 'SL' || region == 'ALL'.
Da das nur in Bayern und Saarland ein Feiertag ist müsste wohl statt ALL ein BY hin.

Hey,

I came across a bug where isHoliday caused an error. It actually changed my time, so I had to pass a copy of my dateObject.

The reason probably is here:

function toUtcTimestamp(date: Date): number {
  date.setHours(0, 0, 0, 0);
  return date.getTime();
}

Maybe you shouldnt use setHours on the passed date but return a new Date():

function toUtcTimestamp(date: Date): number {
  let tmpDate = new Date(date);
  tmpDate.setHours(0,0,0,0);
  return tmpDate.getTime();
}

Kind Regards

Seems like lots of things have happened and the api changed. Also typescript definitions were added. Would be great to have those things published :) 🚀

Hi
The Public Holiday 'Reformationstag' is missing for Hamburg and Bremen can you please add it

When using DateJs together with feiertagejs, some of the DateJs functions seem to stop working. For example:

Date.today().add(1).day(); // -> undefined when using with feiertagejs

Is there a way to use both libraries together? Thanks.

What is "BUND" in Region documentation?

From wiki which were mentioned in documentation :
https://de.wikipedia.org/wiki/Land_(Deutschland)#Amtliche_bzw._Eigenbezeichnungen

hello,
in Version 0.1.1 there were some false postives, due to the internal representation of the date.
The new version 0.1.2 moved to UTC timestamps, which passes now all the tests.

Please check if you have the latest version!!

Issue:

Holiday 'Ostersonntag' is missing 'Hessen' state

Hint: in Holidays[] array it called 'OSTERSONNTAG'

Description:

Checked your implementation and looks like one more state for holiday 'Ostersonntag' is missing

https://de.wikipedia.org/wiki/Gesetzliche_Feiertage_in_Deutschland

on react/next.js with typescript I run into this error on version 1.3.6:

Attempted import error: 'isHoliday' is not exported from 'feiertagejs' (imported as 'isHoliday').

when importing like this:

import { isHoliday } from "feiertagejs";

isHoliday is then undefined.

a rollback to 1.3.5 solved the issue for me

The npm badge shows the npm version of another package (async) but it should show the version of this package