sf-bitcoindevs / bitcoinjslib-wallet Goto Github PK

I would like to recommend to remove this file https://github.com/SF-Bitcoindevs/bitcoinjslib-wallet/blob/master/js/helloblock.js

And replace with the official client lib which is maintained actively. https://github.com/helloblock/helloblock-js

It is best to use the client lib as it is well tested and covers every single endpoint.

Miner fee is currently fixed at 0.0005. The miner fee should be editable so that users can choose any fee they wish.

I am not sure what "DECRYPT YOUR WALLET PASSPHRASE" is supposed to do for this design of the web wallet.

I think for the SF Bitcoin dev wallet, we should leave the basic functionality of carbon wallet. Password management for decryption is really something for the DTT product which may be out of scope for this general project. Thoughts?

Presumably you don't want those available after logout.

Question: Should

  this.getUnspentOutputs = function(address, callback) {
      var url = 'https://mainnet.helloblock.io/v1/addresses/'';

Really be using the Helloblock get unspents url
like so:

  this.getUnspentOutputs = function(address, callback) {
      var url = 'https://mainnet.helloblock.io/v1/addresses/'+ address + '/unspents?limit=1';

Uncaught ReferenceError: HBlock is not defined /Users/taariqlewis/JavaScript_Projects/dttgold/wallet/js/wallet.js:40

http://127.0.0.1:8282/app.html?testnet=1

does not work with testnet coins. Only uses mainnet.

Hey @sidazhang how hard would it be for us to consider implementing P2SH in our wallet? I think it might be just too hard, but I thought I'd ask.

If @lkang is okay with the update, can we refactor all files into the src directory so we can clean up the directory structure?

Hey @SF-Bitcoindevs/owners,

Below is an outline for a Webinar to launch this HD Wallet with the SF Bitcoin Devs and Helloblock.io. Please comment on how we can make this better as I'd like to close on the agenda and launch a sign-up site for the event, this week.

Date: May 6, 2014
Time: 2PM - 3PM

1. Introduction to My Secure Bitcoin Wallet
2. What is the HD Wallet and what problem does it solve?
3. How to test bitcoin application development with Mainnet and Testnet
   a) Using HelloBlock to test and write bitcoin applications
4. A sample Application: The SF Bitcoin Dev Wallets branded for Tiger Direct
   a) Tiger Direct Cutomer Sign-up (12 passphrase)
   b) Tiger Direct Customer Payments (send and receive money)
   c) Tiger Direct customer coupons (branding)
5. Hosted Solutions for Merchants (Hosted customer wallets)
6. Special Offer: Free Hosted Branded Wallets for First 5 Merchants to call us.
7. Q&A

Send Payment totals rounds up in the display so that the total is incorrect.

Do we need to remove this directory manually?

I Added me some test Faucet Coins! Woo hoo!
Got me 0.0003 Bitcoins
Then clicked "Make a Payment Button"
But my Source Address for my test faucet coins shows a 0.00 Balance.

As a user, I want to see my current balance on my bitcoin address when I go to make a payment so that I can use the appropriate balance that I want from the appropriate address.

We want to remove the Passphrase reminder and encrypted link as it's a security risk and is broken given that carbonwallet is not hosting services for this wallet.

When I click "Make a Payment" the balance on my Source address is not current balance.

Using testnet. Open wallet about 3x so my testnet balance increases to 0.0156. However, my balance still says 0.003 which was my first balance when I created the wallet.

https://gist.github.com/dcousens/7a54e59a98e445c5ec2f

Hey Srirarm. the HTML in app.html looks like it's lost all its formatting and is now fed as one whole block of text. Is this because of Jade? Can we revert back to clean looking html in the app.html file?

When I click "Make a Payment" after sending a transaction, the details from the last payment are still in the form and could be erroneously used to resend the prior transaction.