seuwangcy / imagestack Goto Github PK

When building on Linux (Ubuntu 12.04) with gcc 4.6.3 I get this error:

src/FilePNG.cpp: In function ‘ImageStack::Image 
ImageStack::FilePNG::load(std::string)
src/FilePNG.cpp:25:13: error: variable ‘number_of_passes’ set but not used 
[-Werror=uned-but-set-variable]

Removing -Werror from the BIN_CCFLAGS in Makefile.linux fixes the problem.

David

It would be nice to include a dog1_mask.png in the pics/ folder, and then make 
the usage: line read:

ImageStack -load dog1_mask.png -load dog1.png -inpaint -save dog1_inpainted.png

What steps will reproduce the problem?
1. Load more than 8 of these 16 images: 
http://danreetz.com/for_imagestack/CasioImageStackEffort.zip
2. Use command: ImageStack -loadframes (image list).JPG -alignframes 
perspective -sort t -crop 0 0 frames/2 width height 1 -save Test2.jpg
3. Wait for error.

What is the expected output? What do you see instead?
Because ImageStack crashes at the "warping" stage, I never get output from 
-display or -save.

What version of the product are you using? On what operating system?
Using ImageStack.2010-7-31-win64 on Windows 7 64 Bit. 4GB RAM, Athlon 955 Black 
Edition, multiple terabytes of disk, running with administrative privileges.

Please provide any additional information below.
 Problem Event Name:    APPCRASH
  Application Name: ImageStack.exe
  Application Version:  0.0.0.0
  Application Timestamp:    4c54a0c2
  Fault Module Name:    ImageStack.exe
  Fault Module Version: 0.0.0.0
  Fault Module Timestamp:   4c54a0c2
  Exception Code:   c0000005
  Exception Offset: 0000000000001111
  OS Version:   6.1.7600.2.0.0.256.1
  Locale ID:    1033
  Additional Information 1: 06c0
  Additional Information 2: 06c0589b2c0fa76d870e69d536132946
  Additional Information 3: 2d4e
  Additional Information 4: 2d4eca91e365c87cbe2c5ae9204aba94

I realize this is the wrong place for a question, but can I enable more verbose 
debugging output somehow?

What steps will reproduce the problem?

1. bin/ImageStack -help fastnlmeans

What version of the product are you using? On what operating system?
HEAD


Please provide any additional information below.

svn diff 

Index: src/GaussTransform.cpp
===================================================================
--- src/GaussTransform.cpp  (revision 240)
+++ src/GaussTransform.cpp  (working copy)
@@ -946,7 +946,7 @@
             " spatial search sizes. The three arguments are the patch size, the"
             " spatial standard deviation, and the patch-space standard deviation.\n"
             "\n"
-            "Usage: ImageStack -load noisy.jpg -fastnlmeans 2 3 0.1 -save 
denoised.jpg");
+            "Usage: ImageStack -load noisy.jpg -fastnlmeans 2 3 0.1 -save 
denoised.jpg\n");
 }

 bool FastNLMeans::test() {

For users who plan to use your code from a project using CMake, it might be 
nice to provide a CMakeLists.txt to get them started. I was able to build 
ImageStack on Ubuntu 12.04 using the attached CMakeLists.txt files (one in the 
root directory of ImageStack and the other in the src/ directory).

This is also nice simply for producing an out-of-source build of ImageStack.

Thanks,

David

Line 533 in File.cpp lists:

int header[] = {width, height, frames, channels, 0};

but should be

int header[] = {frames, width, height, channels, 0};

to be consistent with the loading function in fileTMP.


Whilst I think ImageStack is great, in this case I feel that the header 
structure should be declared in one place rather than in lots of different 
function which would prevent this sort of bug in the event that the header is 
changed, etc..

Anyway, just a slight bug that should be trivial to fix

Thanks for the great work

Hi:  I don't know whether you even want these.

What steps will reproduce the problem?
1. imagestack -loadframes foo*.jpg

What is the expected output? 
I expected it to load a sequence of frames from the files (foo0001.jpg , 
foo0002.jpg, ...)

What do you see instead?
Performing operation -loadframes foo*.jpg
Could not open file foo*.jpg


What version of the product are you using? On what operating system?
imagestack version 2010-7-31 Win64
on 64bit Win7

Please provide any additional information below.
Perhaps sequence loading is not yet implemented in LoadFrames::parse()?

linux system, latest svn clean checkout.

For colored images, I'd expect this to turn the image (all channels) into a 
monocrhome image based on the value being set (ie all values above this to to 
100%, all values below go to 0).

The behavior seems to be almost works, however, I end up with some color 
remaining.   Tested images are all large PNG's , ie imagemagick reports this:

Image: test7.png
  Format: PNG (Portable Network Graphics)
  Class: DirectClass
  Geometry: 2592x3872+0+0
  Resolution: 72x72
  Print size: 36x53.7778
  Units: Undefined
  Type: TrueColor
  Endianess: Undefined
  Colorspace: sRGB
  Depth: 8-bit
  Channel depth:
    red: 8-bit
    green: 8-bit
    blue: 8-bit
  Channel statistics:
    Red:
      min: 0 (0)
      max: 228 (0.894118)
      mean: 107.723 (0.422441)
      standard deviation: 65.6952 (0.257628)
      kurtosis: -1.52917
      skewness: -0.475536
    Green:
      min: 0 (0)
      max: 209 (0.819608)
      mean: 107.004 (0.419624)
      standard deviation: 65.9809 (0.258749)
      kurtosis: -1.57422
      skewness: -0.442728
    Blue:
      min: 0 (0)
      max: 232 (0.909804)
      mean: 108.015 (0.423589)
      standard deviation: 67.426 (0.264416)
      kurtosis: -1.59933
      skewness: -0.412485
  Image statistics:
    Overall:
      min: 0 (0)
      max: 232 (0.909804)
      mean: 107.581 (0.421885)
      standard deviation: 66.3717 (0.260281)
      kurtosis: -1.56778
      skewness: -0.442582
  Rendering intent: Perceptual
  Gamma: 0.454545
  Chromaticity:
    red primary: (0.64,0.33)
    green primary: (0.3,0.6)
    blue primary: (0.15,0.06)
    white point: (0.3127,0.329)
  Interlace: None
  Background color: white
  Border color: srgb(223,223,223)
  Matte color: grey74
  Transparent color: black
  Compose: Over
  Page geometry: 2592x3872+0+0
  Dispose: Undefined
  Iterations: 0
  Compression: Zip
  Orientation: Undefined
  Properties:
    date:create: 2013-07-10T15:30:39-07:00
    date:modify: 2013-07-10T15:30:39-07:00
    png:cHRM                 : chunk was found (see Chromaticity, above)
    png:gAMA                 : gamma=0.45454544 (See Gamma, above)
    png:IHDR.bit_depth       : 8
    png:IHDR.color_type      : 2 (Truecolor)
    png:IHDR.interlace_method: 0 (Not interlaced)
    png:IHDR.width,height    : 2592, 3872
    png:sRGB                 : intent=0 (See Rendering intent)
    signature: 1efb0001b79a9ef8702ad89ea682e98e76f3f7baa55d94dcd14e8f8f3df1a803
  Artifacts:
    filename: test7.png
    verbose: true
  Tainted: False
  Filesize: 11.24MB
  Number pixels: 10.04M
  Pixels per second: 24.48MB
  User time: 0.420u
  Elapsed time: 0:01.410
  Version: ImageMagick 6.7.7-10 2012-11-06 Q16 http://www.imagemagick.org

What steps will reproduce the problem?
1. use "loadframes" to load a sequence of images
(ImageStack -loadframes 03289.jpg 03290.jpg 03291.jpg 03292.jpg 03293.jpg 
03294.jpg 03295.jpg 03296.jpg - still can't load more than 8 frames)

2. use -loop 7 --add to add the second to the first 7 times to add the stack 
together. 

3. Stack Underflow.

What is the expected output? What do you see instead?
Trying to use "add" to sum a bunch of images and then wish to divide the pixel 
values by the number of images, but add doesn't seem to want to be used on any 
more than two images.

Maybe I should just use eval?

What version of the product are you using? On what operating system?
win764, latest version of imagestack.

Checking out latest svn, compiling under Linux (debian wheezy) both opticalflow 
functions are missing.   They are documented in the docs/index.html to exist.