Comments (11)
tomoverlund
commented on July 18, 2024
1
I'm happy to report after moving:
mozjs/third_party/python/pyyaml/ to
mozjs/third_party/python/PyYAML/
and backing out your debugging statements in
mozjs/js/src/jit/GenerateCacheIRFiles.py
that mozjs builds and tests fine under Linux. All build and test commands in the README appear to work properly:
cargo build
cargo test
cargo build --features debugmozjs
cargo test --features debugmozjs
from mozjs.
jdm
commented on July 18, 2024
https://github.com/servo/mozjs/tree/smuppy2
from mozjs.
jdm
commented on July 18, 2024
Status: mac & windows non-debugmozjs builds succeed on CI. linux builds fail with:
--- stderr
Traceback (most recent call last):
File "/usr/lib/python3.8/runpy.py", line 194, in _run_module_as_main
return _run_code(code, main_globals, None,
File "/usr/lib/python3.8/runpy.py", line 87, in _run_code
exec(code, run_globals)
File "/home/travis/build/servo/mozjs/mozjs/python/mozbuild/mozbuild/action/file_generate.py", line 156, in <module>
sys.exit(log_build_task(main, sys.argv[1:]))
File "/home/travis/build/servo/mozjs/mozjs/python/mozbuild/mozbuild/action/util.py", line 18, in log_build_task
return f(*args, **kwargs)
File "/home/travis/build/servo/mozjs/mozjs/python/mozbuild/mozbuild/action/file_generate.py", line 87, in main
spec.loader.exec_module(module)
File "<frozen importlib._bootstrap_external>", line 783, in exec_module
File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
File "/home/travis/build/servo/mozjs/mozjs/js/src/jit/GenerateCacheIRFiles.py", line 8, in <module>
import yaml
ModuleNotFoundError: No module named 'yaml'
make[3]: *** [backend.mk:76: js/src/jit/.deps/CacheIROpsGenerated.h.stub] Error 1
mac/windows debugmozjs fails with:
rror[E0432]: unresolved import `jsapi::mozilla::detail::GuardObjectNotificationReceiver`
--> src/jsimpls.rs:25:5
|
25 | use jsapi::mozilla::detail::GuardObjectNotificationReceiver;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `GuardObjectNotificationReceiver` in `generated::root::mozilla::detail`
error[E0560]: struct `JSAutoRealm` has no field named `_mCheckNotUsedAsTemporary`
--> src/jsimpls.rs:168:13
|
168 | _mCheckNotUsedAsTemporary: GuardObjectNotificationReceiver {
| ^^^^^^^^^^^^^^^^^^^^^^^^^ `JSAutoRealm` does not have this field
|
= note: available fields are: `cx_`, `oldRealm_`
error: aborting due to 2 previous errors
from mozjs.
jdm
commented on July 18, 2024
rust-mozjs branch that passes tests locally on macOS: https://github.com/servo/rust-mozjs/pull/new/smuppy2
from mozjs.
jdm
commented on July 18, 2024
Windows rust-mozjs failure:
rror: failed to get `mozjs_sys` as a dependency of package `mozjs v0.13.0 (C:\projects\rust-mozjs)`
Caused by:
failed to load source for dependency `mozjs_sys`
Caused by:
Unable to update https://github.com/servo/mozjs?branch=smuppy2
Caused by:
failed to stat 'C:/Users/appveyor/.cargo/git/checkouts/mozjs-fa11ffc7d4f1cc2d/a94d666/mozjs/js/src/tests/test262/built-ins/Object/seal/object-seal-the-configurable-attribute-of-own-data-property-of-o-is-set-from-true-to-false-and-other-attributes-of-the-property-are-unaltered.js': The filename or extension is too long.
from mozjs.
tomoverlund
commented on July 18, 2024
linux builds fail with: ... ModuleNotFoundError: No module named 'yaml'
Looks to be a bug in version 84. The directory third_party/python/PyYAML/ does not exist, but is specified in build/common_virtualenv_packages.txt. It reappears in version 85, the latest package:
from mozjs.
tomoverlund
commented on July 18, 2024
Looks to be a bug in version 84. The directory third_party/python/PyYAML/ does not exist, but is specified in build/common_virtualenv_packages.txt. It reappears in version 85, the latest package:
Actually, I take this back. Looks like a case-sensitivity issue on Linux versus Windows. I guess you uploaded from Windows, which destroyed the required uppercasing on Linux.
from mozjs.
jdm
commented on July 18, 2024
@tomoverlund I'm not sure I understand - in the smuppy2 branch, mozjs/third_party/python/PyYAML/ already exists, and build/common_virtualenv_packages.txt uses the same case. What change did you make? I develop on macOS, but I have no idea what platform the original source archive was made from.
from mozjs.
jdm
commented on July 18, 2024
Oh - https://github.com/servo/mozjs/tree/smuppy2/mozjs/third_party/python/pyyaml doesn't match what my local development tree contains:
godot:mozjs jdm$ ls -la mozjs/third_party/python/PyYAML
total 80
drwxr-xr-x 12 jdm staff 384 Jan 17 10:47 .
drwxr-xr-x 74 jdm staff 2368 Jan 17 10:47 ..
-rw-r--r-- 1 jdm staff 10672 Jan 17 10:47 CHANGES
-rw-r--r-- 1 jdm staff 1101 Jan 17 10:47 LICENSE
-rw-r--r-- 1 jdm staff 1781 Jan 17 10:47 PKG-INFO
-rw-r--r-- 1 jdm staff 1548 Jan 17 10:47 README
drwxr-xr-x 4 jdm staff 128 Jan 17 10:44 examples
drwxr-xr-x 6 jdm staff 192 Jan 17 10:47 ext
drwxr-xr-x 3 jdm staff 96 Jan 17 10:44 lib
drwxr-xr-x 3 jdm staff 96 Jan 17 10:44 lib3
-rw-r--r-- 1 jdm staff 793 Jan 17 10:47 setup.cfg
-rw-r--r-- 1 jdm staff 10170 Jan 17 10:47 setup.py
That's very strange.
from mozjs.
tomoverlund
commented on July 18, 2024
That's very strange.
Looks like they changed the case upstream at Mozilla at some point.
from mozjs.
jdm
commented on July 18, 2024
No more python2.x.
from mozjs.
Related Issues (20)
- Patch error message for newer macOS SDK to point at relevant docs HOT 1
- Merge mozjs and rust-mozjs into one repo HOT 4
- CI broken with mozilla-build 4.0 HOT 6
- Windows CI breaks when the environment's LLVM doesn't match the version installed by scoop HOT 8
- Remove the workaround for gcc bug.43949? HOT 1
- Add GCMethods and RootKind Implementation for Symbol
- Windows CI is broken HOT 2
- Incorrect Signature for `JS_DeletePropertyById1` HOT 2
- UWP builds are broken HOT 3
- Can't build for MacOS (Latest) HOT 7
- Where is JSContext defined as an opaque type? HOT 2
- error: failed to get `mozjs` as a dependency of package `script v0.0.1 on windows11 system HOT 5
- Builds on Windows with the Beta branch are broken HOT 9
- Incorrect Definition of JS::CreateError
- `type_traits` not found when building on Linux HOT 1
- The Integrity check is currently broken HOT 2
- Add safe GC rooting infrastructure HOT 4
- How to listen for JS Errors in rust? HOT 5
- Building with MSYS2 and GCC HOT 2
- malformed config/autoconf.mk HOT 10
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from mozjs.