serralvo / textfieldcounter Goto Github PK

Now our tests is not using a good naming spec, IMO we should update that.

https://github.com/serralvo/TextFieldCounter/blob/master/TextFieldCounter/TextFieldCounterTests/TextFieldCounterTests.swift

Good referente to follow: https://qualitycoding.org/unit-test-names/

输入中文时限制字符无效，可以无限输入，it's a bug

Hey,

Thanks for your awesome repo. I installed the latest version Installing TextFieldCounter (0.0.2)
and I imported it import TextFieldCounter however, I got this error:

What is the problem?!

Thanks.

If I set the UITextFieldDelegate in my own ViewController, the TextFieldCounter class doesn't get any delegate callbacks from UITextFieldDelegate and so it doesn't work anymore.

Is it possible to support both delegates?

Before #12

Update read-me to show new features.

• Update Features list
• Update demo image ("See how it works" gif)

It seems the version in the cocoapods repo is outdated, as the class is not open.
This causes that when importing the module, the class can't actually be used.
Would be great to fix it!! In the meantime I'll work against the repo master branch.

Hey,

It's a matter of taste, but if I were going to use TextFieldCounter (I'm not, currently), I'd prefer a block for handling when max length is reached.

textField.onMaxLengthCrossed { overLimit in
  submitButton.isEnabled = !overLimit
}

I don't love onMaxLengthCrossed as a name, but I couldn't think of anything better right away, so if you decide to add a block handler, maybe you can think of a better name.

On that note, it seems important to have a notification on the delegate if the max limit is "unreached" as well -- for instance in the block above, to re-enable the submit button.

The idea is provide a way to show the information about limits in an external label, by default, we keep using internal label (as right view).