sergiocomeron / moodle-block-common_courses Goto Github PK

Hello Sergio,

How about the following as a short description for your Common Courses block:

This block lists any courses you have in common (i.e. you are both enrolled in) with the user whose profile you are viewing.

Problem with the myaddinstance capability.

From the description, I understood this block is aimed at being present on user's profile pages. So I would expect the applicable_formats() returns something like user-profile. How does it help to allow adding the block to the frontpage only?

On role edit page debug show:
Invalid get_string() identifier: 'common_courses:myaddinstance' or component 'block_common_courses'. Perhaps you are missing $string['common_courses:myaddinstance'] = ''; in /usr/local/moodle/sites/moodleeval/moodle_371/blocks/common_courses/lang/en/block_common_courses.php?
line 353 of /lib/classes/string_manager_standard.php: call to debugging()
line 7255 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
line 2529 of /lib/accesslib.php: call to get_string()
line 2374 of /lib/accesslib.php: call to get_capability_string()
line 118 of /admin/roles/classes/capability_table_base.php: call to get_capability_docs_link()
line 135 of /admin/roles/classes/capability_table_with_risks.php: call to core_role_capability_table_base->display()
line 676 of /admin/roles/classes/define_role_table_advanced.php: call to core_role_capability_table_with_risks->display()
line 268 of /admin/roles/define.php: call to core_role_define_role_table_advanced->display()
Invalid get_string() identifier: 'common_courses:addinstance' or component 'block_common_courses'. Perhaps you are missing $string['common_courses:addinstance'] = ''; in /usr/local/moodle/sites/moodleeval/moodle_371/blocks/common_courses/lang/en/block_common_courses.php?
line 353 of /lib/classes/string_manager_standard.php: call to debugging()
line 7255 of /lib/moodlelib.php: call to core_string_manager_standard->get_string()
line 2529 of /lib/accesslib.php: call to get_string()
line 2374 of /lib/accesslib.php: call to get_capability_string()
line 118 of /admin/roles/classes/capability_table_base.php: call to get_capability_docs_link()
line 135 of /admin/roles/classes/capability_table_with_risks.php: call to core_role_capability_table_base->display()
line 676 of /admin/roles/classes/define_role_table_advanced.php: call to core_role_capability_table_with_risks->display()
line 268 of /admin/roles/define.php: call to core_role_define_role_table_advanced->display()

The file styles.css seems like copied from another block, it should be probably removed.

I am getting

Notice: Undefined property: stdClass::$icons in blocks/moodleblock.class.php on line 712

when looking at a page with your block. It is caused by the "icons" property not set in the list of courses. I admit that the phpDoc block for the block_list mentions that icons are optional. However, it seems they must always be set to avoid the notice.

The following patch seems to fix it:

--- block_common_courses.php.orig       2018-12-10 17:37:48.163602997 +0100
+++ block_common_courses.php    2018-12-10 17:43:01.872600683 +0100
@@ -62,6 +62,7 @@
 
         $this->content = new stdClass();
         $this->content->items = array();
+        $this->content->icons = array();
         $myuserid = $USER->id;
         $hisuserid = optional_param('id', 0, PARAM_INT);
         $courseid = optional_param('course', 0, PARAM_INT);
@@ -78,8 +79,10 @@
                     if ($course != $courseid) {
                         $url = './view.php?id='.$hisuserid.'&course='.$common->id;
                         $this->content->items[] = '<a href="'.$url.'">'.$coursename.'</a>';
+                        $this->content->icons[] = '';
                     } else {
                         $this->content->items[] = $coursename;
+                        $this->content->icons[] = '';
                     }
                 }
             }

When I enter to configure the "default page profile" at moodle 3.6 version the warning "Invalid argument supplied for foreach()" appears.

The current implementation calls enrol_get_all_users_courses() twice for each user and then find the intersection.

The is already an existing Moodle core API function for finding such courses - please see enrol_get_shared_courses()