sergiobenitez / proc-macro2-diagnostics Goto Github PK

proc-macro-error has some extremely popular dependents but appears to be abandoned with no activity in the past year and 3 separate merge requests updating its syn dependency. It would be neat to help users of that crate migrate to this one.

Hi Sergio 👋
Could you cut a new release of this crate with the latest version of version-check? I'm running into a version conflict with a few other libraries and it looks like the root of it is this library being pinned on 0.9.1.
If you'd like me to put up a PR I'm happy to do that.

I'm using Rocket (which is awesome, BTW) and noticed that sometimes error messages in my editor would be mangled with ASCII color codes, making the error messages very hard to read.

In terminal:

In editor:

I thought this was an issue with rust-analyzer, since I do not see the ASCII color codes printed if I pipe cargo build into cat, so I posted an issue there. But the people over there say that it is caused by your implementation of Display here:

You should really read rust-lang/rust-analyzer#15443 first to get all of the context.

I have not yet wrapped my head around all the parts involved here, since I am pretty new to Rust. But I thought I'd post this here to see what you think.

Steps to reproduce

1. Create the following crate:

cargo new -q foo
cd foo
cargo add -q [email protected]
cat <<EOF > src/main.rs
use rocket::UriDisplayPath;

fn main() {
    println!("Hello, world!");
}

#[derive(UriDisplayPath)]
pub enum Foo {
    Bar,
}
EOF

2. Optionally run cargo check.
3. Open src/main.rs with Vim.

Right now, the crate specifies syn = "2", which pulls in all the default features from syn.

Instead, the crate should specify the features it needs explicitly.