Comments (6)
Fair enough. I've just pushed update to navigation bar color for v23 and new v29 colors.xml
from edge-to-edge.
Thanks for reporting this. Transparent navigation bar can cause contrast issues on some [v23..29)
device indeed. Unfortunately this issue is device specific and can only be fixed for all devices by applying opaque black color instead of transparent one, which is not always wanted.
I added the Navigation-Bar-Transparency wiki page explaining the issue and showing how to solve it. Main readme page was updated as well. No changes to the library or demo app are actually needed IMHO, because the library doesn't control the color of the navigation bar. It's a responsibility of developers using the library.
Hope it helps.
from edge-to-edge.
Thanks. I am quite late with the changes I wanted to add into README.
Yes, I understand that this is device specific. Just wanted to give a heads up, since previously there were no mentions of such possible issues, so it could confuse some devs.
from edge-to-edge.
As to updates to sample app - I would change theme to have this color setting for the navigation bar to values-v29, since some devs might just look at you sample as reference for their code base.
So just a minor addition to play safe even for those, who don't read manual carefully 🙃
from edge-to-edge.
Wow. Thanks for such a quick update.
from edge-to-edge.
You're welcome and thanks for highlighting the issue! Closing it now.
from edge-to-edge.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from edge-to-edge.