sepastian / capistrano-unicorn Goto Github PK

Hey,

today I've upgraded one of my apps from capistrano 3.3.5 to 3.4.0 and noticed that the unicorn tasks are no more executed. After tracking the issue a bit down I've found the culprit:

At the moment the :reject is passed to the roles method instead of the on.
Adding parentheses "solved" the issue for me.

...
  desc 'Start Unicorn master process'
  task :start do
-    on roles unicorn_roles, reject: lambda { |h| h.properties.no_release } do
+    on roles(unicorn_roles), reject: lambda { |h| h.properties.no_release } do
      execute start_unicorn
    end
  end
...

But I'm not sure because I don't have enough insight into capistrano's architecture.

Best, Klaus

The following line

require "capistrano/unicorn"

has to be added to the capfile rather than deploy.rb. Please update this in docs.

Before diving down this path, would it make sense to try to merge both this and @sosedoff's gems together into one for both Capistrano 2 & 3 support under one gem and namespace?

Would @sepastian and @sosedoff be ammenable to that?

My preposal would be:

• Move capistrano 2 support under lib/capistrano/unicorn/ to model how the other Capistrano gems are modeled (i.e. Capistrano Rails, Capistrano Rbenv, etc... )
• Implement Capistrano 2/3 detection similar to how Sidekiq and others are doing it.

Whenever I do cap production unicorn:start I get the following error:

DEBUG [5a1498ab]    Starting Unicorn...
DEBUG [5a1498ab]    Starting Unicorn...
DEBUG [5a1498ab]    bash: bundle: command not found

However, if I start unicorn manually then cap production unicorn:stop works as expected.

Hi,
I have recently updated ruby (2.2.4 -> 2.3) and every cap unicorn task stopped working.

Trace:
** Invoke bundler:map_bins (first_time)
** Execute bundler:map_bins
** Invoke unicorn:start (first_time)
** Execute unicorn:start

... and nothing happens. No unicorn was stopped/started/restarted.

I am using latest:

• sepastian-capistrano3-unicorn
• capistrano
• unicorn.

Any ideas what went wrong ?