sentialx / electron-global Goto Github PK

View Code? Open in Web Editor NEW

139.0 11.0 7.0 194 KB

One Electron instance for multiple apps

License: MIT License

JavaScript 1.04% TypeScript 2.71% Shell 0.43% C++ 95.63% CMake 0.20%

electron app builder lightweight runtime auto-update

electron-global's Introduction

electron-global's People

Contributors

Stargazers

Watchers

Forkers

sapioit gary-dgc orta see7788 zimkaru twilightcoders der-ofenmeister

electron-global's Issues

electron-runtime: command not found

Since I had already installed electron builder, installed only electron runtime using this
npm install --save-dev electron-runtime and updated package.json script as "dist": "electron-runtime -m && electron-builder -m"

When i run npm run dist, I get electron-runtime command not found. Electron Builder works fine.

Am I missing something?

Not working on any macOS older than Mojave

(over 50% of Mac users)

Caching

I have a little understanding of how it work internally

I remember having cache (localstorage, cookies, etc..) issues when sharing electron binaries
How do you handle that?

Application is not executable by default

someApp/Contents/MacOS/someApp is not executable by default

Workaround (per install)

chmod +x /Applications/someApp/Contents/MacOS/someApp

Infer OS when no parameters are passed

Running

electron-global

without -m, -w or -l causes electron-global to exit with code 0 without changes.

electron-global should infer the OS automatically like electron-builder

"build" section in package.json cause ignore electron-global to run in build process.

I need to use "build" section in package.json file to customize electron-builder output. But when i use "build" section in package.json, electron-global never be invoked.

Here is with "build" section messages:

  • electron-builder version=20.44.4
  • loaded configuration file=package.json ("build" field)
  • writing effective config file=release\builder-effective-config.yaml
  • no native production dependencies
  • packaging       platform=win32 arch=x64 electron=5.0.10 appOutDir=release\win-unpacked
  • default Electron icon is used reason=application icon is not set
  • building        target=nsis file=release\Setup 2.0.0.exe archs=x64 oneClick=false perMachine=true
  • building block map blockMapFile=release\Setup 2.0.0.exe.blockmap

Without "build" section:

 • electron-builder version=20.44.4
  • loaded configuration file=C:\Users\...\electron-builder.json
  • writing effective config file=dist\builder-effective-config.yaml
  • no native production dependencies
  • packaging       platform=win32 arch=x64 electron=5.0.10 appOutDir=dist\win-unpacked
  • copying Electron source=C:\Users\...\electron-global destination=C:\Users\...\dist\win-unpacked

You'll see "copying Electron..." and it means now invoked electron-global.
Is this a bug or something else?

Env: Win10-x64 build 1903 latest update, node 12.10.0, and please don't mind electron-builder version :)

Do you think this will be merged in electron?

TypeError when building

TypeError [ERR_INVALID_ARG_TYPE]: The "data" argument must be of type string or an instance of Buffer, TypedArray, or DataView. Received type number (9)
    at Object.writeFile (internal/fs/promises.js:542:5)
    at Object.<anonymous> (/home/heath/SyncedProjects/pakkit/node_modules/electron-global/build/index.js:91:29)
    at Generator.next (<anonymous>)
    at fulfilled (/home/heath/SyncedProjects/pakkit/node_modules/electron-global/build/index.js:4:58) {
  code: 'ERR_INVALID_ARG_TYPE'
}

incorporate what arch linux suggests

arch linux rocket chat package is 23 MB, using:

https://aur.archlinux.org/cgit/aur.git/tree/?h=rocketchat-desktop
https://wiki.archlinux.org/index.php/Electron_package_guidelines
is such a strategy applicable for windws and mac also?

Not working on Linux

Description

After following the Usage section of the README file, I tried running electron-builder --linux --windows, but ended up with error:

Downloading electron-global binaries
Downloading electron-global binaries
[
  [Error: ENOENT: no such file or directory, lstat '/home/akepinski/dev/elcalc/node_modules/electron-global/download/linux/electron'] {
    errno: -2,
    code: 'ENOENT',
    syscall: 'lstat',
    path: '/home/akepinski/dev/elcalc/node_modules/electron-global/download/linux/electron'
  }
]
Done!
  • electron-builder  version=21.2.0 os=4.15.0-54-generic
  • loaded configuration  file=/home/akepinski/dev/elcalc/electron-builder.json
  • writing effective config  file=dist/builder-effective-config.yaml
  • packaging       platform=linux arch=x64 electron=6.0.4 appOutDir=dist/linux-unpacked
  • copying Electron  source=/home/akepinski/dev/elcalc/electron-global destination=/home/akepinski/dev/elcalc/dist/linux-unpacked
  ⨯ ENOENT: no such file or directory, rename '/home/akepinski/dev/elcalc/dist/linux-unpacked/electron' -> '/home/akepinski/dev/elcalc/dist/linux-unpacked/elcalc'  stackTrace=Error: ENOENT: no such file or directory, rename '/home/akepinski/dev/elcalc/dist/linux-unpacked/electron' -> '/home/akepinski/dev/elcalc/dist/linux-unpacked/elcalc'

After checking the ./electron-global directory, it only contains the electron_version file, which is empty 😢

Electron Builder configuration

{
  "appId": "me.kepinski.elcalc",
  "files": [
    "app/**/*",
    "package.json"
  ],
  "directories": {
    "buildResources": "resources"
  },
  "electronDist": "./electron-global",
  "mac": {
    "category": "public.app-category.utilities"
  },
  "dmg": {
    "iconSize": 150
  },
  "linux": {
    "target": [
      "AppImage",
      "deb",
      "rpm"
    ],
    "synopsis": "Cross-Platform Calculator",
    "description": "Cross-Platform calculator built with Electron.",
    "category": "Utility;Calculator"
  },
  "publish": null
}

Additional details

OS: Linux Mint 19.1 Xfce
Node.js version: 12.8.0
npm version: 6.10.2
electron-builder version: 21.2.0
electron-global version: 0.0.1

Use \n line endings (unix style) instead of \r\n (windows style)

Running electron-global with yarn on macOS / Linux causes:

env: node\r: No such file or directory

This can be fixed by removing \r\n endings and using \n endings instead

Stackoverflow Answer
yarnpkg/yarn#5480

Workaround:

dos2unix node_modules/*

  ⨯ Command failed: codesign --sign x --force --options runtime --entitlements .../node_modules/app-builder-lib/templates/entitlements.mac.plist
...: code object is not signed at all
In subcomponent: .../Contents/MacOS/electron_url
  stackTrace=

electron-global (macOS) requires GTK+3 but does not bundle it

Launching an app built electron-global results in

dyld: Library not loaded: /usr/local/opt/gtk+3/lib/libgtk-3.0.dylib
Referenced from: /Applications/TeleDrive.app/Contents/MacOS/TeleDrive
Reason: image not found
[1] 66490 abort /Applications/TeleDrive.app/Contents/MacOS/TeleDrive