semaperepelitsa / subdomain_locale Goto Github PK

I see that this gem doesn't support rails 5. What stops it from doing so? Is there any way I can help you getting past that?

Thank you for considering that!

Would be great if subdomain_locale can patch links in mailer as well without explicit setting locale: I18n.locale

In Gemfile:
rails (= 4.2.1) ruby depends on
activejob (= 4.2.1) ruby depends on
activesupport (= 4.2.1) ruby depends on
i18n (~> 0.7) ruby

subdomain_locale (>= 0) ruby depends on
  i18n (~> 0.6.9) ruby

Hey ho!

I'am very interested on your gem because I am do it that on my app.
The problem I have is when I switch the language on a page that has a URL that is different for every available locale. Is your gem implemented thinking in that point?

Could it be nice to have tha feature, right?

Thanks guys!

It would be good for consistency to patch polymorphic_url too to support locale parameter, like url_for. Something like:

    def polymorphic_url(record_or_hash_or_array, options = {})
      options = options.dup
      if options.key?(:locale)
        locale = options.delete(:locale)
        options[:subdomain] = subdomain_locales.subdomain_for(locale)
        options[:only_path] = false
      end
      super record_or_hash_or_array, options
    end

I don't know yet where to monkeypatch this method.

subdomain_locale at ... did not have a valid gemspec.
This prevents bundler from installing bins or native extensions, but that may not affect its functionality.
The validation message from Rubygems was:
  ["test/controller_test.rb", "test/lib/i18n.rb", "test/acceptance_test.rb"] are not files

Maybe git ls-files is less error-prone.