Code Monkey home page Code Monkey logo

Comments (3)

derberg avatar derberg commented on July 3, 2024

your tests case shows all should be good

test('Return "major" if there is a "conventionalcommits" breaking change, using default releaseRules', async (t) => {
  const commits = [
    {hash: '123', message: 'fix: First fix'},
    {hash: '456', message: 'feat!: Breaking change feature'},
  ];
  const releaseType = await analyzeCommits({preset: 'conventionalcommits'}, {cwd, commits, logger: t.context.logger});

  t.is(releaseType, 'major');
  t.true(t.context.log.calledWith('Analyzing commit: %s', commits[0].message));
  t.true(t.context.log.calledWith('The release type for the commit is %s', 'patch'));
  t.true(t.context.log.calledWith('Analyzing commit: %s', commits[1].message));
  t.true(t.context.log.calledWith('The release type for the commit is %s', 'major'));
  t.true(t.context.log.calledWith('Analysis of %s commits complete: %s release', 2, 'major'));
});

our config https://github.com/asyncapi/spec-json-schemas/blob/master/.github/workflows/.releaserc do not have any special rules.


it failed again: https://github.com/asyncapi/spec-json-schemas/actions/runs/4810798555/jobs/8563967377

[4:00:29 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  Analyzing commit: feat!: release version 5.0.0
[4:00:29 PM] [semantic-release] [@semantic-release/commit-analyzer] › ℹ  The commit should not trigger a release

from commit-analyzer.

derberg avatar derberg commented on July 3, 2024

I think our config file is ignored and default angular convention is used that do not respect conventional commits fully and feat! is not a breaking change for them. Further investigating

from commit-analyzer.

derberg avatar derberg commented on July 3, 2024

closing, I was right, problem was with releaserc location

from commit-analyzer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.