Code Monkey home page Code Monkey logo

Comments (20)

angylada avatar angylada commented on August 24, 2024 8

I could reproduce this issue locally as well. I tried downgrading every npm package we need for semantic-release to run, which received a new release in the past few days.
When downgrading conventional-changelog-conventionalcommits to version 6.1.0 it worked as it did one week ago. So the bug seems to be related to this package.

from commit-analyzer.

levibostian avatar levibostian commented on August 24, 2024 3

Huge thanks to @angylada for their debugging.

If it's helpful for others using cycjimmy/semantic-release-action on GitHub Actions, installing 6.1.0 of conventional-changelog-conventionalcommits did fix this for me.

      - name: Deploy git tag and Gradle plugin release via Semantic Release 
        uses: cycjimmy/semantic-release-action@v3
        with: 
          # Hard-coding version as workaround https://github.com/semantic-release/commit-analyzer/issues/517#issuecomment-1697193361
          extra_plugins: |
            @semantic-release/git
            @semantic-release/exec
            [email protected] 
        env:
          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

from commit-analyzer.

efr-devgod avatar efr-devgod commented on August 24, 2024 1

Just digging around, not 100% sure, maybe someone can have a good look as well. In version 7.0.0 of conventional-changelog-conventionalcommits, the path of files have moves from dash-words to camelCase. I believe this is causing the commit-analyzer to fail?

conventional-changelog/conventional-changelog@8d0ffbe

https://github.com/semantic-release/commit-analyzer/blob/master/lib/load-parser-config.js#L24C30-L24C30

from commit-analyzer.

spulci avatar spulci commented on August 24, 2024 1

Just digging around, not 100% sure, maybe someone can have a good look as well. In version 7.0.0 of conventional-changelog-conventionalcommits, the path of files have moves from dash-words to camelCase. I believe this is causing the commit-analyzer to fail?

conventional-changelog/conventional-changelog@8d0ffbe

https://github.com/semantic-release/commit-analyzer/blob/master/lib/load-parser-config.js#L24C30-L24C30

We fixed the issue in our installation reverting to

together with

@semantic-release/[email protected]

We're using semantic release 20.x actually. We've not tested latest commit-analyzer releases (we will do tomorrow). So it seems that the issue is related to conventional-changelog-conventionalcommits > 6.1.0 as far as we can understand

from commit-analyzer.

dnaprawa avatar dnaprawa commented on August 24, 2024 1

I've got the same problem as author of the issue while using official Github Action for Semantic Release – do we have any solution to fix it?

from commit-analyzer.

fredrikgh avatar fredrikgh commented on August 24, 2024

We have noted the same behaviour. No hint yet.

Reproduced locally and it does indeed exit 0.

from commit-analyzer.

fredrikgh avatar fredrikgh commented on August 24, 2024

There seems to be some activity on deps, where 4 packages were upgraded, later reverted but now one got upgraded again. Do they have a cross-dependency now causing issues?

image

from commit-analyzer.

travi avatar travi commented on August 24, 2024

since we are seeing feedback about this issue coming in though multiple issues, i've created a tracking issue at semantic-release/semantic-release#2929 to centralize the conversation

from commit-analyzer.

travi avatar travi commented on August 24, 2024

summary here, exiting with zero is an issue that we do need to investigate but the root cause is the breaking updates to the conventional-changelog presets that happened over the weekend since you are using a different preset than the default (and therefore installing it separately from semantic-release itself).

our focus will be on addressing the preset updates first, but i will leave this issue open so that we follow up by investigating the lack of failure. if someone would be interested in helping to track down that problem in parallel with our efforts focused on presets, we would welcome the help.

from commit-analyzer.

travi avatar travi commented on August 24, 2024

There seems to be some activity on deps, where 4 packages were upgraded, later reverted but now one got upgraded again. Do they have a cross-dependency now causing issues?

appreciate the investigation here and i can certainly see how this would appear to be related. unfortunately, this was related to the preset updates exposing a gap to how our pipeline stages were protecting (or not as it turned out) against auto merging updates that failed the build. after fixing our pipeline, i reverted the presets that we test against as dev dependencies, but accidentally also reverted the prod dependency that was safe to be merged because of the related naming.

in the end, the using a custom preset and installing the latest major version that comes with breaking changes that semantic-release is not ready for is the root issue. installing the previous major version for now should resolve issues for folks seeing this problem

from commit-analyzer.

vytautas-pranskunas- avatar vytautas-pranskunas- commented on August 24, 2024

Same here... I am using github actions and specifying versions not helping. Today it was planned to do release and BAM.. it is failing... feeling frustruated...

Maybe anyone has an idea how to override versions in github action?
My current code look slike this:

  • name: Semantic Release
    uses: cycjimmy/semantic-release-action@v3
    id: semantic
    with:
    semantic_version: 19
    extra_plugins: |
    @semantic-release/[email protected]
    [email protected]
    @semantic-release/git
    @semantic-release/changelog
    @semantic-release/[email protected]
    conventional-changelog-eslint
    env:
    RUNNER_DEBUG: 1

but it does not work

@spulci are you doing this in github actions file? Maybe you can share full step config?

from commit-analyzer.

spulci avatar spulci commented on August 24, 2024

Same here... I am using github actions and specifying versions not helping. Today it was planned to do release and BAM.. it is failing... feeling frustruated...
@spulci are you doing this in github actions file? Maybe you can share full step config?

Sorry, my CI is actually on Gitlab...but I've just fixed the couple of plugin version stated in my previous message, nothing more. Please double check that you've invalidated your CI cache if any..it could be of help hopefully.

from commit-analyzer.

vytautas-pranskunas- avatar vytautas-pranskunas- commented on August 24, 2024

@spulci but have you specified those versions under extra_plugins: or where? Maybe you can drop here some configs from gitlab?

from commit-analyzer.

vytautas-pranskunas- avatar vytautas-pranskunas- commented on August 24, 2024

When i do this for github actions:

- name: Semantic Release
        uses: cycjimmy/semantic-release-action@v3
        id: semantic
        with:
          semantic_version: 19
          extends: |
            @semantic-release/apm-config
            @semantic-release/[email protected]
            [email protected]
          extra_plugins: |
            @semantic-release/git
            @semantic-release/changelog
            @semantic-release/[email protected]
            conventional-changelog-eslint
        env:
          RUNNER_DEBUG: 1

it starts to analyze commits but not respecting cofiguration specified in .releaserc.json file for @semantic-release/commit-analyzer

from commit-analyzer.

jmarrio1 avatar jmarrio1 commented on August 24, 2024

Yes, I can also confirm this behaviour in our pipeline. We are trying to revert to older version of semantic release.

from commit-analyzer.

spulci avatar spulci commented on August 24, 2024

@spulci but have you specified those versions under extra_plugins: or where? Maybe you can drop here some configs from gitlab?

In gitlab CI I've got this:

before_script:
    - npm install @semantic-release/git @semantic-release/commit-analyzer semantic-release-gitlab-registry @semantic-release/release-notes-generator @semantic-release/gitlab @semantic-release/changelog conventional-changelog-conventionalcommits@6 --force --no-save
  script:
    - npx semantic-release@21 --repositoryUrl ${CI_REPOSITORY_URL}

In the npm install you can see some of the plugins I'm using inside my .releaserc.yml I've got in the root of my projects. Just force conventionalcommits to release train 6.x using semantic 21.x.

from commit-analyzer.

travi avatar travi commented on August 24, 2024

When i do this for github actions:

- name: Semantic Release
        uses: cycjimmy/semantic-release-action@v3
        id: semantic
        with:
          semantic_version: 19
          extends: |
            @semantic-release/apm-config
            @semantic-release/[email protected]
            [email protected]
          extra_plugins: |
            @semantic-release/git
            @semantic-release/changelog
            @semantic-release/[email protected]
            conventional-changelog-eslint
        env:
          RUNNER_DEBUG: 1

it starts to analyze commits but not respecting cofiguration specified in .releaserc.json file for @semantic-release/commit-analyzer

it looks like you are confused about the necessary update needed to your config. adding the version to the extends block will not help and will likely result in other errors. the version needs to be specified in the extra_plugins block since that is what is doing the installation step. (note this is my understanding without being the maintainer of the action used here. if this is incorrect, you may get better information from the maintainers of that action. however, the problem you are experiencing is not because of semantic-release or the action you are using).

the odd thing about the config you are showing here is that you are mentioning conventional-changelog-conventionalcommits under extends block with a version, but you mention conventional-changelog-eslint under extra_plugins these are both commit-convention presets and you should only be using one, the one referenced in your .releaserc. did you possibly mistakenly add conventional-changelog-conventionalcommits with a version based on the feedback from this issue? if you are actually using conventional-changelog-eslint, that would be the one you need to specify a version for.

from commit-analyzer.

travi avatar travi commented on August 24, 2024

I've got the same problem as author of the issue while using official Github Action for Semantic Release – do we have any solution to fix it?

yes, the solution is to specify a version for the conventional-changelog preset that your project is installing rather than using the latest version, as is mentioned a few times in this thread and in semantic-release/semantic-release#2929. the version you specify needs to be for the previous major version since the latest major includes breaking changes that semantic-release is not prepared to work with yet

from commit-analyzer.

travi avatar travi commented on August 24, 2024

i've created semantic-release/semantic-release#2932 to track the problem of exiting with the wrong exit code. with that, i'm going to close this issue. please direct further feedback to either semantic-release/semantic-release#2929 or semantic-release/semantic-release#2932

from commit-analyzer.

vytautas-pranskunas- avatar vytautas-pranskunas- commented on August 24, 2024

When i do this for github actions:

- name: Semantic Release
        uses: cycjimmy/semantic-release-action@v3
        id: semantic
        with:
          semantic_version: 19
          extends: |
            @semantic-release/apm-config
            @semantic-release/[email protected]
            [email protected]
          extra_plugins: |
            @semantic-release/git
            @semantic-release/changelog
            @semantic-release/[email protected]
            conventional-changelog-eslint
        env:
          RUNNER_DEBUG: 1

it starts to analyze commits but not respecting cofiguration specified in .releaserc.json file for @semantic-release/commit-analyzer

it looks like you are confused about the necessary update needed to your config. adding the version to the extends block will not help and will likely result in other errors. the version needs to be specified in the extra_plugins block since that is what is doing the installation step. (note this is my understanding without being the maintainer of the action used here. if this is incorrect, you may get better information from the maintainers of that action. however, the problem you are experiencing is not because of semantic-release or the action you are using).

the odd thing about the config you are showing here is that you are mentioning conventional-changelog-conventionalcommits under extends block with a version, but you mention conventional-changelog-eslint under extra_plugins these are both commit-convention presets and you should only be using one, the one referenced in your .releaserc. did you possibly mistakenly add conventional-changelog-conventionalcommits with a version based on the feedback from this issue? if you are actually using conventional-changelog-eslint, that would be the one you need to specify a version for.

Thanks

it worked with this config

  • name: Semantic Release
    uses: cycjimmy/semantic-release-action@v3
    id: semantic
    with:
    semantic_version: 19
    extra_plugins: |
    @semantic-release/git
    @semantic-release/changelog
    @semantic-release/[email protected]
    @semantic-release/[email protected]
    [email protected]
    env:
    RUNNER_DEBUG: 1

from commit-analyzer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.