Code Monkey home page Code Monkey logo

Comments (8)

pvdlg avatar pvdlg commented on May 27, 2024 12

This is due to the way we process rules. For each commit we evaluate evaluate each of your rules, and if we find one that match we use it. IF we don't find then we look at the default rules.

Your commit is a fix and a BREAKING CHANGE. Because you have a rule that match fix and not that match a breaking change we use the fix one which trigger a patch.

In the default rules we have one (at the top) to match braking changes, but it's never evaluated as you have in your custom rule one that match your commit.

This is explained in the documentation: https://github.com/semantic-release/commit-analyzer#releaserules

To solve your problem you have to add {breaking: true, release: 'major'} at the top of your custom rules.

from commit-analyzer.

hamzahamidi avatar hamzahamidi commented on May 27, 2024 2

If you're using Angular preset don't forget to add a Colon : after the keyword BREAKING CHANGE to trigger major release:

BREAKING CHANGE: foo

from commit-analyzer.

simlu avatar simlu commented on May 27, 2024 1

Hello @pvdlg ! Thank you very much for the swift reply! It is as always very much appreciated!

Fixed in blackflux/robo-config-plugin#478

Cheers, L~

from commit-analyzer.

AlexisMasseron avatar AlexisMasseron commented on May 27, 2024

I do have the same problem, patch and minor version are triggered correctly but major version is never updated when adding "BREAKING CHANGE" to commit message

from commit-analyzer.

simlu avatar simlu commented on May 27, 2024

@AlexisMasseron Unlikely that you're have the same issue unless you're using a custom config. I suspect that you're not using the correct syntax instead. Take a look at the docs and check out my previous commit messages that correctly triggered a breaking change.

from commit-analyzer.

CheerlessCloud avatar CheerlessCloud commented on May 27, 2024

@pvdlg Hi 👋 I think that's very unintuitive behavior. What about in detail describe this case in the readme? Actually, README.md at master for now contains releaseRules without breaking: true but says that emit major release when BREAKING CHANGE exists in the commit message.

from commit-analyzer.

abohannon avatar abohannon commented on May 27, 2024

I also can't get this to work. I'm not using a custom config and none of the following commit messages cause a major version bump.

BREAKING CHANGE: foo
breaking: foo
feat: this is a BREAKING CHANGE
feat: this is a breaking change

from commit-analyzer.

travi avatar travi commented on May 27, 2024

@abohannon if you are not using a custom config, your issue is different from what was being asked in this closed issue. in the future, please open a new issue instead.

are you trying to create your commits with only a subject? be sure to instead include the BREAKING CHANGE: in the body of your commit since any type of commit could potentially be breaking for consumers, and is therefore independent of the commit type

from commit-analyzer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.