segatank / weather_adjutant Goto Github PK

View Code? Open in Web Editor NEW

0.0 0.0 1.0 1.31 MB

HTML 5.94% JavaScript 83.71% CSS 10.35%

weather_adjutant's People

Contributors

Watchers

weather_adjutant's Issues

5

weather_adjutant/src/components/SingleDayWeather.js

Lines 3 to 4 in 8125ae8

    
           const DAYS_OF_THE_WEEK = ["Sunday","Monday","Tuesday","Wednesday","Thursday","Friday","Saturday"]; 
        
           const MONTHS = ["January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"];

очень длинные данные, лучше вынести в отдельный файл и заимпортить

2

weather_adjutant/src/reducers/RootReducer.js

Lines 4 to 14 in 8125ae8

    
           export function rootReducer (state = {data: [], status: ''}, action) { 
        
             switch(action.type) { 
        
               case FETCH_WEATHER: 
        
               console.log(action) 
        
                 return {data: [action.payload], status: 'ok'} 
        
               case FETCH_ERROR: 
        
                 return {...state, status: 'error'} 
        
               default: 
        
                 return state 
        
             } 
        
           }

дефолтный стейт лучше вынести в отдельную переменную

const INIT_STATE = {data: [], status: ''};

export function rootReducer (state = INIT_STATE , action) {
  switch(action.type) {
    case FETCH_WEATHER:
      return {data: [action.payload], status: 'ok'}
    case FETCH_ERROR:
      return {...state, status: 'error'}
    default:
      return state
  }
}

1

weather_adjutant/src/index.js

Line 4 in 8125ae8

import './index.css';

index.css лучше пихать уже после все остальных импортов
типа разделять js и css импорты

7

weather_adjutant/src/components/WeatherUnit.js

Line 9 in 8125ae8

renderWeather(cityData) {

очень длинно, я даже не стал смотреть,
разбей на подфунции, заюзай методы массивов вместо циклов

4

weather_adjutant/src/components/SingleDayWeather.js

Line 41 in 8125ae8

Зачем тут фрагмент? оно и так в одном дом элементе

3

weather_adjutant/src/actions/ActionTypes.js

Line 8 in 8125ae8

export function fetchWeather(city) {

тут лучше заюзать асинхронную функцию и
https://developer.mozilla.org/ru/docs/Web/API/Fetch_API/Using_Fetch
будет раза в два меньше кода

https://gist.github.com/msmfsd/fca50ab095b795eb39739e8c4357a808

6

weather_adjutant/src/components/WeatherUnit.js

Line 54 in 8125ae8

тут фрагмент ненужен

segatank / weather_adjutant Goto Github PK

weather_adjutant's People

Contributors

Watchers

weather_adjutant's Issues

5

2

1

7

4

3

6

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	const DAYS_OF_THE_WEEK = ["Sunday","Monday","Tuesday","Wednesday","Thursday","Friday","Saturday"];
	const MONTHS = ["January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December"];

	export function rootReducer (state = {data: [], status: ''}, action) {
	switch(action.type) {
	case FETCH_WEATHER:
	console.log(action)
	return {data: [action.payload], status: 'ok'}
	case FETCH_ERROR:
	return {...state, status: 'error'}
	default:
	return state
	}
	}