sefiraat / cultivation Goto Github PK

Hello, I wanted to report a bug,
A user on my server informed me of this.
The bug allows you to place bushes anywhere, although I already saw this reported, the problem is that you can place it even within a WorldGuard region.

Server: Paper-1.20.1
WorldGuard: 7.0.9-dist
Slimefun DEV - 1104 (git c977454e)
SF Addons:
MiniBlocks vDEV - 4 (git f7a34b6e)
Networks vDEV - 50 (git 3de3c9d6)
CrystamaeHistoria vDEV - 81 (git 0c0efa95)
ExtraTools vDEV - 36 (git 922c0324)
FoxyMachines vDEV - 67 (git 0028aa93)
Quaptics vDEV - 4 (git cbc2e78e)
SfChunkInfo vDEV - 8 (git b1b94abb)
DynaTech vDEV - 201 (git 0feb2ee0)
DyeBench vDEV - 6 (git ae841c2d)
ExtraGear vDEV - 13 (git c62047e2)
GSFH v1.1\n SlimeHUD vDEV - 11 (git b6dc2d53)
InfinityExpansion vDEV - 144 (git 9da37202)
Supreme vDEV - 29 (git f9e70053)
SFCalc vDEV - 37 (git dfc0fc41)
Wildernether vDEV - 5 (git 5be3da69)
BetterReactor vDEV - 11 (git 88a98d28)
ExtraHeads vDEV - 25 (git 8c29f73a)
MobCapturer vDEV - 33 (git 6fc26c35)
FlowerPower vDEV - 16 (git 5a38d1c6)
Galactifun vDEV - 76 (git aa6414a8)
TranscEndence vDEV - 41 (git 98d7d47e)
GeneticChickengineering vDev - 3
FluffyMachines vDEV - 132 (git ccf029ba)
SlimeFrame v1.6.0
DyedBackpacks vDEV - 17 (git 8b329e96)
Gastronomicon vDEV - 8 (git 76336191)
Cultivation vDEV - 11 (git 3e25165)
SlimefunLuckyBlocks vDEV - 36 (git 60f0c8dc)
ExoticGarden vDEV - 78 (git 7f9a5f63)
DankTech2 vDEV - 9 (git aa6c2209)
LiteXpansion vDEV - 192 (git 661862ed)
SimpleUtils vDEV - 15 (git 4250fd5e)
DracFun v1.1.0
AdvancedTech vDEV - 19 (git c133bfdd)

Just planted a Sassafras bush in a sand by accident - and it cannot be picked up (or destroyed). Even when destroying the sand underneath. (It doesn't grow anything - as intended?)
As a workaround, I can replace the sand with dirt/grass and the bush starts to grow / can be picked up normally.

Recommending:

• not to be able to placed on non-valid block
• being able to be picked up/destroyed

double:

single:

Paper git-Paper-50 (MC: 1.20.1)
Slimefun DEV - 1068 (git cab97b1a)
Metrics-Module #28
Java 17

Installed Addons: (3)
  SlimeHUD vDEV - 10 (git 7d1c666b)
  InfinityExpansion vDEV - 140 (git 0098d2fb)
  Cultivation vDEV - 10 (git 441a3701)

When you right click with a seed pack in your hand on a block (where you can place it) it becomes a vanilla composter.
When placing it will still have the seed pack gui until you esc from it then the seed pack becomes a normal composter.
Video proof - https://youtu.be/q3_3d9YrEeM

@Skizzles

[Cultivation] Enabling Cultivation vDEV - 11 (git 3e25165)
[Server thread/INFO]: [Cultivation] ########################################
[Server thread/INFO]: [Cultivation] Cultivation
[Server thread/INFO]: [Cultivation] By Sefiraat and J3fftw
[Server thread/INFO]: [Cultivation] ########################################
[Server thread/INFO]: [Cultivation] [ACF] Enabled Asynchronous Tab Completion Support!
[Server thread/ERROR]: Error occurred while enabling Cultivation vDEV - 11 (git 3e25165) (Is it up to date?)
java.lang.ExceptionInInitializerError: null
at dev.sefiraat.cultivation.implementation.slimefun.items.Bushes.setup(Bushes.java:19) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at dev.sefiraat.cultivation.Cultivation.setupItems(Cultivation.java:73) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at dev.sefiraat.cultivation.Cultivation.onEnable(Cultivation.java:68) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:287) ~[purpur-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:188) ~[purpur-1.20.4.jar:git-Purpur-2141]
at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:104) ~[purpur-1.20.4.jar:git-Purpur-2141]
at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:507) ~[purpur-api-1.20.4-R0.1-SNAPSHOT.jar:?]
at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugin(CraftServer.java:653) ~[purpur-1.20.4.jar:git-Purpur-2141]
at org.bukkit.craftbukkit.v1_20_R3.CraftServer.enablePlugins(CraftServer.java:564) ~[purpur-1.20.4.jar:git-Purpur-2141]
at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:675) ~[purpur-1.20.4.jar:git-Purpur-2141]
at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:435) ~[purpur-1.20.4.jar:git-Purpur-2141]
at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:346) ~[purpur-1.20.4.jar:git-Purpur-2141]
at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1146) ~[purpur-1.20.4.jar:git-Purpur-2141]
at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:323) ~[purpur-1.20.4.jar:git-Purpur-2141]
at java.lang.Thread.run(Thread.java:1583) ~[?:?]
Caused by: java.lang.NullPointerException: Profile name must not be null
at java.util.Objects.requireNonNull(Objects.java:259) ~[?:?]
at com.mojang.authlib.GameProfile.(GameProfile.java:31) ~[authlib-6.0.52.jar:?]
at org.bukkit.craftbukkit.v1_20_R3.inventory.CraftMetaSkull.setOwningPlayer(CraftMetaSkull.java:246) ~[purpur-1.20.4.jar:git-Purpur-2141]
at dev.sefiraat.cultivation.dough.skins.CustomGameProfile.apply(CustomGameProfile.java:40) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at dev.sefiraat.cultivation.dough.skins.PlayerHead.lambda$getItemStack$1(PlayerHead.java:53) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at dev.sefiraat.cultivation.dough.skins.PlayerHead.getItemStack(PlayerHead.java:63) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at dev.sefiraat.cultivation.dough.skins.PlayerHead.getItemStack(PlayerHead.java:51) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at dev.sefiraat.cultivation.api.utils.Skins.getPlayerHead(Skins.java:579) ~[Cultivation - DEV 11 (git 3e251).jar:?]
at dev.sefiraat.cultivation.implementation.slimefun.CultivationStacks.(CultivationStacks.java:179) ~[Cultivation - DEV 11 (git 3e251).jar:?]
... 15 more

Java: 21
Purpur git-Purpur-2141 (MC: 1.20.4)
Slimefun: 1104 (git c977454e)
Cultivation: 11 (git 3e25165)

I am able to get the item out of the GUI

image: https://prnt.sc/G09_CwERaGbk
image 2: https://prnt.sc/vl-R7QhM2Dps

Pufferfish git-Pufferfish-47 (MC: 1.19.2)
Slimefun DEV - 1050 (git 22a7f422)
Metrics-Module #28
Java 17

addon: Cultivation - DEV 9 (git df727).jar

no error console.

Title. This addon and Exotic Garden may contain some of the same foods/drinks/plants/recipes/etc.

Versions:
Cultivation - DEV 11
Slimefun - DEV 1104
Purpur - 2082

latest.log

some players are saying that when they do the planting and the plant grows, and try to remove the sticks they do not disappear and become unbreakable

i went to them and tried everything, i tried in creative, i tried using worldedit, i tried breaking it every way and it doesn't come out any solution for it?

video: https://youtu.be/XkakRr4Pfqk

I was able to remove using the clearlagg plugin

video 2: https://youtu.be/l_HxaqyHmuw

Slimefun and addons version: https://prnt.sc/bXqqe8Hi64GI

step 1: store a seed type for your seed pack.
step 2: after exiting the seed pack interface you have no way of knowing what seed type it stores unless you open it.
In the seed pack item description it keeps saying set to: nothing
Video Proof:

@Skizzles

players have reported this to me, and it happens with all addon plants

Slimefun and addons version: https://prnt.sc/ueHdLKqz-1hC

video 1: https://youtu.be/FJMhRIfoqds
video 2: https://youtu.be/d3E8w__HMtA

Bushes don't seem to care where they are placed, creating unbreakable entities, like so:

https://streamable.com/r3zb4m

I have fixed this by changing HarvestableBush class's whenPlaced method to:

    @Override
    public void whenPlaced(@NotNull BlockPlaceEvent event) {
        final Block block = event.getBlock();
        final Block blockBelow = block.getRelative(BlockFace.DOWN);

        if (getPlacements().contains(blockBelow.getType())) {
            super.whenPlaced(event);
            addDisplayBush(event.getBlock().getLocation());
            event.getBlock().setType(Material.AIR);
        } else {
            event.setCancelled(true);
        }
    }

Fixed: https://streamable.com/gj7enb
I didn't do a PR because I'm 99% sure this isn't a good way to fix it.

CustomDropsListener.java onBlockBreak doesn't check if the Event is cancelled and is ignoring cancellation. This creates an issue with Protection plugins and any plugin that cancels BlockBreakEvent. For example if grass is broken, event is cancelled, the seeds will drop but the grass won't break.

I wanted to download cultivation for my slimefun server, but the download link led me to an error screen, so I made an account to create an issue for this.

when we kill the salmon, guardian and squid nothing falls from them and still gives an error in the console

Pufferfish version git-Pufferfish-14 (MC: 1.20.1) (Implementing API version 1.20.1-R0.1-SNAPSHOT) (Git: 1e911fb on HEAD)

video: https://youtu.be/qiwRBQWiaw4
error console: https://prnt.sc/LG66XoSeAKfV

slimefun version and addons: https://prnt.sc/q52sfhmIMVaS

wildstacker said the problem is with slimefun not with him: https://prnt.sc/a-ZWqdgiqDUB