Code Monkey home page Code Monkey logo

ringsdb's People

Contributors

baptistemanson avatar dkaygithub avatar eric-parsons avatar joezimjs avatar oleksandrberchenko avatar olivierkes avatar seastan avatar sydtrack avatar thaurdir avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

ringsdb's Issues

When printing decks, show the set of each card even while sorting by card type

Currently, users can click the print button and get a very nice color print of their deck while the cards are sorted by card type. With that view, the set of a particular card is only visible in parentheses if there are multiple variations of that card.

Users can also download a text version of their deck, which nicely sorts by card type AND shows the set of every card in parentheses, but because it's a plain text file, the color information is lost, which is quite useful to differentiate sphere. Users can download an HTML version of their deck which gets pretty close to the request (below), but isn't formatted as nicely as the normal "print" feature.

Request: When using the "print" button for a deck while sorted by card type, allow an option to show the set of every card (or, just always show the set of every card, because it's easy to ignore if you don't want it).

Note: I realize that if I sort the deck by set, then the set of every card is shown, but I find that display overwhelming, and much less useful when trying to reference the decklist during play.

Thank you for all the amazing work you've done on this site! <3

Suggestions (Quest Log)

Hi, I have a couple of suggestions for the quest log.

  1. If it is possible, put a selection for number of players. E.g. I'd like check which quest I did in 2 players without opening each quest and check if the victory was achieved in 1,2,3 or 4 players...
  2. If it is possible, put a "download" or "backup" your quest: a simple pdf generator of data of the quest (maybe name of quest, victory/defeat, score, players, heroes played or something like that) so it can be download and share with friends without access to internet. Moreover, if you think to reset the log, I won't lose everything :(
    thanks a lot for all your great work!

BUG: Card links in email notifications of comments aren't valid (except for the link to the deck)

Steps to Reproduce:

  1. Publish a deck. Have email notifications for comments turned on.
  2. Have someone make a comment on your deck and include a link to a card in the comment.
  3. Notice in the email notification that if you click on the card link, the URL is invalid. e.g. the hyperlink for the card is "http:///card/02123"

Expected Behavior: The URL in the email notification should be of the format "http://ringsdb.com/card/02123"

Note: The links to the deck itself and the fine print to account settings work properly.

Where is the help on the deck Notes markdown?

The deck Notes editor can insert card names with links, etc. Where is the documentation for the RingsDB markdown? I have spent like 15 minutes looking for it again, and can't find it (and so can't mention cards in a convenient way).

Add missing quest statistics (or remove it completely)

The following quests don't have card statistics:

  • Journey up the Anduin
  • Mount Gundabad
  • The Fate of Wilderland
  • 3 A Shadow in the East quests
  • 6 The Vengeance of Mordor quests
  • The Siege of Annúminas
  • Attack on Dol Guldur

Updating card images/text?

Hi. I've noticed some cards on Hall of Beorn have post-errata text but the same cards on RingsDB have pre-errata text (both in text and on images). Is there a way I can help update the images/text on RingsDB to match Hall of Beorn?

Filter for The collection

Add to smart filter a new criteria "m" or any other letter, to retrieve just the cards from "My collection".

For example: k:hobbit t:hero m:1

Allow decks to search cards by ID

The card search allows one to enter a numeric ID and find a card (e.g. 04110, which means set #4, card #110). This is very useful for players of non-English editions.

Now, it would be great if the card search in the deck builder allowed the same thing. Otherwise, it is really hard to save a non-English real deck to RingsDB, which limits its usage. Or maybe I missed a feature that would help with this?

Feature Request: Custom Card Support?

With projects such as your own (Seastan's) Long-extended Party on the horizon, I am wondering about the feasibility of enabling RingsDB users to include custom cards in RingsDB's slick deckbuilding UI - even if limited to using local files, and creating unpublishable decks, for example.

My non-coder ass doesn't have an idea on where such functionality would fall on the spectrum between "easy" and "outlandishly impractical," so please close this issue if it's clearly outside the scope of this fine project, haha. RingsDB's footer sent me here for "feature requests," and importing custom cardsets into this tool, even if just for personal use, would be a real boon; furthermore, I imagine it could expand the audience for content like A Long-extended Party, or tools like your own lotr-lcg-set-generator.

In any case, thank you for your work in this community, @seastan.

More convenient set selection system when deckbuiding

When building a deck, it is cumbersome to select only a few sets, on mobile: they all start selected.

It would more generally be very useful to have a set selection system which is convenient for progression players (and players who don't have many sets).

A relatively simple solution, in terms of user interface, would be to save the list of selected sets for deckbuilding between deck builds. It could for instance be associated with the account (thus reflecting the sets that a user is currently playing with). This would make deck building much more practical (and would solve the issue with mobiles described above).

Thanks!

option to show prior version of a card

Is there a way to get the original text of a card? I'm envisioning a "History" section on the /card/ page, or something to that effect.

Reading old decks, it's frustrating to not understand how it was originally supposed to work.

Feature Request : Adding First Age player cards

It would be great to be able to use ringsDB to make First Age decks. I think there would be two ways to do it : adding the player cards from the cycle and a set with the approved list and disable them everywhere by default, or make a separate instance (similar to the digital deckbuilder) for First Age deckbuilding. The cards are on Hall of Beorn which should save some time.
If you want to do it, I'd be happy to help in any way (with my admittedly limited skills).

Deck search support for functionally identical cards

Currently when searching for a decklist using the Cards used feature, you have to select a specific instance of a card, e.g. selecting leadership "Faramir Core Set" vs "Faramir Two-Player Limited Edition Starter". vs "Faramir Defenders of Gondor". It would be helpful if you could search for decks that use any version of this functionally identical card.

The same would be helpful when limiting the search criteria via the Select Allowed Packs feature (even without a Cards used selected). Now that the new Starter Decks are available, I would have thought that adding them to my collection and doing a deck search would have opened up my results to more possibilities. But, because the results are limited to the specific instances of cards, even though I now own, e.g., Celeborn via the starter, I will not see decks that have The Dunand Trap version of Celeborn as a hero. I know I can select all packs and get more results, but that doesn't help when trying to limit results with the mindset of "What can I build using what I have?", which is where I'm coming from.

Thanks for your time, and thanks for all your work on ringsdb & dragncards!

Cheers,
Tom

Confirmation message not received for ringsdb

Hello
I would like to register on the ringsdb website but I never receive the confirmation message on my email address.
My username on the site is Loboliv
How can I fix this?
Sorry and thank you in advance

Select allowed sets doesn't permit core set quantity

I only dipped so much of my foot into LotR LCG, so I only have one core set. However, basically all the decklists I'm seeing assume I have 3, so they're not quite useful. Any chance of enabling additional options for specifying that I have 1, 2, or 3 core sets, and leaving out the decklists that asks for more copies of certain cards than I have?

Improve the list of sets

The list of https://ringsdb.com/search has to issues:

  1. A few sets display some numbers in brackets like "(104/102)", "(13/14)" or "(86/999)". This information is incorrect and simply confusing. Probably, it makes sense to remove it completely.
  2. We don't need "Print on Demand (0/99)" with 0 cards inside.

Request: mark decks as progression/full collection/not all cards available

Sometimes it is not obvious in what catrgory a deck belongs (and thus how good a deck is overall). To be able to judge a (forced) classification uppon publication would be nice.

Categories which sprung to my mind are:
-progression (or other limitiations)
-using the full collection
-thematic (e.g. no Steward of Gondor in a dwarf deck)
-limited (but kind of random) collection

On top, these categories should be another way to filter the search results.

Bug in fellowship search

I have noticed that many fellowships are missing from the search result when I put the Max Number of Non-Core Playsets to 1, even though the fellowship does not contain more than 3 copies of each non-coreset card.

Test case
Number of decks: 4
Max Number of Core Sets: 3
Max Number of Non-Core Playsets: 1

There are several fellowships that should show up but they don't. They only appear when I put Max Number of Non-Core Playsets to 2 (for example, this one: https://ringsdb.com/fellowship/view/3430/shadows-of-mirkwood).

Rules Section

Similar to Thronesdb.com, there's an indexed RRG and FAQ built-in to the site. I think it would be great to have it built-in here as well.

New Feature: Site-wide filter for owned cards/sets

I love the RingsDB and it's been an excellent tool to start recording the decks, sets, and scenarios I build, acquire, and play. I have however found it difficult to engage with more of the 'community' features thus far, because I'm looking to only expand my knowledge of the card-base gradually as I play into/open a broader collection (not everything all at once).

I see the site allows me to record the sets/cards I own.

I'd love for there to be a way to filter site-wide for my user account (particularly in the community section) to decks that only contain cards I've listed I own.

This would also allow me to potentially meet/find/interact more easily with others that also are at a similar point in their collection building.

Construct fellowships with decks that are not tournament legal

Hi! I just started using ringsdb and it looks like I'm unable to create fellowships using decks that aren't tournament legal (in this case containing less than 50 cards).

I have five decks, two have 50 cards, the rest have less. When I go to create a fellowship and click "add deck", I can only add decks that are tournament legal:

Screen Shot 2020-09-18 at 7 12 54 PM

Screen Shot 2020-09-18 at 7 13 07 PM

Combining "Gandalf" (Starter #4) with "Gandalf" of other Sets

If a Deck is built using exactly three copies of the "Gandalf" ally with at least one copy from Two-Player Limited Edition Starter #4 and copies of "Gandalf" from other sources, the Deck is marked as "Contains too many copies of a card (by title)".

This does not occur when the Two Player Limited Edition Starter #37 version of "Gandalf" is used in the same manner, nor does it occur with any other card from the Starter I have tested.

No filtering through simple text in deck builder?

Looking for "Song" in the text filtering field in the deck builder does not filter "Song of…" cards. Instead, no filter is applied. Since the field reads "… or filter the list", I was expecting the Songs to be filtered and shown, only.

Any way to update a fellowship?

Am I crazy, or is there no way to update the decks/deck versions used in a fellowship (and then subsequently version the fellowship.) I think this would be a pretty cool feature to have in there.

QOL improvement request for "Sets" dropdown checkboxes when creating/editing a deck

Hey guys,

I'm just getting into LOTR:LCG and absolutely LOVE the online setup you've provided for streamlining deck creation and seamless integration into DragnCards.

Literally the ONLY suggestions I have are the following (apologies if there's already a way to perform these and I've just missed them):

  1. Add a "select/unselect all" option in the "Sets" dropdown
  2. Add the ability to save a search or if that's a bit much, perhaps have the search state persist on subsequent sessions

On the first suggestion, there are currently 83 total sets to choose from and because I'm only interested in choosing from the Core set at the moment, I need to untick 82 checkboxes every time I create or modify a deck because the search state resets once you leave the deck editing state.

The second suggestion really just piggybacks the first in that it would be cool to create "deck specific" searches so that when I want to make minor tweaks to a deck, I could load up a past search so that I only see the pool of cards I want to choose from for that deck.

I really do appreciate all your time and efforts that have been invested into this great site!

Deck Import cannot distinguish between cards with the same name in the same pack

Defenders of Gondor includes two versions of Faramir: an ally (33010) and a hero (33028)

Exporting the deck as text will produce "Faramir (Defenders of Gondor)" for either of the IDs above.
Importing a deck with the same string will always add ally Faramir.

I could find no way to get card 33028 to add to the deck via text import. Some way to distinguish the two Faramirs, or import cards by ID rather than name may solve this.

Quest Logs is down

Some kind of server error. Tested with my account (which has had username changes) and with a fresh new account (with none).

"The server encountered an error 500. Please report it on GitHub."

Improving set selection in the deckbuilder

The set selection is very useful for building progression decks but currently a bit impractical.

  • Sometimes when I uncheck a set, the page reloads and my browser becomes unresponsive for a few seconds (Firefox 78.9.0esr)
  • Higher level checkboxes for cycles would save a lot of time, as well as all/none buttons.
  • I'd personally prefer a "collection" tab to the current drop-down format, but maybe that's just me (may work better on tablet/mobile too)

I think netrunnerDB nailed this, maybe some code could be reused from there ?
Screenshot from 2021-04-18 14-37-03

Missing images

The card database from the API shows several cards are missing images. Looks like mostly contracts and recently released cards -- though Hall of Beorn does seem to be up to date through Fortress of Nurn:

Gandalf (Two-Player Limited Edition Starter)
The Burglar's Turn (Wrath and Ruin)
Forth, The Three Hunters! (The City of Ulfast)
The Grey Wanderer (Challenge of the Wainriders)
Gildor Inglorion (Under the Ash Mountains)
Wandering Exile (Under the Ash Mountains)
Valiant Sword (Under the Ash Mountains)
Stone of Elostirion (Under the Ash Mountains)
Well Preserved (Under the Ash Mountains)
Northern Bowmaster (Under the Ash Mountains)
Reckless Attack (Under the Ash Mountains)
Odo Proudfoot (Under the Ash Mountains)
Defiant Challenge (Under the Ash Mountains)
Helm of Secrecy (Under the Ash Mountains)
Council of the Wise (Under the Ash Mountains)
Messenger of the King (The Land of Sorrow)
Bond of Friendship (The Fortress of Nurn)
(MotK) Odo Proudfoot (Messenger of the King Allies)

New feature request: Select fellowship while deckbuilding

I would like a feature that lets you select a fellowship from your collection while building a deck.

When a fellowship with existing deck(s) is selected, the (amount of) cards already used would be reduced from the collection.

Some way to mark/delete outdated, published decks

There is a hype for the new contracts, which is totaly understandable. But people create and publish decks with the wong contract as a placeholder. When searching for decks which do contain that contract these "wrong" decks also appear. There are other cases of placeholder, too. Also, eratas make certain decks kind of unuseable, like hero Boromir or hero Hama.

I think there should be a way to mark these decks (by other people in case of the original poster isn't online anymore). If the deck doesn't get corrected by the original creator these deck will be removed from beeing visible for all people. Or at least there should be a filter for hiding these.

Thank you.

Enhancement: Quest Log filter on scenario and player count

The Quest Log is a great feature. I log my quests along with notes, and I also use it to find deck ideas for particular scenarios. If you have time and it is possible, I would like to see a feature added to the Quest Log (the public view) that allows me to filter on a specific scenario and maybe also player count.

Missing official quests

The following quests are missing:

  • The Mines of Moria
  • Escape from Khazad-dûm
  • The Hunt for the Dreadnaught

Save the checked/unchecked sets for a given deck

Currently, when a player is deckbuilding, they can filter the visible sets by clicking checkboxes in the "sets" filter, which is great! Unfortunately, when the player saves the deck and returns to editing it later, the selected sets aren't saved.

Instead, the sets that were selected when the deck was saved should be automatically selected when the deck is edited in the future.

Use Case: Often I'll make a deck with certain constraints, either because I'm making a deck for a new player with a limited collection, or I'm working on a deck for a particular quest and I don't want to use cards that were published after that quest. When I come back to edit the deck, I want the sets to be remembered.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.